-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MWPW-154135: restricted gnav personalization #57
Conversation
- supports removal in hideElement function - adds getMainNavItems utility function - personalizes the main nav items - adds region condition
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch.
|
- fixes unit tests
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## stage #57 +/- ##
==========================================
- Coverage 83.74% 83.41% -0.33%
==========================================
Files 10 10
Lines 3100 3165 +65
==========================================
+ Hits 2596 2640 +44
- Misses 504 525 +21 ☔ View full report in Codecov by Sentry. |
- adds personalization for sync dropdown links
- adds personalization for link group blocks
- adds personalization for main nav menu sections
@richardhand seems like we should add unit test for this, right? |
- PR feedback
- PR feedback
- removes region condition since each region has its own gnav
- removes region condition since each region has its own gnav
- adds hasSalesCenterAccess utility - allows passing a conditions config to hide and should hide - rewrites sales center urls for any marked anchors
- adds unit tests
- adds generic handling for rewriting stage sales force links
- removes unused mock file
MWPW-154135
Sales Center(partner-personalization, partner-sales-access)
hideElement
functionhideElement
,shouldHide
Example personalized restricted gnav document
Before: https://stage--dme-partners--adobecom.hlx.live/channelpartners/
After: https://mwpw-154135-restricted-gnav--dme-partners--adobecom.hlx.live/channelpartners/