Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MWPW-154135: restricted gnav personalization #57

Merged
merged 15 commits into from
Sep 23, 2024

Conversation

richardhand-fortedigital
Copy link
Collaborator

@richardhand-fortedigital richardhand-fortedigital commented Sep 11, 2024

MWPW-154135

  • personalizes:
    • main nav personalized elements (links, text, primary CTA, secondary CTA, dropdown triggers)
    • main nav menu separated sections
    • main nav menu link group blocks
  • adds sales center condition for main nav e.g. Sales Center(partner-personalization, partner-sales-access)
  • adds general logic for rewriting stage sales force links
  • supports removal in hideElement function
  • supports conditions config in hideElement, shouldHide

Example personalized restricted gnav document

Before: https://stage--dme-partners--adobecom.hlx.live/channelpartners/
After: https://mwpw-154135-restricted-gnav--dme-partners--adobecom.hlx.live/channelpartners/

- supports removal in hideElement function
- adds getMainNavItems utility function
- personalizes the main nav items
- adds region condition
Copy link

aem-code-sync bot commented Sep 11, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-sync branch

Note: PSI checks are disabled due to site authentication. Please utilize your org/client side GHA PSI implementation

Commits

@richardhand-fortedigital richardhand-fortedigital changed the title MWPW-154135 - restricted gnav personalization MWPW-154135: restricted gnav personalization Sep 11, 2024
@aem-code-sync aem-code-sync bot temporarily deployed to MWPW-154135-restricted-gnav September 11, 2024 14:23 Inactive
@codecov-commenter
Copy link

codecov-commenter commented Sep 11, 2024

Codecov Report

Attention: Patch coverage is 68.75000% with 25 lines in your changes missing coverage. Please review.

Project coverage is 83.41%. Comparing base (d7ed8df) to head (5eb07c0).

Files with missing lines Patch % Lines
edsdme/scripts/personalization.js 66.66% 25 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            stage      #57      +/-   ##
==========================================
- Coverage   83.74%   83.41%   -0.33%     
==========================================
  Files          10       10              
  Lines        3100     3165      +65     
==========================================
+ Hits         2596     2640      +44     
- Misses        504      525      +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

- adds personalization for sync dropdown links
@aem-code-sync aem-code-sync bot temporarily deployed to MWPW-154135-restricted-gnav September 11, 2024 15:07 Inactive
- adds personalization for link group blocks
@aem-code-sync aem-code-sync bot temporarily deployed to MWPW-154135-restricted-gnav September 11, 2024 15:30 Inactive
- adds personalization for main nav menu sections
@Ben-Zahler
Copy link
Collaborator

@richardhand seems like we should add unit test for this, right?

@aem-code-sync aem-code-sync bot temporarily deployed to MWPW-154135-restricted-gnav September 16, 2024 11:30 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to MWPW-154135-restricted-gnav September 16, 2024 11:41 Inactive
- removes region condition since each region has its own gnav
- removes region condition since each region has its own gnav
- adds hasSalesCenterAccess utility
- allows passing a conditions config to hide and should hide
- rewrites sales center urls for any marked anchors
@richardhand-fortedigital
Copy link
Collaborator Author

@zagi25 - I added sales center support in b3f0edc, if you have a chance to take a look

- adds generic handling for rewriting stage sales force links
@aem-code-sync aem-code-sync bot temporarily deployed to MWPW-154135-restricted-gnav September 17, 2024 08:32 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to MWPW-154135-restricted-gnav September 17, 2024 09:41 Inactive
@richardhand-fortedigital richardhand-fortedigital merged commit d08afb6 into stage Sep 23, 2024
4 checks passed
@richardhand-fortedigital richardhand-fortedigital deleted the MWPW-154135-restricted-gnav branch September 23, 2024 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants