Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tutorials Block Video Optimization #1206

Draft
wants to merge 14 commits into
base: stage
Choose a base branch
from

Conversation

echen-adobe
Copy link
Collaborator

@echen-adobe echen-adobe commented Oct 11, 2024

Fixes following issues|Adds following features:

  • Issue/Feature 1
  • Optimizes the UX of the Tutorials Card by preloading videos. Previously, the video element was only constructed when the user clicked on it, meaning it would only start loading after the user is interested in it. With this change, the video element will start loading with the page so that it is ready to play the moment the user clicks on it.
  • Tweaks the SUSI light feature so that it loads a bit faster.

Resolves: https://jira.corp.adobe.com/projects/MWPW/issues/MWPW-159847

Steps to test the before vs. after and expectations:

  • Steps for feature 1
    Visit the pages below and verify there is no regression in UX for the user. Make sure that the videos play normally on a range of devices.

Pages to check for regression and performance:

@echen-adobe echen-adobe marked this pull request as draft October 11, 2024 20:48
Copy link

aem-code-sync bot commented Oct 11, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@aem-code-sync aem-code-sync bot temporarily deployed to education-page-optimizations October 11, 2024 21:47 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to education-page-optimizations October 11, 2024 21:56 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to education-page-optimizations October 11, 2024 22:00 Inactive
@echen-adobe echen-adobe changed the title Education page optimizations Tutorials Block Video Optimization Oct 17, 2024
Copy link

aem-code-sync bot commented Oct 17, 2024

Page Scores Audits
📱 /education/express PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS
🖥️ /education/express PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS
📱 /express/learn/students PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS
🖥️ /express/learn/students PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS

@aem-code-sync aem-code-sync bot temporarily deployed to education-page-optimizations October 21, 2024 17:12 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to education-page-optimizations October 22, 2024 21:05 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant