Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gallery superhero fixes #20

Merged
merged 11 commits into from
May 9, 2024
Merged

Gallery superhero fixes #20

merged 11 commits into from
May 9, 2024

Conversation

amol-anand
Copy link
Collaborator

@amol-anand amol-anand commented May 9, 2024

  • gallery options for 20 or 48 at a time with infinite scrolling and loading based on which url it is on
  • horizontal masonry gallery

Items left which I will build out tomorrow:

  • favorites and view buttons on the hover of gallery images
  • CTA at the bottom of the short gallery
  • Superhero performance

before: https://main--firefly--adobecom.hlx.live/
after: https://gallery-superhero--firefly--adobecom.hlx.live/

before: https://main--firefly--adobecom.hlx.live/drafts/amol/gallery
after: https://gallery-superhero--firefly--adobecom.hlx.live/drafts/amol/gallery

Copy link

aem-code-sync bot commented May 9, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link

aem-code-sync bot commented May 9, 2024

Page Scores Audits Google
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/drafts/amol/gallery Lighthouse returned error: Something went wrong. PSI

This was linked to issues May 9, 2024
@kunwarsaluja kunwarsaluja merged commit 99a7b6b into main May 9, 2024
2 of 3 checks passed
@kunwarsaluja kunwarsaluja deleted the gallery-superhero branch May 9, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Superhero Block Gallery
2 participants