-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/gallery favourite #25
Conversation
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
|
const url = FAVOURITE_URL.replace('$', imageId); | ||
const headers = new Headers({ | ||
'X-Api-Key': 'alfred-community-hubs', | ||
'community_id': 'ff_community', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Favourite button feature is still to be completed.
GETTING_IMAGES = false; | ||
} | ||
|
||
export default async function decorate(block) { | ||
let size = SHORT_GALLERY_SIZE; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why pull in 48 when we need only 20 for the short gallery size
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@amol-anand On the live site, the overflow effect is achieved this way. There, it renders 48 images and shows only ~ 20 images, I am trying to achieve similar effect here by setting the height of the container equal to height of first 5 images (as the container is a 4x5 table) and setting overflow: hidden for the container.
Ticket/Issue number(s)
Issue #3
Test URLs
Fixes:
Randomizing Gallery images on every load of the page.
implemented images overflowing beyond the viewmore button like on the live site.
ESlint fixes
Gallery style fixes