Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/gallery favourite #25

Merged
merged 7 commits into from
May 16, 2024
Merged

Feature/gallery favourite #25

merged 7 commits into from
May 16, 2024

Conversation

kailasnadh790
Copy link
Collaborator

@kailasnadh790 kailasnadh790 commented May 16, 2024

Ticket/Issue number(s)

Issue #3

Test URLs

Fixes:

  • Randomizing Gallery images on every load of the page.

  • implemented images overflowing beyond the viewmore button like on the live site.
    Screenshot 2024-05-16 at 11 09 20 AM

  • ESlint fixes

  • Gallery style fixes

Copy link

aem-code-sync bot commented May 16, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@aem-code-sync aem-code-sync bot temporarily deployed to feature/gallery-favourite May 16, 2024 14:38 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to feature/gallery-favourite May 16, 2024 15:02 Inactive
Copy link

aem-code-sync bot commented May 16, 2024

Page Scores Audits Google
/drafts/kailas/kailas-index PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

const url = FAVOURITE_URL.replace('$', imageId);
const headers = new Headers({
'X-Api-Key': 'alfred-community-hubs',
'community_id': 'ff_community',
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Favourite button feature is still to be completed.

GETTING_IMAGES = false;
}

export default async function decorate(block) {
let size = SHORT_GALLERY_SIZE;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why pull in 48 when we need only 20 for the short gallery size

Copy link
Collaborator Author

@kailasnadh790 kailasnadh790 May 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amol-anand On the live site, the overflow effect is achieved this way. There, it renders 48 images and shows only ~ 20 images, I am trying to achieve similar effect here by setting the height of the container equal to height of first 5 images (as the container is a 4x5 table) and setting overflow: hidden for the container.

@kailasnadh790 kailasnadh790 merged commit eef3d31 into main May 16, 2024
2 of 3 checks passed
@kailasnadh790 kailasnadh790 deleted the feature/gallery-favourite branch May 16, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants