fix failing tests

adobecom · May 28, 2024 · 66fa715 · 66fa715
1 parent 92dab37
commit 66fa715
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/libs/blocks/merch-card/merch-card.js b/libs/blocks/merch-card/merch-card.js
@@ -417,16 +417,16 @@ export default async function init(el) {
   merchCard.setAttribute('filters', categories.join(','));
   merchCard.setAttribute('types', types.join(','));
 
+  const footer = createTag('div', { slot: 'footer' });
   if (ctas) {
     if (merchCard.variant === 'mini-compare-chart') {
       decorateButtons(ctas, 'button-l');
     } else {
       decorateButtons(ctas);
     }
-    const footer = createTag('div', { slot: 'footer' });
     footer.append(ctas);
-    merchCard.appendChild(footer);
   }
+  merchCard.appendChild(footer);
 
   if (MULTI_OFFER_CARDS.includes(cardType)) {
     if (merchCard.variant === MINI_COMPARE_CHART) {

diff --git a/libs/blocks/merch-card/merch-offer-select.js b/libs/blocks/merch-card/merch-offer-select.js
@@ -13,10 +13,11 @@ function createDynamicSlots(el, bodySlot) {
     createTag('span', { slot: 'price', is: 'inline-price' }, null, { parent: priceSlot });
     bodySlot.append(priceSlot);
   }
-  const p = createTag('p', { class: 'action-area', slot: 'footer' });
+  const p = createTag('p', { class: 'action-area' });
   createTag('a', { slot: 'secondary-cta', is: 'checkout-link' }, null, { parent: p });
   createTag('a', { slot: 'cta', is: 'checkout-link' }, null, { parent: p });
-  el.append(p);
+  const footer = el.querySelector('div[slot="footer"]');
+  footer.append(p);
   bodySlot.querySelector('p')?.setAttribute('slot', 'description');
   if (el.variant === MINI_COMPARE_CHART) {
     const description = el.querySelector('div[slot="body-m"] p:last-child');