[MWPW-131690] Update horizontal rule styles within text blocks #1088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elan-tbx
requested review from
auniverseaway,
rgclayton,
Blainegunn,
fullcolorcoder,
chrischrischris and
Sartxi
|
Hello, I'm Franklin Bot and I will run some test suites that validate the page speed.
|
|
Codecov Report
@@ Coverage Diff @@
## main #1088 +/- ##
==========================================
+ Coverage 95.90% 95.91% +0.01%
==========================================
Files 129 129
Lines 32226 32226
==========================================
+ Hits 30905 30909 +4
+ Misses 1321 1317 -4 see 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
chrischrischris
added
the
needs-verification
chrischrischris
approved these changes
Aug 7, 2023
mokimo
approved these changes
Aug 8, 2023
overmyheadandbody
approved these changes
Aug 8, 2023
There was a problem hiding this comment.
I agree with @chrischrischris, this should get come confirmation from stakeholders before being rolled out.
|
@chrischrischris @overmyheadandbody Will do, thanks y'all |
|
|
|
auniverseaway
added a commit
that referenced
this pull request
Aug 22, 2023
* MWPW-130142 (#725) Co-authored-by: Blaine Gunn <[email protected]> * Fix two failing tests and add a custom test reporter (#724) * Skip failing tests and use a custom reporter * Unskip and fix failing tests --------- Co-authored-by: Chris Millar <[email protected]> * Add support for Jarvis chat (#693) * Initial support for Jarvis * Add support for Jarvis chat * Jarvis tests * Jarvis support * first round of feedback * Remove custom config * Update libs/features/jarvis-chat.js Co-authored-by: Okan Sahin <[email protected]> * feedback round 3 * implement feedback --------- Co-authored-by: Okan Sahin <[email protected]> * MWPW-131381 Move flags to sharepoint (#737) * MWPW-129907 - Blog Migration (#741) Fixed taxonomy categry default. Resolves: MWPW-129907 Co-authored-by: Ryan Clayton <[email protected]> Co-authored-by: Okan Sahin <[email protected]> * MWPW-131263: preview call update for promote * MWPW-131015: Fix spectrum and layout issues (#721) * MWPW-131015: Fix spectrum style issues and improve the layout. * MWPW-131015: Restore OST urls * MWPW-131015: Restore merch.js * MWPW-131015: fix price style in OST * Update OST version * Add token parameter support to bypass IMS wait for IMS ready in order to prevent sign-in attempt too early. * comment token section. * remove gnav hiding logic via css and use metadata for the purpose. --------- Co-authored-by: Honwai Wong <[email protected]> * Address TODOs (#736) Co-authored-by: Honwai Wong <[email protected]> * Ensure the global navigation is displayed on top of page content (#734) Co-authored-by: Honwai Wong <[email protected]> * [MWPW-128693] Updating FG admin page to call AIO actions (#739) * Updating actions to trigger aio services from fg admin console * Adding status buttons for fg and promote actions. * Updating floodgate UI status table with AIO status fetch calls * Moving reused functions to fg utils js * Renaming functions - all AIO calls are named as actions * Adding description/message column to project status table. * Reverting unused constants and imports. Fixing fgRoot path for promote actions --------- Co-authored-by: Sekhar <[email protected]> * MWPW-126707: Global navigation lana logs (#743) * MWPW-126707: Global navigation lana logs * Address feedback --------- Co-authored-by: Honwai Wong <[email protected]> * MWPW-130474: remove placeholder syntax from price links (#751) * MWPW-130474: remove placeholder syntax from price links * MWPW-130474: added required css file * unit test fix * Update CODEOWNERS * Update CODEOWNERS --------- Co-authored-by: Axel Cureno Basurto <[email protected]> Co-authored-by: Honwai Wong <[email protected]> * Serve non-critical features from delayed (#744) * Initial support for Jarvis * Add support for Jarvis chat * Jarvis tests * Jarvis support * first round of feedback * Remove custom config * Update libs/features/jarvis-chat.js Co-authored-by: Okan Sahin <[email protected]> * feedback round 3 * implement feedback * Serve non-critical features from delayed * import and execute delayed * implement feedback --------- Co-authored-by: Okan Sahin <[email protected]> Co-authored-by: Honwai Wong <[email protected]> * minor: Preflight UX (#758) Preflight UX Co-authored-by: Honwai Wong <[email protected]> * Provide default id for privacy (#764) * FEDS Gnav critical bug squashing (#745) Co-authored-by: Okan Sahin <[email protected]> * [MWPW-131242] Use dark color for hamburger button (#767) * MWPW-131666: update to absolute url (#768) Co-authored-by: Honwai Wong <[email protected]> * Use the default IMS scope if one is not provided by consumers (#766) * MWPW-129907 Blog Article Typography Corrections (#761) MWPW-129907 Blog Article Typogrpahy Corrections * Fixes typography getting cut off in Featured Article block * Fixes typography getting cut off in Article Card block Resolves: MWPW-129907 Co-authored-by: Ryan Clayton <[email protected]> * MWPW-129907 Blog Tags (#762) This fixes a bug where Blog tags were getting stripped down to the point they no longer matched what was listed in the related taxonomy file. Causing tags to not render on the page. Resolves: MWPW-129907 Co-authored-by: Ryan Clayton <[email protected]> * MWPW-131266: Update FG project details (#774) * MWPW-131664: increase merch resilience to errors (#765) * MWPW-131664: icrease merch resilience to errors * fix(#748): icrease merch resilience to errors * fix test --------- Co-authored-by: Chris Millar <[email protected]> Co-authored-by: Honwai Wong <[email protected]> * Let region nav to use prefix instead content root. (#770) * Let region nav to use prefix instead content root. * Removing the config.contentRoot for fallback case. * MWPW-124580 - Promote Publish Milo changes (#782) - Added Promote Publish Option - Passing this to Promote Action Co-authored-by: armohamm <[email protected]> * Highlight expanded navigation menu on mobile (#763) * Highlight expanded navigation menu on mobile * implement feedback * implement feedback --------- Co-authored-by: Honwai Wong <[email protected]> * [MWPW-131397] Unset min-height on Aside background image for notification variant (#757) unset min-height on bg image for notification variant Co-authored-by: Honwai Wong <[email protected]> * MWPW-131637: improve OST for small screens (#779) MWPW-131637: imporve OST for small screens Co-authored-by: Honwai Wong <[email protected]> * MWPW-125482 Overriding text flow direction via metatag (#777) * MWPW-128694 Removing duplicated projectRoot param and using rootFolder and fgRoot… (#781) Removing duplicated projectRoot param and using rootFolder and fgRootFolder for updating copy/promote status. Co-authored-by: Sekhar <[email protected]> * MWPW-131804 - PromoteAction call fix from MiloUI (#785) Co-authored-by: armohamm <[email protected]> * Remove contentRoot dependency to create locale path in georouting modal (#776) * MWPW-131669 stop georouting using contentRoot --------- Co-authored-by: Ruchika Sinha <[email protected]> Co-authored-by: Sean Choi <[email protected]> Co-authored-by: Victor Hargrave <[email protected]> * Remove all margins from search input (#791) Co-authored-by: Honwai Wong <[email protected]> * [MWPW-126504] offer preview in sidekick (#711) * offer preview in milo * review comments fixed --------- Co-authored-by: Axel Cureno Basurto <[email protected]> Co-authored-by: Honwai Wong <[email protected]> * Text block style conflicts with other blocks (#797) * moved media *-up image btm margin to tablet-up media query * name collision issue: scoped .dark .text -> .dark .text-block --------- Co-authored-by: thi64146 <[email protected]> * Improve navigation support when modals are displayed (#793) Improve accessibility Co-authored-by: Honwai Wong <[email protected]> * Set proper styles for top navigation menus (#792) * Set proper styles for top navigation menus * implement feedback --------- Co-authored-by: Honwai Wong <[email protected]> * [MWPW-131852] Remove footer highlight when element is collapsed on mobile (#789) Co-authored-by: Honwai Wong <[email protected]> * Add divider-inherit css to support different color divider (#787) update divider-inherit css to support different color divider Co-authored-by: xiasun <[email protected]> Co-authored-by: Honwai Wong <[email protected]> * MWPW-125675 - [Core] Milo Bulk Publish (#799) - support a request parameter to set the max number of URL entries Co-authored-by: Honwai Wong <[email protected]> * Publish Promote Visibility (#807) Co-authored-by: armohamm <[email protected]> * Updating LastRun status column from AIO action calls instead of reading from Project Excel file (#809) Co-authored-by: Sekhar <[email protected]> * Unit tests - surface external requests (#803) * Unit tests - surface external requests * More specific warnings * Use single quotes --------- Co-authored-by: Honwai Wong <[email protected]> * MWPW-125675 - [Core] Milo Bulk Publish (#806) - fix: max = 0 when the request has no limit param Co-authored-by: Honwai Wong <[email protected]> * MWPW-131201-Georouting text direction (#798) * MWPW-131201-georoutng text direction * MWPW-131201-georoutng text direction * Update georoutingv2.js * add text direction to region picker --------- Co-authored-by: Ruchika Sinha <[email protected]> Co-authored-by: Elaine Borges <[email protected]> Co-authored-by: Honwai Wong <[email protected]> * Surface unit test errors and point to a solution source (#815) * Log loading external scripts * Log loading external scripts * Update CODEOWNERS (#817) * MWPW-129575 - Authorable Tooltip (#775) * MWPW-129575 - Authorable Tooltip * Ability to spec tooltip + position + text * Uses <em>:tooltip: | {position} | {text}</em> convention. Resolves: MWPW-129575 * MWPW-129575 fix for safari & z-index (#826) Co-authored-by: Blaine Gunn <[email protected]> --------- Co-authored-by: Honwai Wong <[email protected]> Co-authored-by: Blaine Gunn <[email protected]> Co-authored-by: Blaine Gunn <[email protected]> * Update label email groups (#827) * MWPW-132152 - Gist block (#829) * Add gists to your page * Bulk preview/publish: increase throttling (#828) * Remove `overflow: visible` from img to avoid undesired behaviour (#822) Remove `overflow: visible` from img to avoid undesired behavior Co-authored-by: Honwai Wong <[email protected]> * MWPW-131063-Fix for bold link not transformed to button (#812) * MWPW-131063-links that are bold should be transformed to button (sometimes word generates <a/> inside <strong/> and sometimes <strong/> inside <a/>, so this will cover both cases. * MWPW-131063-create object outside the loop and fix (when structure is strong a, do not remove child because in that case child is anchor element) MWPW-131063-create object outside the loop --------- Co-authored-by: Elaine Borges <[email protected]> Co-authored-by: Honwai Wong <[email protected]> * MWPW-132176 .html send to caas toggle (#834) * MWPW-132176 revert entityid change (#835) * Update icons.js * Update icons.svg * MWPW-132076-fix css issues with georouting in rtl (#820) * fix css issues with georouting in rtl --------- Co-authored-by: Ruchika Sinha <[email protected]> Co-authored-by: Ruchika Sinha <[email protected]> Co-authored-by: Elaine Borges <[email protected]> * MWPW-129911 - Text block implementation - Legal Block and Link Farm (#778) * Implementation of Legal copy block * Link Farm Implementation * Implementing only using css * optimizing css * Renaming legal block * Mobile First Approach * changes as per review comments * Implementation of Legal copy block * Link Farm Implementation * Implementing only using css * optimizing css * Renaming legal block * Mobile First Approach * changes as per review comments * Changes as per review comments * changes as per review comments * Changes as per review comments -3 --------- Co-authored-by: Drashti Modasara <[email protected]> Co-authored-by: Nishant Thakur <[email protected]> * MWPW-129094 Iframe Block Classes and Height Issue (#753) * Allows for iframe block to pass classes to rendered counterpart. Adds a class for issue * Cr change, more specific class name --------- Co-authored-by: Honwai Wong <[email protected]> * MWPW-132092, MWPW-132094, MWPW-132096 - RTL gnav footer and region-nav fix (#842) * MWPW-132092 MWPW-132094 MWPW-132096 * MWPW-132092 MWPW-132094 MWPW-132096 * MWPW-129909-inline variation of icon block (#790) * MWPW-129909-inline variation of icon block * MWPW-129909-renamed variation to inline, added padding for action area, unit test * MWPW-129909-eslint fixs * MWPW-129909-fix for 3up section for bio variation (text overflow) --------- Co-authored-by: Elaine Borges <[email protected]> Co-authored-by: Honwai Wong <[email protected]> * MWPW-125482 Fixing line length and function defined before used eslint issue (#784) * Fixing linting issue * Fixing eslint issue * Update utils.js * Fixing line length lint issue * Fixing line length lint issue --------- Co-authored-by: Saloni Jain <[email protected]> * Testing use of GITHUB_TOKEN * Update email release to use pull_request_target (#848) * Add aria label to profile thumbnail (#846) * Add aria label to profile thumbnail * Implement feedback * Add bulk publish to supported blocks * [FEDS] Address remaining issues for MVP release (#823) * MWPW-130725 Marketo Configurator (#801) * Update library-config.js * Configure Jarvis chat for mobile / desktop (#813) * Configure Jarvis chat for mobile / desktop * MWPW-131063-Fix for bold link not transformed to button (#812) * MWPW-131063-links that are bold should be transformed to button (sometimes word generates <a/> inside <strong/> and sometimes <strong/> inside <a/>, so this will cover both cases. * MWPW-131063-create object outside the loop and fix (when structure is strong a, do not remove child because in that case child is anchor element) MWPW-131063-create object outside the loop --------- Co-authored-by: Elaine Borges <[email protected]> Co-authored-by: Honwai Wong <[email protected]> * MWPW-132176 .html send to caas toggle (#834) * MWPW-132176 revert entityid change (#835) * Update icons.js * Update icons.svg * test for Jarvis --------- Co-authored-by: Honwai Wong <[email protected]> Co-authored-by: Sonja Popović <[email protected]> Co-authored-by: Elaine Borges <[email protected]> Co-authored-by: Chris Peyer <[email protected]> Co-authored-by: Chris Millar <[email protected]> * Remove for..of, await in loop eslint warnings (#854) * Also support cardDescription in caas metadata (#856) * Update caas to support cardTitle too (#857) * [MWPW-132468] Legal Block Content Not rendered in italics - Bug Fix (#853) Co-authored-by: Drashti Modasara <[email protected]> * MWPW-132559 Disable sidekick send-to-caas (#859) * Fix lang attribute and accented character issue for text on georouting modal (#850) * MWPW-132114-fix lang * MWPW-131213-fix for accented characters in Chinese fonts --------- Co-authored-by: Elaine Borges <[email protected]> * [MWPW-132406] Long text links are not seen getting wrapped in Linkfarm (#858) MWPW-132406-Long Links wrapping bug fix Co-authored-by: Drashti Modasara <[email protected]> * MWPW-130971 - Centralized 404 (#845) * Central 404 * Maintains legacy compatibility * Defaults to local 404 using 404 - local meta property * Allows for federated 404 content via libs (using 404 - feds) * Ability to have any design * Adding unit test and adding export to 404 init * Making milo 404 to point to default * removing commented line * Increasing test code coverage * Adding sampleRUM in init --------- Co-authored-by: mathuria <[email protected]> * MWPW-132078: hide ctas by id (feature parity with caas on dexter) (#819) * MWPW-132078: hide ctas by id (feature parity with caas on dexter) * comment changes --------- Co-authored-by: Sheridan Sunier <[email protected]> Co-authored-by: Honwai Wong <[email protected]> Co-authored-by: Sheridan Sunier <[email protected]> * [MWPW-132198] Make S/M marquee media, buttons match Consonant designs at mobile breakpoint (#861) adjust width of base marquee media, fix button width at mobile bp Co-authored-by: Elaine Borges <[email protected]> * Global footer keyboard navigation (#832) * Keyboard navigation for the profile * Keyboard navigation - global footer * Footer keyboard navigation unit tests * Add PR feedback * Implement feedback & refactor popup to work regardless of load time / clicking / using keyboard nav --------- Co-authored-by: Honwai Wong <[email protected]> * MWPW-123036 [Milo] Custom filter panel options (#810) * MWPW-131421 - Marketo Form Style Changes (#867) * Small style changes to match designs. Setting label opacity. Adding checkbox width. * Removing margin and adding label * focus indicator --------- Co-authored-by: Brandon Marshall <[email protected]> * MWPW-129907 [Blog Migration] Allow Custom Article Feed (#855) * MWPW-129907 Allow Custom Article Feed * Updated to allow custom path for article feed. Resolves: MWPW-129907 * Fixes contextual search. Fixes breaking tests. * Updating config based on PR feedback * fixing article-header unit tests --------- Co-authored-by: Ryan Clayton <[email protected]> * [MWPW-118520] Menuless gnav (#860) Co-authored-by: Elaine Borges <[email protected]> * MWPW-127984: Make OST locale- and metadata-aware (#771) Pass tacocat config to OST * MWPW-128375: Ignore list for FG (#875) - Sends the list of paths to ignore to AIO action * MWPW-131815 - Override text alignment in icon blocks on rtl pages (#811) * MWPW-131815 --------- Co-authored-by: Ratko Zagorac <[email protected]> Co-authored-by: Blaine Gunn <[email protected]> * Mwpw 132409 - Optional Headings for Link Farms (#866) * MWPW-132409-Optional Headings use case * Review changes * Changes as per review comments * Unit Tests * MWPW-132409-Optional Headings use case * Review changes * Changes as per review comments * Unit Tests * changed from id to class * combining slectors in test file --------- Co-authored-by: Drashti Modasara <[email protected]> * feat(MWPW-131276):custom cta-labels (#808) feat(MWPW-131276):custom cta-labels * MWPW-131645 Linking images in milo via alt text (#780) * added decorateImageLinks to utils and invoked * no need to check img type * move init to defered * added test coverage and unified func param ref * PR feedback on decorateImageLink func, added tests and own dir * Trim image link source and alt text. Check for alt.length * remove unnecessary check for length value * PR feedback * handling TypeErrors in URL constructor, try catch --------- Co-authored-by: thi64146 <[email protected]> Co-authored-by: Honwai Wong <[email protected]> * Marquee block design updates and ESLint issues resolved (#869) * fixed marquee class .centered->.center, fixed linting errors and logic for marquee.js.css * marquee.quiet default max-width 600 * Moved split one-third logic into desktop query from 900. * merge conflict * fixed diff * Fixed marquee.dark default to be unset * revert last change * added missing .has-bg.no-spacing token style * Fixed the small variant type size and adjusted the .center tab up margin --------- Co-authored-by: thi64146 <[email protected]> * MWPW-129654: Add 'needs-verification' to PR label check (#884) Add 'needs-verification' to PR label check * MWPW-132977: Support global navigation link group modifier 'blue' (#877) MWPW-132977: Support link group modifier 'blue' Co-authored-by: Honwai Wong <[email protected]> * Fix flaky utils twitter unit test (#892) * Fix flaky utils twitter test * Add EOF for head.html * Do not accidently select tests for RUM collection * Remove weird indentation --------- Co-authored-by: Honwai Wong <[email protected]> * MWPW-131109: Faas safari issues (#888) * Font color issue, need to push up to test locally on ipads * Adding webkit appearance to ensure iOS and safari do not style buttons * Adding -webkit-appearance none for submit items as well --------- Co-authored-by: Honwai Wong <[email protected]> * MWPW-129660 Override Marketo Form Params (#870) * MWPW-133063-Fix for tabs in a fragment not loading on a page (#897) * MWPW-133063 Fix for tabs in a fragment not loading on a page --------- Co-authored-by: Sunil Kamat <[email protected]> Co-authored-by: Ruchika Sinha <[email protected]> * Update pdf embed API url (#883) * Update pdf-viewer.js * Update pdf viewer domain * Update pdf viewer domain in mock file --------- Co-authored-by: Elaine Borges <[email protected]> Co-authored-by: Honwai Wong <[email protected]> * Personalization (#874) Co-authored-by: Chris Peyer <[email protected]> Co-authored-by: vivgoodrich <[email protected]> Co-authored-by: Honwai Wong <[email protected]> * Call OnReady for gnav if IMS is already there (#906) * MWPW-127384 Ability to anchor/focus background image at certain point… (#673) * MWPW-127384 Ability to anchor/focus background image at certain point in section-metadata component * MWPW-127384 test case changes * MWPW-127384 test cases changes * MWPW-127384 test case changes * MWPW-127384 changes * MWPW-127384 addind both x,y axis capability for object-position property * authoring changes:directly authoring the focal points under the background image for section-metadata and marquee * changes * changes * adding the focal directly to marquee instead of importing it * minor changes * focalpoint func changes * changes * changes for focalpoint function * removed slice function from directions * Update libs/blocks/marquee/marquee.js Co-authored-by: Ryan Parrish <[email protected]> * removing focal point element from DOM for marquee and small linting issues * replacing Array.from with spread operator --------- Co-authored-by: Ryan Parrish <[email protected]> Co-authored-by: Chris Millar <[email protected]> * Personalization martech fix: also check for window._satellite presence (#909) * MWPW-131607: Extend feds.entitlements with the offer ID (#904) * extended the entitlements object with the offers field * changed emptyEntitlements from object to function * Fix global navigation tests (#911) * Fix broken scripts test (#910) Co-authored-by: Okan Sahin <[email protected]> * [MWPW-132444] Save up nav space when content is overflowing (#893) * Skip personalization test for now (#920) * Fix personalization tests * Skip personalization test for now * MWPW-133443: Fetch gnav placeholders from correct location (#919) MWPW-133433: Fetch gnav placeholders from correct location Co-authored-by: Honwai Wong <[email protected]> * [MWPW-132443] Gnav updates for Blog migration (#882) * [MWPW-132443] Gnav updates for Blog migration * [MWPW-132443] Add Gnav unit test for experience name * [MWPW-132443] Add additional entitlements UT --------- Co-authored-by: Honwai Wong <[email protected]> * MWPW-133441: Merch: custom elements deps for Safari (#921) * MWPW-133441: Merch: custom elements deps for Safari * Use locale from getConfig (gnav) (#916) Personalization: Get locale from getConfig Co-authored-by: Honwai Wong <[email protected]> * [MWPW-132443] Visible brand label if no image exists (#926) * MWPW-133465: Localise gnav mega menus (#924) MWPW-133465: Localise mega menus * MWPW-131420 Fixing Configurator copy button (#908) Co-authored-by: Honwai Wong <[email protected]> * marquee-anchors - new block (#899) * Some code refactor suggestions for nav-marquee * dynamic svg icons * sharepoint svg icon * simplified the link target logic. #label denotes a list link * renamed to marquee-anchors * added transparent and refactored some names * support dark transparent * added tests and fixed scope or url sans param * added block to util list * better comments, removed bad ones. Logic for conditional icons based on hrefUrl type, margin defaults on .transparent variant * Fixed tests * fixed 404 on tests baseUrl logic * indent space * append namespace to list header ids to prevent dups, refined comparison logic from PR feedback * refactored the link icon so it uses a `link-external' svg on non anchor link list items. --------- Co-authored-by: thi64146 <[email protected]> Co-authored-by: Elaine Borges <[email protected]> * MWPW-126504 offer selector preview (#902) MWPW-126504. Offer selector preview. * [MWPW-131409] Update .html postfix (#927) * MWPW-133653 Extra checks for decorateHTML (#932) * Update variables.css * MWPW-131648-fix flag missing issue in georouting for umbrella regions (#889) * MWPW-131648-fix flag issue for umbrella regions --------- Co-authored-by: Sunil Kamat <[email protected]> Co-authored-by: Honwai Wong <[email protected]> Co-authored-by: Ruchika Sinha <[email protected]> * MWPW-117620: Automated breadcrumbs (#887) * MWPW-117620: Automated breadcrumbs * Do not automatically create breadcrumbs from URLs * Add PR feedback * Address PR feedback * Address feedback * Target Personalization: Correctly pass in utils (#934) * [MWPW-132503] Honor heading tag level as authored on Accordion block titles (#905) * handling h tags in accordion headers properly * clean up dt creation, don’t set aria attrs if htag is present * update tests --------- Co-authored-by: Sunil Kamat <[email protected]> Co-authored-by: Honwai Wong <[email protected]> Co-authored-by: Elaine Borges <[email protected]> * Do not show current breadcrumb page by default (#936) * Do not show current breadcrumb page by default * Fix tests * Fix test * Ensure multiple places can load IMS from the milo utils (#933) * Ensure IMS is correctly initialized * Do not initialize gnav ims callback too early * Offer promised based IMS loading * Remove unused test property * Remove unwritten tests * Add IMS lana log for the global navigation * Raise timeout to 5000 * MWPW-132987 Adjusting Modal Fragment Widths (#903) * Adding a max-width for modal fragments to override changes to width that was done for 404s * Adjustments to selector --------- Co-authored-by: Sunil Kamat <[email protected]> Co-authored-by: Honwai Wong <[email protected]> Co-authored-by: Elaine Borges <[email protected]> * Use only language subtag for html lang attribute (#915) * Add lang, reg to locales; Use lang for html lang attribute * Chore: Sort locales entries (#938) Sort locales entries * Refactor debounce from utils (#930) * MWPW-133591 refactor debounce from utils * MWPW-125937 Tag Selector (#896) Co-authored-by: Sunil Kamat <[email protected]> Co-authored-by: Elaine Borges <[email protected]> Co-authored-by: Honwai Wong <[email protected]> * MWPW-132150 - Strikethrough prices text style fix (#931) Co-authored-by: Axel Cureno Basurto <[email protected]> * [MWPW-133469]Interlink fix for languages that don't have word boundary (#939) * Fix interlink for languages that don't have word boundary * Update delayed.js * incorporate review comments * incorporate review comments * incorporate review comments and move the old unit tests from block to feature folder * adding fix for issue identified for th during testing * incorporate review comments --------- Co-authored-by: Ruchika Sinha <[email protected]> Co-authored-by: Aaron Mauchley <[email protected]> * [MWPW-132408] Fix for Geo Routing modal dropdown view is not as expected in mobile landscape mode. (#918) * Table block (#849) * MWPW-129568 : Table Block (#640) MWPW-129568 Table Block Co-authored-by: Blaine Gunn <[email protected]> * Mwpw 129568 (#642) * MWPW-129568 Table Block * MWPW-129568 basics --------- Co-authored-by: Blaine Gunn <[email protected]> * For heading and highlight color / bg color. (#643) * For heading and highlight color / bg color. * Reducing condition for checking !table. * Table sticky (#671) * Ryan P's suggestion. * Style updates. * Revert "Style updates." This reverts commit 873900f8cd2a5975787be0e4d735ef5f504ba0cb. * Table block (#769) * standard table svgs * standard table - iteration 1 * standard table and merch table - iteration 2 * uncomment css for sticky header --------- Co-authored-by: Dragana Trajkovic <[email protected]> * filter for mobile. * Fixing some bugs * in case of both filter points same. * nit: remove console.log * Table block (#796) * standard table svgs * standard table - iteration 1 * standard table and merch table - iteration 2 * uncomment css for sticky header * add 'collapse' and 'highlight' as optiona for the table --------- Co-authored-by: Dragana Trajkovic <[email protected]> Co-authored-by: Sean Choi <[email protected]> * polish works. * Clean-ups and bug fixes. * hovering event fix. * Fixed scroll event issue. * Fixed bug for mobile UX * Table block (#816) * standard table svgs * standard table - iteration 1 * standard table and merch table - iteration 2 * uncomment css for sticky header * add 'collapse' and 'highlight' as optiona for the table * hover when the last row is collapsed --------- Co-authored-by: Dragana Trajkovic <[email protected]> Co-authored-by: Sean Choi <[email protected]> * bug fixes. * merch mobile css update. * Bug fix on filters for merch. * Table block (#825) * standard table svgs * standard table - iteration 1 * standard table and merch table - iteration 2 * uncomment css for sticky header * add 'collapse' and 'highlight' as optiona for the table * hover when the last row is collapsed * fixed bug with rounded heading cols --------- Co-authored-by: Dragana Trajkovic <[email protected]> Co-authored-by: Sean Choi <[email protected]> * writing test. * Fixing bug for lastExpandIcon is being null case. * eslint fixes. * Table block (#836) * standard table svgs * standard table - iteration 1 * standard table and merch table - iteration 2 * uncomment css for sticky header * add 'collapse' and 'highlight' as optiona for the table * hover when the last row is collapsed * fixed bug with rounded heading cols * merch table fixed styles * removed repeated css line * fixed responsive css --------- Co-authored-by: Dragana Trajkovic <[email protected]> Co-authored-by: Sean Choi <[email protected]> * mid commit for testing * 100% test coverage for table. * table merch tablet. * bug fix on order change when first one don't have the highlight. * Fixed the style bug on filter change. * Resolving the conflicts on icons. * Removing the empty row remove logic. * Remove empty row from test mock body. * Removing the unnecessary pixel. * Table block (#852) * standard table svgs * standard table - iteration 1 * standard table and merch table - iteration 2 * uncomment css for sticky header * add 'collapse' and 'highlight' as optiona for the table * hover when the last row is collapsed * fixed bug with rounded heading cols * merch table fixed styles * removed repeated css line * fixed responsive css * sticky header is optional --------- Co-authored-by: Dragana Trajkovic <[email protected]> Co-authored-by: Sean Choi <[email protected]> * Applying code review from Chris P. * Updated test body.html to test sticky option. * Bug fix for the case of first heading exists on standard table. * Table block (#864) * standard table svgs * standard table - iteration 1 * standard table and merch table - iteration 2 * uncomment css for sticky header * add 'collapse' and 'highlight' as optiona for the table * hover when the last row is collapsed * fixed bug with rounded heading cols * merch table fixed styles * removed repeated css line * fixed responsive css * sticky header is optional * fixed info-icon hover * table - readme * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md --------- Co-authored-by: Dragana Trajkovic <[email protected]> Co-authored-by: Sean Choi <[email protected]> * Putting the table block in the lib list. * Fixing bug on metadata in case of there are multiple tables. Improved logic to save CPU on resizing. * Update the filter icon. * Table block - fixed top-borders on hovering columns (#868) * standard table svgs * standard table - iteration 1 * standard table and merch table - iteration 2 * uncomment css for sticky header * add 'collapse' and 'highlight' as optiona for the table * hover when the last row is collapsed * fixed bug with rounded heading cols * merch table fixed styles * removed repeated css line * fixed responsive css * sticky header is optional * fixed info-icon hover * table - readme * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * border is visible on hover for desktop * code fix --------- Co-authored-by: Dragana Trajkovic <[email protected]> Co-authored-by: Sean Choi <[email protected]> * Filters always right above the table. * Added role: table, row, cell * More Accessibility. * Test update * Apply Megan's review. * More review apply and improved expand interaction. * Better UX for hover CSS and test update for expend. * Table block (#952) * standard table svgs * standard table - iteration 1 * standard table and merch table - iteration 2 * uncomment css for sticky header * add 'collapse' and 'highlight' as optiona for the table * hover when the last row is collapsed * fixed bug with rounded heading cols * merch table fixed styles * removed repeated css line * fixed responsive css * sticky header is optional * fixed info-icon hover * table - readme * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * border is visible on hover for desktop * code fix * code fix based on megan's comments * code fix based on megan's comments - loop over 'rows' in init * code fix based on megan's comments - matchingCols is not an array * code fix based on megan's comments - matchingCols is not an array; removed important from styles --------- Co-authored-by: Dragana Trajkovic <[email protected]> Co-authored-by: Sean Choi <[email protected]> * Test update according to the PR review. * Fixed a bug from the refactoring (#952) and some cleanups. --------- Co-authored-by: Blaine Gunn <[email protected]> Co-authored-by: Blaine Gunn <[email protected]> Co-authored-by: Vivian A Goodrich <[email protected]> Co-authored-by: draganatrajkovic <[email protected]> Co-authored-by: Dragana Trajkovic <[email protected]> Co-authored-by: Honwai Wong <[email protected]> * Use locale from getConfig (caas) (#945) * [MWPW-133763] Long breadcrumbs UI (#940) * Reverse the package.json (#957) * Add title-append feature (#955) * Add title-append feature * Do not block on import * MWPW-133942 Consumer can change martech urls (#956) * MWPW-133942 Consumer can change martech urls --------- Co-authored-by: Blaine Gunn <[email protected]> * MWPW-133297 Reduce Marketo Form TBT (#948) * MWPW-129914 Rich Media Accordion (Editorial Carousel) (#942) * MWPW-129914 Rich Media Accordion (Editorial Carousel) --------- Co-authored-by: Blaine Gunn <[email protected]> * MWPW-133412 Pass correct country/lang to filters (#935) * Minor Bug fix for Table block (#960) * Fixed some style bugs. * nit: adding null escape. * rowheader role * Border style bug fix. * More border style fixes. * Don't run UT or label checks if you edit PR title/body (#967) * Don't run unit tests if you edit PR title/body * Don't check labels again either * Use "content-language" metadata for html lang attribute (#963) Check "content-language" for html lang attribute Co-authored-by: Megan Thomas <[email protected]> * Update CONTRIBUTING.md (#970) * Update CONTRIBUTING.md * Quick changes * WPW-132896 image margin rtl issue (#951) * MWPW-133942 martech devUrl update (#989) Co-authored-by: Blaine Gunn <[email protected]> * Autofix subset of eslint errors (#987) * MWPW-130073 - [Library] Add block patterns/grouping to the block library (#772) * MWPW-130073 - [Library] Add block patterns/grouping to the block library - adds support for containers to the block library * MWPW-130073 - [Library] Add block patterns/grouping to the block library - adds tests for the container capability * MWPW-130073 - [Library] Add block patterns/grouping to the block library - adds tests for: chart, marquee and text blocks * MWPW-130073 - [Library] Add block patterns/grouping to the block library - the container name can be configured in the library metadata * MWPW-130073 - [Library] Add block patterns/grouping to the block library - fixes the handling of links in container * MWPW-130073 - [Library] Add block patterns/grouping to the block library - fixes the handling of links in container * MWPW-130073 - [Library] Add block patterns/grouping to the block library - fixes the failing test: adapt it to the new handling of links - introduces blocks for the library container start and end markers to improve authoring of the library pages - code refactoring: introduces constants * MWPW-130073 - [Library] Add block patterns/grouping to the block library - fixes the 404s in the test (due to the missing media_ files) * MWPW-130073 - [Library] Add block patterns/grouping to the block library - improves the logic code - use mocked resources in the tests - address feedback from the PR review * MWPW-130073 - [Library] Add block patterns/grouping to the block library - support searching by the container title - add tests for this use case * MWPW-130073 - [Library] Add block patterns/grouping to the block library - remove support for defining a container title in the container metadata * MWPW-130073 - [Library] Add block patterns/grouping to the block library - fix logic for block name defined as a title before the block --------- Co-authored-by: Honwai Wong <[email protected]> * Soft revert of lang/reg #915 (#965) Co-authored-by: Sunil Kamat <[email protected]> Co-authored-by: Chris Peyer <[email protected]> * [Blog Migration] Topics URL 404s on lang pages (#985) * [MWPW-133763] Breadcrumbs mobile alignment (#995) * Make sure to always display the breadcrumbs when a base is set (#990) * Make sure to always display the breadcrumbs when a base is set * Move undefined check * MWPW-131707 Get correct region for caas autolang (#991) * Add tracking attributes to links in card block (#1003) Co-authored-by: Ruchika Sinha <[email protected]> * Add run-lint workflow (#988) * [MWPW-128449] Extract fragments from the docs and add it to the floodgate project (#1001) * extract fragments * trial * fixing eslint errors * extra space --------- Co-authored-by: nsivakum <[email protected]> Co-authored-by: Sunil Kamat <[email protected]> * MWPW-134209 Enable excel format localization (#1002) Co-authored-by: Okan Sahin <[email protected]> * Run code checks on PR against any branch (#968) Co-authored-by: Sunil Kamat <[email protected]> Co-authored-by: Chris Peyer <[email protected]> * MWPW-130838 OST version rump up (#998) Co-authored-by: Volodymyr Kniaziev <[email protected]> Co-authored-by: Chris Peyer <[email protected]> * MWPW-125174: Adds functionality so that authors can chose what is displayed in the eyebrow section (#961) Co-authored-by: Sunil Kamat <[email protected]> * MWPW-124986 - [Caas] Adding Floodgate Color & ContentId in SendToCaas individual & Bulk Publish based on Metadata (#914) Co-authored-by: armohamm <[email protected]> Co-authored-by: Sunil Kamat <[email protected]> Co-authored-by: Elaine Borges <[email protected]> * MWPW-131134 - Marquee: media-credit container text disappears if italicized (#843) * MWPW-131134 - Marquee: media-credit container text disappears if italicized * feat(marquee): optimization on media credit action * feat(marquee): conditional rewrite * Disable failing media credit test until it can be fixed (#1006) * Fix flakey title-append test (#1005) Co-authored-by: Chris Peyer <[email protected]> * [MWPW-133865] Update default font color in dark section variants (#1007) * How-to block design enhancement (#879) Co-authored-by: thi64146 <[email protected]> Co-authored-by: Honwai Wong <[email protected]> * Improve linting: only warn on cycles, ignore console in tests (#1009) Improve eslint use * feat(marquee): unit test fix (#1011) * Mwpw 134073 table alignment fixed in mobile windows. (#1004) * table and icon row alignment fixed * Update table.css * changed generic selector to specific * Update table.css * mwpw-134299 - localize global navigation logo links (#1015) * mwpw-134299 - localize logo links * Remove currently unused code * Add lana log incase a dropdown sign in link is not found * Typo in feds-nav-wrapper markup (#1019) * MWPW-132559 Add .html support to caas (#1014) * Fix loadLana test (#1012) * MWPW-133232 Remove default Article tag (#1008) * MWPW-133028 | Making aside button action area a flex container (#1016) * Add tracking attributes in share block (#1023) * Bug: Fix bulk publisher (#1027) * Caas Bulk Publisher: Backward Compatibility Fix (#1028) * mwpw-134306: always show authored breadcrumbs-page-title (#1017) * mwpw-134306: always show authored breadcrumbs-page-title * Add unit test * [Global-navigation] Fix an undefined error (#1032) Fix an undefined error * MWPW-134309: Milo to always use Prod WCS (#1020) * MWPW-133181 marquee rtl issue. (#950) * MWPW-133181 * Update marquee.css * Add tracking for copy link to clipboard in share block (#1035) * Add unit test case for analytics * add tracking attribute * fix linting issue * add tracking to copy to clipboard * MWPW-132693: Icon block inline variant style fix (#881) * MWPW-132693: Added css and js fixes to inline variation of icon block --------- Co-authored-by: Ratko Zagorac <[email protected]> Co-authored-by: Sean Choi <[email protected]> Co-authored-by: Blaine Gunn <[email protected]> * MWPW-134424 | Center notification buttons are not center aligned (#1034) Aside center notification fix * Add analytics tracking to modal (#1030) Co-authored-by: Ruchika Sinha <[email protected]> * iframe window opened in mobile view is too small (#1031) * modal-iframe-size * commerce-frame selector added * debounce and conditional event listener * test cases added to test modals for mobile screen * linting errors * resize event is added only once * debounce changed * iframe commerce speacific changes * MWPW-133747 Tag Selector Safari Style (#1021) * MWPW-132883: Add RTL attribute for RTL region's langstore file (#954) * MWPW-132883: Add RTL attribute for RTL region's langstore file * MWPW-132883: using ietf to match the rtl language * fix line length * MWPW-133262: Adds localization functionality to custom filters (#912) * MWPW-133262: Adds localization functionality to custom filters * MWPW-133262: implements PR suggestions * Fixes lint errors --------- Co-authored-by: Honwai Wong <[email protected]> Co-authored-by: Elaine Borges <[email protected]> Co-authored-by: Chris Millar <[email protected]> * Mep preview (#999) Co-authored-by: Chris Peyer <[email protected]> Co-authored-by: vivgoodrich <[email protected]> Co-authored-by: ChrisChrisChris <[email protected]> * MWPW-134412 Fix sidekick send-to-caas (#1049) * [Global-navigation] Localise breadcrumb links (#1036) * Localise breadcrumb links * Happy linter, happy life * Remove null check * Personalization cleanup (#1063) * ES lint fixes for section metadata and actions files (#1064) * fixed format for code quality, no linting warn * few minor pr feedback. line seperator, parens, conditional chaning logic --------- Co-authored-by: thi64146 <[email protected]> * [MWPW-134624] Space out column sections in GNAV full-width dropdown (#1067) * MWPW-131747 - Support structured data API for Video SEO (#1065) * Add seotech-video feature * Rename table to columns-table to avoid conflicting table block's css. (#1070) * MWPW-134057 | Replace image links in place (#1018) * MWPW-134057 | Replace image links in place * MWPW-134057 | Replace image links in place * Adding unit tests * Fix path --------- Co-authored-by: Chris Peyer <[email protected]> Co-authored-by: Sunil Kamat <[email protected]> * ost tool overlaps with sidekick. (#1082) * ost_overlap issue * ost overlap clean up * MWPW-134664: Safeguard autoblocks (#1069) * MWPW-134664: Safeguard autoblocks * Slightly change log message * Only try/catch the rellevant code path * Move condition * [MWPW-134429] Marketo form privacy language width (#1068) Co-authored-by: Megan Thomas <[email protected]> Co-authored-by: Megan Thomas <[email protected]> * Fragment preview video support (#1073) * moved media *-up image btm margin to tablet-up media query * name collision issue: scoped .dark .text -> .dark .text-block * added conditional in utils autoblock logic to check for mp4 in fragment url * minor refactor * no need for classname return * Fixed error w/ frag/ el class, adjusted marquee DecorateVideo w/ use for autoBlock video instance. * linting * better comment * pr feedback, optimize if/else --------- Co-authored-by: thi64146 <[email protected]> * [MWPW-133904] Fixing duplicated icon issue and other table issues (#1025) * remove duplicate entry for OST for sidekick (#1089) * [Workflow] MWPW-134543 Dispatch DC workflow when main is changed (#1072) Dispatch DC workflow for pushes * Add gnav-source to gnav lana logs (#1091) * Add gnav-source to lana logs * Add href * Mep button on target only (#1066) * add mep button if only target is on, not pzn * just removing if clause instead * if back in and adding mep override to other if * add else if empty * move to personalization * move similar code to function --------- Co-authored-by: vivgoodrich <[email protected]> * Personalization Tests (#1095) * MWPW-129918: Masonry styles for section metadata (#1026) * update js * css * update testing mock * remove CSS updates --------- Co-authored-by: vivgoodrich <[email protected]> * MWPW-130312 Adding Consumer Tags to Tag Selector (#1074) * MWPW-130312 Adding Consumer Tags * Fix eslint * PR Changes * Relax global navigation sign profile dropdown in check (#1092) * Relax global navigation sign profile dropdown in check * Remove unneccesary TODO * add a second unit test to ensure only the end of the link is checked * [MWPW-134805] Remove borders when more sections are used (#1094) * Merch Table: Fixing the double border and border on cell's text. (#1096) * Added additional options for media block (#971) * MWPW-129919 - Added additional options for media block --------- Co-authored-by: Blaine Gunn <[email protected]> Co-authored-by: Ryan Parrish <[email protected]> * [MWPW-131690] Update horizontal rule styles within text blocks (#1088) * tweak style to hr element in text block * border style must be solid for accurate color * MWPW-134968 - [Blog2Milo] Broken links on Homepage (#1101) * MWPW-134968 - [Blog2Milo] Broken links on Homepage - introduce a configuration called 'lang-root' in the page metadata - append the lang-root config to the category links * MWPW-134968 - [Blog2Milo] Broken links on Homepage - removing the bulk performance test as it relies on the Helix Admin Service performance * MWPW-134968 - [Blog2Milo] Broken links on Homepage - address PR feedback - move the utility function to its own helpers.js below /libs/utils - rename utility function - error handling for new URL() * MWPW-133172 - Add Floodgate option in Caas Configurator and Pass floodgate param to Caas (#913) Co-authored-by: armohamm <[email protected]> Co-authored-by: Sunil Kamat <[email protected]> Co-authored-by: Honwai Wong <[email protected]> * [MWPW-134522] Anchor link icons change when hash present (#1097) * MWPW-134889 Icon block link style update (#1110) * update word wrap in action area and fix style lint errors * remove extra space * MWPW-129730 - Word wrap function (#727) Co-authored-by: Honwai Wong <[email protected]> Co-authored-by: Chris Millar <[email protected]> Co-authored-by: Chris Peyer <[email protected]> * Mwpw 132793 Icon and Quotes Blocks RTL Alignment Issue. (#959) Co-authored-by: Sunil Kamat <[email protected]> * MWPW-128325: authoring dialog changes for hiding ctas using tags (#1103) Co-authored-by: Sheridan Sunier <[email protected]> Co-authored-by: Sheridan Sunier <[email protected]> Co-authored-by: Sheridan Sunier <[email protected]> * Play video on hover (#1106) Co-authored-by: Ruchika Sinha <[email protected]> Co-authored-by: Elaine Borges <[email protected]> Co-authored-by: Sunil Kamat <[email protected]> * [MWPW-134861] Remove loading of App Launcher (#1113) * MWPW-131211 Personalization Entitlement Support (#1104) Co-authored-by: Sunil Kamat <[email protected]> * MWPW-133055 Sticky bottom section functionality enhancement (#1080) * Run dispatch workflow only for adobecom/milo (#1119) * MWPW-135191 Hide caas link that has a query param (#1114) * MWPW-134481 - Add section xxs spacing variant (#1116) * MWPW-131211 Clear entitlements from localStorage on logout (#1122) * MWPW-129917 - Milo Aside block enhancements (#979) MWPW-129917 - Milo Aside block enhancements 1. Product icon stack in large and medium split asides. Desktop mode will have 2 columns and mobile and tablet will have stack in a row. Author can add only icon, linked icon, icon with plain text or linked text. 2. Static links to inherit link color same as the text. Adding style option in section metadata to change plain link color and inherit the same color as text. 3. Option to set the aspect ratio of image/media for large and medium split asides. 4. Add an avatar icon for aside having contributor bio. Add a bio variation for aside that converts icon-area to avatar image. 5. Aside center variation. No side image or media. Large variation has icon and supplemental text, Medium variation has icon or supplemental text, Small variation does not have either icon or supplemental text. Icon max sizes differ as per the XD for screen sizes. 6. Support video in background and foreground for standard and split aside. 7. Add a 24px padding before supplemental text. 8. Spacing in Asides - For all aside (split and standard) the spacing is 40px between text and image, and 80px from margin. For split aside the image does not have any spacing from edge. --------- Co-authored-by: Chris Peyer <[email protected]> * MWPW-133733: add promo support to OST links (#1120) * MWPW-133733: add promo support to OST links * MWPW-133733: removed console.logs * MWPW-133733: removed console.logs * MWPW-133733: opens OST with right promotion code * MWPW-133733: OST: add test case for searchParams * Do not lana log IMS timeouts for the global nav (#1127) * Do not lana log IMS timeouts for the global nav * Always attempt to show the user sign in button, even on IMS timeouts * fix video loading issue in figure block (#1124) * mep-add-marker-data-fix (#1125) initial Co-authored-by: vivgoodrich <[email protected]> * MWPW-135276 Fix video selector (#1129) * add optional chaining operator to get hash value for hoverplay (#1130) * MWPW-133754 - Support structured data API for SEO (#1115) * interlinks in marquee anchor block fixed (#1132) Co-authored-by: Narcis Radu <[email protected]> * fix issue of video not loading in figure block (#1134) Co-authored-by: Ruchika Sinha <[email protected]> * Mwpw 135206 geo routing popup is displayed on top of the commerce iframe modal. (#1131) * geo routing pop up is displayed behind the iframe modal * added modal specificity to commerce dialog modal * geo routing popup overlaps commerce frame fixed with z-index * z-index changed to 103 --------- Co-authored-by: Narcis Radu <[email protected]> * MWPW-122652 Added a phone icon into Milo icons library (#1136) * MWPW-122652 Adding Device Phone spectrum icon * MWPW-122652 Adding Device Phone spectrum icon * MWPW-122652 Adding Device Phone spectrum icon * MWPW-122652 symbol id with hyphen --------- Co-authored-by: Puru <[email protected]> * MWPW-134677 Fix aside mobile spacing (#1135) * MWPW-129922 - Consonant Actions Blocks (#1118) * action item and action scroller blocks/tests * update scroller css default gap * fix selector in action scroller test * remove unneeded moz vendor prefixes * remove img size attrs and simplify border property action scroller * simplify link decorating attrs * use array spread instead of from * min height for float icon * handle different image types for float icon * remove unneeded text selector * simplify float variant checks * fix tests and final cleanup * MWPW-135413 Support multiple link features (#1142) --------- Co-authored-by: Blaine Gunn <[email protected]> Co-authored-by: Blaine Gunn <[email protected]> Co-authored-by: Okan Sahin <[email protected]> Co-authored-by: Narcis Radu <[email protected]> Co-authored-by: Chris Peyer <[email protected]> Co-authored-by: Ryan Clayton <[email protected]> Co-authored-by: Ryan Clayton <[email protected]> Co-authored-by: Sunil Kamat <[email protected]> Co-authored-by: ilyas Stéphane Türkben <[email protected]> Co-authored-by: Honwai Wong <[email protected]> Co-authored-by: Sekhar Sirivuri <[email protected]> Co-authored-by: Sekhar <[email protected]> Co-authored-by: Axel Cureno <[email protected]> Co-authored-by: Axel Cureno Basurto <[email protected]> Co-authored-by: Rares Munteanu <[email protected]> Co-authored-by: Mariia Lukianets <[email protected]> Co-authored-by: Sunil Kamat <[email protected]> Co-authored-by: Sean Choi <[email protected]> Co-authored-by: Arshad Mohammed <[email protected]> Co-authored-by: armohamm <[email protected]> Co-authored-by: Elan Bartholomew <[email protected]> Co-authored-by: Aishwarya Mathuria <[email protected]> Co-authored-by: Ruchika Sinha <[email protected]> Co-authored-by: Ruchika Sinha <[email protected]> Co-authored-by: Victor Hargrave <[email protected]> Co-authored-by: Ryan Parrish <[email protected]> Co-authored-by: thi64146 <[email protected]> Co-authored-by: Jacky Sun <[email protected]> Co-authored-by: xiasun <[email protected]> Co-authored-by: jckautzmann <[email protected]> Co-authored-by: Elaine Borges <[email protected]> Co-authored-by: Sonja Popović <[email protected]> Co-authored-by: Ruchika Sinha <[email protected]> Co-authored-by: Drashti Modasara <[email protected]> Co-authored-by: Drashti Modasara <[email protected]> Co-authored-by: Nishant Thakur <[email protected]> Co-authored-by: Jason Slavin <[email protected]> Co-authored-by: Saloni Jain <[email protected]> Co-authored-by: Brandon Marshall <[email protected]> Co-authored-by: Sheridan Sunier <[email protected]> Co-authored-by: Sheridan Sunier <[email protected]> Co-authored-by: Sheridan Sunier <[email protected]> Co-authored-by: cmiqueo <[email protected]> Co-authored-by: Denis Vlassenko <[email protected]> Co-authored-by: Ratko Zagorac <[email protected]> Co-authored-by: Kniaziev Volodymyr <[email protected]> Co-authored-by: Hayley Parra <[email protected]> Co-authored-by: Chris Peyer <[email protected]> Co-authored-by: vivgoodrich <[email protected]> Co-authored-by: Suhani Jain <[email protected]> Co-authored-by: Mira Fedas <[email protected]> Co-authored-by: Megan Thomas <[email protected]> Co-authored-by: Victor Hargrave <[email protected]> Co-authored-by: Aaron Mauchley <[email protected]> Co-authored-by: Bandana Laishram <[email protected]> Co-authored-by: Vivian A Goodrich <[email protected]> Co-authored-by: draganatrajkovic <[email protected]> Co-authored-by: Dragana Trajkovic <[email protected]> Co-authored-by: sharath-kannan <[email protected]> Co-authored-by: NethraaS <[email protected]> Co-authored-by: nsivakum <[email protected]> Co-authored-by: Gen Watanabe <[email protected]> Co-authored-by: Volodymyr Kniaziev <[email protected]> Co-authored-by: William Ste-Marie <[email protected]> Co-authored-by: nishantka <[email protected]> Co-authored-by: Jason Slavin <[email protected]> Co-authored-by: Megan Thomas <[email protected]> Co-authored-by: James Tsay <[email protected]> Co-authored-by: saragajic11 <[email protected]> Co-authored-by: Sean Archibeque <[email protected]> Co-authored-by: Taketo Yoshida <[email protected]> Co-authored-by: Sheridan Sunier <[email protected]> Co-authored-by: Purushotham Doreswamachary <[email protected]> Co-authored-by: Puru <[email protected]>
narcis-radu
pushed a commit
to narcis-radu/milo
that referenced
this pull request
Sep 6, 2023
…com#1088) * tweak style to hr element in text block * border style must be solid for accurate color
vgoodric
pushed a commit
to vgoodric/bootcamp-milo
that referenced
this pull request
Feb 1, 2024
…com#1088) * tweak style to hr element in text block * border style must be solid for accurate color
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<hr/>shorthand in text blocks (---) produces a horizontal rule that doesn't quite match Consonant designs. This PR fixes that.Resolves: MWPW-131690
Test URLs: