[MWPW-131763] Variable Aside backgrounds based on media breakpoints #1162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…de-bg-breakpoints
…better handle color backgrounds
elan-tbx
requested review from
auniverseaway,
ryanmparrish,
rgclayton,
chrischrischris,
meganthecoder and
Ruchika4
|
Hello, I'm Franklin Bot and I will run some test suites that validate the page speed.
|
|
|
Codecov Report
@@ Coverage Diff @@
## main #1162 +/- ##
==========================================
+ Coverage 96.25% 96.27% +0.02%
==========================================
Files 137 137
Lines 33298 33281 -17
==========================================
- Hits 32050 32042 -8
+ Misses 1248 1239 -9
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
…om/milo into ebartholomew/aside-bg-breakpoints
|
|
Are you sure the Edit: I just checked and I see it in 4 different blocks. Can you check that your new code works with all of those blocks and provide examples for testing? |
|
|
|
|
|
ryanmparrish
approved these changes
Sep 19, 2023
aishwaryamathuria
approved these changes
Sep 20, 2023
|
|
Sartxi
approved these changes
Sep 20, 2023
Sartxi
added
verified
|
vgoodric
pushed a commit
to vgoodric/bootcamp-milo
that referenced
this pull request
Feb 1, 2024
…dobecom#1162) * add requisite styles for aside bg breakpoint switching * clean up linting errors in decorate.js, simplify decorateBlockBg and better handle color backgrounds * update global decorateBlockBg, use in aside * autoBlock races with bg creation, defer to video * fix stylelint errors * update test markup to align w/ video auto-blocking * add coverage for variable CSS backgrounds * remove test src's, make bg decorator more readable * make global base bg styles, remove dupes from aside.css * add con-block bg styles to main styles file * regroup breakpoints when only two bgs are provided * reintroduce video decorator to support additional video types * update breakpoint classnames * revert previous commit * remove bg media min height --------- Co-authored-by: Honwai Wong <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
decorateBlockBg()function indecorate.jshas been optimized/simplified, and now replaces thedecorateBlockBg()definition that was withinaside.jsaside.cssaside.cssResolves: MWPW-131763
Test URLs:
NOTE: Resize your browser window when viewing test URLs to test variable breakpoints.