Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MWPW-135263] Adding variant to figure block #1184

Merged

Conversation

JasonHowellSlavin
Copy link
Contributor

@aem-code-sync
Copy link
Contributor

aem-code-sync bot commented Aug 30, 2023

Hello, I'm Franklin Bot and I will run some test suites that validate the page speed.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-run PSI Checks

@aem-code-sync
Copy link
Contributor

aem-code-sync bot commented Aug 30, 2023

Page Scores Audits Google
/drafts/slavin/bacom-blog/infographic-test?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@JasonHowellSlavin JasonHowellSlavin added the trivial PR doesn't require E2E testing by a reviewer label Aug 30, 2023
@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Merging #1184 (8f6afe7) into main (2d10c51) will increase coverage by 0.26%.
Report is 54 commits behind head on main.
The diff coverage is 96.15%.

@@            Coverage Diff             @@
##             main    #1184      +/-   ##
==========================================
+ Coverage   95.87%   96.14%   +0.26%     
==========================================
  Files         130      132       +2     
  Lines       32250    32980     +730     
==========================================
+ Hits        30920    31708     +788     
+ Misses       1330     1272      -58     
Files Changed Coverage Δ
libs/blocks/caas/utils.js 95.54% <94.28%> (-0.06%) ⬇️
libs/blocks/caas-config/caas-config.js 99.18% <100.00%> (-0.20%) ⬇️
libs/blocks/marquee-anchors/marquee-anchors.js 100.00% <100.00%> (ø)

... and 29 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@Ruchika4 Ruchika4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@chrischrischris chrischrischris merged commit c3bfacd into adobecom:main Sep 1, 2023
10 of 12 checks passed
narcis-radu pushed a commit to narcis-radu/milo that referenced this pull request Sep 6, 2023
vgoodric pushed a commit to vgoodric/bootcamp-milo that referenced this pull request Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
trivial PR doesn't require E2E testing by a reviewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants