MWPW-138963 - Article Feed Title for DX Blog #1528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, I'm the AEM Code Sync Bot and I will run some test suites that validate the page speed.
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
JasonHowellSlavin
added
the
needs-verification
JasonHowellSlavin
requested review from
rgclayton,
overmyheadandbody and
meganthecoder
meganthecoder
approved these changes
Nov 13, 2023
JasonHowellSlavin
requested review from
fullcolorcoder,
chrischrischris and
aishwaryamathuria
|
I may close this PR due to comments from @fullcolorcoder on PR: #1513 regarding the intent of the code. Checking with PMs. |
|
|
@JasonHowellSlavin The latest change picked up on the test url still shows the old tag with the latest commit |
fullcolorcoder
approved these changes
Nov 15, 2023
meganthecoder
approved these changes
Nov 16, 2023
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1528 +/- ##
==========================================
- Coverage 95.54% 95.51% -0.04%
==========================================
Files 150 150
Lines 38726 38728 +2
==========================================
- Hits 37001 36990 -11
- Misses 1725 1738 +13 ☔ View full report in Codecov by Sentry. |
Dli3
added
verified
Brandon32
approved these changes
Nov 28, 2023
rgclayton
approved these changes
Dec 1, 2023
JasonHowellSlavin
force-pushed
the
article-feed-title
branch
from
7a8b7dc
to
792099d
Compare
chrischrischris
pushed a commit
that referenced
this pull request
Dec 6, 2023
* Removing :has selector which interferes with Firefox and does not seem to effect aside styles * Adds a check for consumer identity and then uses correct title for article cards * Re-adding category assignment * Last commit overwrite * Reverting aside changes as they are on another PR
vgoodric
pushed a commit
to vgoodric/bootcamp-milo
that referenced
this pull request
Feb 1, 2024
* Removing :has selector which interferes with Firefox and does not seem to effect aside styles * Adds a check for consumer identity and then uses correct title for article cards * Re-adding category assignment * Last commit overwrite * Reverting aside changes as they are on another PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: MWPW-138963
Context:
Similar to #1513, this PR checks for a specific consumer, and modifies the block. This is not a best practice, but currently this block is specifically designed for brand blog purposes. These blocks will likely be refactored when a new taxonomy solution is created. However, I am placing tech debt tickets in our backlog to track this code, and possibly refactor sooner.
Test URLs:
Brand Blog