Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MWPW-131002 - SKMS integration #1536

Merged
merged 6 commits into from
Dec 5, 2023

Conversation

amauch-adobe
Copy link
Contributor

@amauch-adobe amauch-adobe commented Nov 14, 2023

  • Adds auto-approved CMR integration on Milo releases for SKMS.
  • New GitHub action for merged pull requests against the production branch.

Resolves: MWPW-131002

Test URLs:

added skms integration workflow for github actions
@amauch-adobe amauch-adobe added the trivial PR doesn't require E2E testing by a reviewer label Nov 14, 2023
Copy link
Contributor

aem-code-sync bot commented Nov 14, 2023

Hello, I'm the AEM Code Sync Bot and I will run some test suites that validate the page speed.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-run PSI Checks

Copy link
Contributor

aem-code-sync bot commented Nov 14, 2023

Page Scores Audits Google
/?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@amauch-adobe
Copy link
Contributor Author

See here for instructions on how to test this integration. Specifically, read my comment at the bottom in the "Comments".

@amauch-adobe
Copy link
Contributor Author

Tested on my forked branch here. See screenshots below from the SKMS system as well GitHub actions workflow run:

GitHub Action Job Result:

Screenshot 2023-10-19 at 3 52 34 PM

SKMS System CMR Created:

Screenshot 2023-10-19 at 3 44 42 PM

@amauch-adobe
Copy link
Contributor Author

The failure in the Unit Tests has to do with the FEDS Gnav test, which this commit wouldn't have affected in any way, shape, or form.

Screenshot 2023-11-14 at 6 02 33 PM

Copy link
Contributor

aem-code-sync bot commented Nov 16, 2023

Page Scores Audits Google
/?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@Blainegunn Blainegunn changed the base branch from main to stage November 16, 2023 21:24
@Blainegunn Blainegunn requested a review from a team as a code owner November 16, 2023 21:24
Copy link
Contributor

aem-code-sync bot commented Nov 16, 2023

Page Scores Audits Google
/?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link

codecov bot commented Nov 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (11c6acc) 95.54% compared to head (2abfcc1) 95.54%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1536   +/-   ##
=======================================
  Coverage   95.54%   95.54%           
=======================================
  Files         150      150           
  Lines       38726    38726           
=======================================
+ Hits        37001    37002    +1     
+ Misses       1725     1724    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Blainegunn Blainegunn changed the base branch from stage to main November 17, 2023 21:37
Copy link
Contributor

aem-code-sync bot commented Nov 17, 2023

Page Scores Audits Google
/?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

.github/workflows/skms.yaml Show resolved Hide resolved
@amauch-adobe amauch-adobe merged commit 4722881 into adobecom:main Dec 5, 2023
10 checks passed
@amauch-adobe amauch-adobe deleted the skms-integration-final branch December 5, 2023 18:37
chrischrischris pushed a commit that referenced this pull request Dec 6, 2023
added skms integration workflow

added skms integration workflow for github actions

Co-authored-by: Blaine Gunn <[email protected]>
Co-authored-by: Okan Sahin <[email protected]>
vgoodric pushed a commit to vgoodric/bootcamp-milo that referenced this pull request Feb 1, 2024
added skms integration workflow

added skms integration workflow for github actions

Co-authored-by: Blaine Gunn <[email protected]>
Co-authored-by: Okan Sahin <[email protected]>
@amauch-adobe amauch-adobe restored the skms-integration-final branch April 29, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
trivial PR doesn't require E2E testing by a reviewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants