Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MWPW-34656: [Milo] Need the ability to reorder filter lists easily #1584

Merged
merged 10 commits into from
Dec 7, 2023

Conversation

cmiqueo
Copy link
Contributor

@cmiqueo cmiqueo commented Nov 27, 2023

Adds the ability to reorder the elements in a multifield component.

image

Resolves: MWPW-134656

Test Page: Content as a Service

Test URLs:

Copy link
Contributor

aem-code-sync bot commented Nov 27, 2023

Hello, I'm the AEM Code Sync Bot and I will run some test suites that validate the page speed.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-run PSI Checks

Copy link
Contributor

aem-code-sync bot commented Nov 27, 2023

Page Scores Audits Google
//tools/caas?martech=off Lighthouse returned error: ERRORED_DOCUMENT_REQUEST. Lighthouse was unable to reliably load the page you requested. Make sure you are testing the correct URL and that the server is properly responding to all requests. (Status code: 400) PSI
/tools/caas PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

libs/ui/controls/MultiField.js Outdated Show resolved Hide resolved
libs/ui/controls/MultiField.js Outdated Show resolved Hide resolved
@cmiqueo cmiqueo changed the title Mwpw 134656 MWPW-34656: [Milo] Need the ability to reorder filter lists easily Nov 27, 2023
Copy link
Contributor

aem-code-sync bot commented Nov 27, 2023

Page Scores Audits Google
//tools/caas?martech=off Lighthouse returned error: ERRORED_DOCUMENT_REQUEST. Lighthouse was unable to reliably load the page you requested. Make sure you are testing the correct URL and that the server is properly responding to all requests. (Status code: 400) PSI
/tools/caas PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link
Contributor

aem-code-sync bot commented Nov 28, 2023

Page Scores Audits Google
//tools/caas?martech=off Lighthouse returned error: ERRORED_DOCUMENT_REQUEST. Lighthouse was unable to reliably load the page you requested. Make sure you are testing the correct URL and that the server is properly responding to all requests. (Status code: 400) PSI
/tools/caas PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@cmiqueo cmiqueo added trivial PR doesn't require E2E testing by a reviewer caas-configurator CaaS Configurator labels Nov 28, 2023
@cmiqueo cmiqueo self-assigned this Nov 28, 2023
Copy link
Contributor

aem-code-sync bot commented Nov 28, 2023

Page Scores Audits Google
/tools/caas?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/tools/caas PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link

codecov bot commented Dec 4, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (683cbf7) 0.00% compared to head (f83417a) 95.03%.

Additional details and impacted files
@@            Coverage Diff            @@
##           main    #1584       +/-   ##
=========================================
+ Coverage      0   95.03%   +95.03%     
=========================================
  Files         0      153      +153     
  Lines         0    39168    +39168     
=========================================
+ Hits          0    37224    +37224     
- Misses        0     1944     +1944     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@overmyheadandbody overmyheadandbody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has drag and drop been considered for this? Depending on web producers' needs, it might be easier to move the filters by dragging instead of clicking the up/down button more than 2-3 times

libs/blocks/caas-config/caas-config.css Outdated Show resolved Hide resolved
libs/blocks/caas-config/caas-config.css Outdated Show resolved Hide resolved
@sanrai sanrai merged commit 2c60930 into main Dec 7, 2023
10 of 11 checks passed
@sanrai sanrai deleted the MWPW-134656 branch December 7, 2023 22:09
yesil pushed a commit to yesil/milo that referenced this pull request Dec 14, 2023
…dobecom#1584)

* initial commit

* MWPW-134656: adds the ability to move multifield items up or down

* Update MultiField.js: Remove console statements

* Update MultiField.js removes comment

* Update caas-config.css:  Implements PR review suggestions
VKniaz pushed a commit to VKniaz/milo that referenced this pull request Dec 15, 2023
…dobecom#1584)

* initial commit

* MWPW-134656: adds the ability to move multifield items up or down

* Update MultiField.js: Remove console statements

* Update MultiField.js removes comment

* Update caas-config.css:  Implements PR review suggestions
vgoodric pushed a commit to vgoodric/bootcamp-milo that referenced this pull request Feb 1, 2024
…dobecom#1584)

* initial commit

* MWPW-134656: adds the ability to move multifield items up or down

* Update MultiField.js: Remove console statements

* Update MultiField.js removes comment

* Update caas-config.css:  Implements PR review suggestions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
caas-configurator CaaS Configurator trivial PR doesn't require E2E testing by a reviewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants