MWPW-138966: aa for gnav hamburger menu button #1592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robert-bogos
added
run-nala
robert-bogos
requested review from
overmyheadandbody,
mokimo and
narcis-radu
as code owners
|
Hello, I'm the AEM Code Sync Bot and I will run some test suites that validate the page speed.
|
|
narcis-radu
requested changes
Nov 30, 2023
overmyheadandbody
approved these changes
Dec 4, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1592 +/- ##
==========================================
- Coverage 95.54% 95.53% -0.02%
==========================================
Files 150 150
Lines 38702 38704 +2
==========================================
- Hits 36979 36976 -3
- Misses 1723 1728 +5 ☔ View full report in Codecov by Sentry. |
narcis-radu
approved these changes
Dec 5, 2023
SilviuLCF
approved these changes
Dec 6, 2023
There was a problem hiding this comment.
PR can be merged to main:
Testing details: https://jira.corp.adobe.com/browse/MWPW-138966
chrischrischris
pushed a commit
that referenced
this pull request
Dec 6, 2023
* aa for gnav hamburger menu button * hotfix --------- Co-authored-by: Narcis Radu <[email protected]>
yesil
pushed a commit
to yesil/milo
that referenced
this pull request
Dec 7, 2023
* aa for gnav hamburger menu button * hotfix --------- Co-authored-by: Narcis Radu <[email protected]>
vgoodric
pushed a commit
to vgoodric/bootcamp-milo
that referenced
this pull request
Feb 1, 2024
* aa for gnav hamburger menu button * hotfix --------- Co-authored-by: Narcis Radu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds AA tracking, on mobile, for the hamburger menu button from the global navigation.
Related Issue
Resolves: MWPW-138966
Screenshots:
Menu closed:
Menu open:
Test URLs
Acrobat:
BACOM:
CC:
Milo: