Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MWPW-140272 Move MEP button to the left side #1667

Merged
merged 2 commits into from
Dec 15, 2023
Merged

MWPW-140272 Move MEP button to the left side #1667

merged 2 commits into from
Dec 15, 2023

Conversation

vgoodric
Copy link
Contributor

Because the chat feature is located in the same location as the MEP button, they interfere with each other on pages using both.
Solution, move the MEP button to the bottom left corner (both in mobile and desktop view)

Example: https://business.adobe.com/?mep

image
image

Resolves: MWPW-140272

Test URLs:

@vgoodric vgoodric requested a review from a team as a code owner December 15, 2023 20:26
@aem-code-sync AEM Code Sync
Copy link
Contributor

aem-code-sync bot commented Dec 15, 2023 •
edited
Loading

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@aem-code-sync AEM Code Sync
Copy link
Contributor

aem-code-sync bot commented Dec 15, 2023 •
edited
Loading

Page Scores Audits Google
/?mep&martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@vgoodric vgoodric added verified PR has been E2E tested by a reviewer trivial PR doesn't require E2E testing by a reviewer labels Dec 15, 2023
@vgoodric vgoodric merged commit 45a3a38 into main Dec 15, 2023
8 of 9 checks passed
@vgoodric vgoodric deleted the move-mep-btn branch December 15, 2023 23:57
vgoodric added a commit to vgoodric/bootcamp-milo that referenced this pull request Feb 1, 2024
@vgoodric @vivgoodrich
MWPW-140272 Move MEP button to the left side (adobecom#1667)
42b87d1 
MWPW-140272 Move MEP button to the left

Co-authored-by: vivgoodrich <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ruchika4 Ruchika4 Ruchika4 approved these changes

@fullcolorcoder fullcolorcoder fullcolorcoder approved these changes

@rgclayton rgclayton rgclayton approved these changes

Assignees
No one assigned
Labels
trivial PR doesn't require E2E testing by a reviewer verified PR has been E2E tested by a reviewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vgoodric @rgclayton @fullcolorcoder @Ruchika4 @vivgoodrich