Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

faas-env default qa #1716

Merged
merged 6 commits into from
Jan 9, 2024
Merged

faas-env default qa #1716

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5a2340c
faas-env default qa
seanchoi-dev Jan 9, 2024
f6d1b99
unit test
seanchoi-dev Jan 9, 2024
479184b
remove colsole log
seanchoi-dev Jan 9, 2024
b0d2679
console.error -> window.lana.log
seanchoi-dev Jan 9, 2024
6685515
altering faasCurrentJS instead faasHostUrl that being exported.
seanchoi-dev Jan 9, 2024
1ff571c
Added missed part.
seanchoi-dev Jan 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions libs/blocks/faas/utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,12 +26,12 @@
if (faasEnv === 'qa') {
return 'qa.';
}
return 'dev.';
return 'qa.';
};

const base = miloLibs || codeRoot;
export const faasHostUrl = `https://${getFaasHostSubDomain()}apps.enterprise.adobe.com`;
const faasCurrentJS = `${faasHostUrl}/faas/service/jquery.faas-current.js`;
export const faasHostUrl = base.includes('localhost') ? `${base}/deps` : `https://${getFaasHostSubDomain()}apps.enterprise.adobe.com/faas/service`;
seanchoi-dev marked this conversation as resolved.
Show resolved Hide resolved
const faasCurrentJS = `${faasHostUrl}/jquery.faas-current.js`;
export const loadFaasFiles = () => {
loadStyle(`${base}/blocks/faas/faas.css`);
return Promise.all([
Expand Down Expand Up @@ -248,7 +248,7 @@
}),
})
.catch((error) => {
console.error('AA Sandbox Error:', error);

Check warning on line 251 in libs/blocks/faas/utils.js

View workflow job for this annotation

GitHub Actions / Running eslint 

[eslint] reported by reviewdog 🐶
Unexpected console statement.

Raw Output:
{"ruleId":"no-console","severity":1,"message":"Unexpected console statement.","line":251,"column":9,"nodeType":"MemberExpression","messageId":"unexpected","endLine":251,"endColumn":22}
});
}
};
Expand Down
2 changes: 1 addition & 1 deletion test/blocks/faas/utils.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ describe('Faas', () => {
expect(getFaasHostSubDomain('stage')).to.equal('staging.');
expect(getFaasHostSubDomain('dev')).to.equal('dev.');
expect(getFaasHostSubDomain('qa')).to.equal('qa.');
expect(getFaasHostSubDomain()).to.equal('dev.');
expect(getFaasHostSubDomain()).to.equal('qa.');
});

it('localizes the destination url', () => {
Expand Down
Loading