MWPW-140738 - Add foreground gap on large marquees #1718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elan-tbx
added
trivial
elan-tbx
requested review from
auniverseaway,
ryanmparrish,
rgclayton,
chrischrischris,
aishwaryamathuria,
Sartxi,
overmyheadandbody and
JasonHowellSlavin
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1718 +/- ##
==========================================
+ Coverage 95.58% 95.61% +0.03%
==========================================
Files 155 155
Lines 39735 39735
==========================================
+ Hits 37979 37993 +14
+ Misses 1756 1742 -14 ☔ View full report in Codecov by Sentry. |
overmyheadandbody
approved these changes
Jan 10, 2024
|
@elan-tbx It looks like the AEM PSI check is having a hard time with your link? |
Sartxi
approved these changes
Jan 10, 2024
JasonHowellSlavin
approved these changes
Jan 10, 2024
narcis-radu
pushed a commit
that referenced
this pull request
Jan 17, 2024
* MWPW-137938 - Inline video image fallback (#1542) * Summarize changes in 50 characters or less More detailed explanatory text. Wrap at 72 characters. Resolves: MWPW-xxxx See also: MWPW-xxxx, MWPW-xxxx * Adding unit test. Addressing PR feedback. --------- Co-authored-by: Ryan Clayton <[email protected]> Co-authored-by: Blaine Gunn <[email protected]> * MWPW-137523 - Allow dark quiet marquees (#1654) * apply style updates * do not add dark to quiet marquee by default * additional :is usage * MWPW-140321 - how-to block - Heading area without Image has gap (#1670) Added style for .has-class to set logical grid display * MWPW-140273 Highlight replace fragment (#1672) * MWPW-140273 highlight replace fragment * getFileName function * permissions test * remove test comment * make manifestId consistent * fix unit tests * add to unit test * streamline addHighlightData --------- Co-authored-by: vivgoodrich <[email protected]> * MWPW-140470: allow OST to overwrite landscape (#1668) allow OST to overwrite landscape * MWPW-131662: consistent global navigation padding on mobile (#1679) * fixed global navigation padding on mobile * hotfix * hotfix * hotfix * hotfix * MWPW-131195: gnav cloud links section (#1586) * ui: gnav cloud links * hotfix * hotfix * hotfix * hotfix * hotfix * hotfix * hotfixes * hotfixes * hotfix * hotfixes * optimizing * hotfix * optimizing * hotfix * updated test mocks for cross cloud menu * hotfix * hotfix * hotfix * optimizing * optimizing * config - target file for testing * Revert "MWPW-137523 - Allow dark quiet marquees" (#1693) Revert "MWPW-137523 - Allow dark quiet marquees (#1654)" This reverts commit 921efe5. * MWPW-140052-Word break css for korean (#1675) * Update styles.css * update css to support language based korean sites too * [MWPW-140706] Quiz options should use Adobe Clean and [MWPW-140499] fix multiple merch card width issue on result page (#1694) * MWPW-140499: fix multiple merch card width issue on result page (#1660) fix multiple merch card width issue on result page Co-authored-by: xiasun <[email protected]> * MWPW-140706: Quiz options should use Adobe Clean (#1682) --------- Co-authored-by: xiasun <[email protected]> Co-authored-by: Erich Champion <[email protected]> * [MWPW-140788] Ensure correct Gnav Promo element order (#1691) * [MWPW-140788] Ensure correct Gnav Promo element order * [MWPW-140788] Unit tests for Gnav Promo elem order * Fix broken gnav test (#1699) * Fix broken gnav test * Cleanup * MWPW-140877 - Quiz Marquee style updates (#1701) * fixed quiz-marquee styles - aside.notification to inline on mobile, cards alignment on center * no margin on nested aside body-m * width update * added same card width style to quiz-results * [#1641] add parent option to createTag (#1698) - add options parameter to createTag signature, with only one parent option for now, as discussed in https://github.com/orgs/adobecom/discussions/1641, - add unit test for create Tag * MWPW-140345-Fix issues in media QR block variant (#1658) * MWPW-140345 * MWPW-140345 * MWPW-140345 * Update media.js * Update media.css * Update unit test * Update qr block css * Update media.css * Update media.test.js * Update media.test.js * document OST overrides (#1692) * document OST overrides * fix typo * Create merch block README.md (#1707) * Create merch block README.md * fix code styling * MWPW-140623 - Auto-merge main to stage (#1671) add workflow to auto-merge main into stage * MWPW-140780 - Remove :has() selector from Aside (#1687) remove :has selector altogether * MWPW-140660 Fix Marketo Destination Url (#1702) * MWPW-140862: Updated twitter logo (#1700) [MWPW-140862] Updated twitter logo * MWPW-140538 - Icon Block inline margin (#1688) Unset margin auto on section up nested inline iconblocks * Update magma codeowners (#1709) * MWPW-137523 - Allow dark quiet marquees (redux) (#1696) * achieve goals with lowest impact possible * move dark exclusions to a variable * revert min-height changes * quiet:not(.dark) * MWPW-140191: Fixes Merch Card custom <hr> color, inline heading variant (#1710) MWPW-140191: Fixes Merch Card custom <hr> color * faas-env default qa (#1716) * faas-env default qa * unit test * remove colsole log * console.error -> window.lana.log * altering faasCurrentJS instead faasHostUrl that being exported. * Added missed part. * MWPW-140964 Marquee static links should not be blue on hover (#1705) Co-authored-by: vivgoodrich <[email protected]> * MWPW-140738 - Add foreground gap on large marquees (#1718) remove gap: 0 on large marquees * MWPW-139379 Improve Tab Scrolling for Mobile (#1624) * MWPW-139379 Improve Mobile Tab Scrolling * MWPW-140403 | Aside promo block button and block size (#1680) For aside promo block following minor bugs are fixed in this PR Setting default button height for all promo to be 40px (button-l). Setting popup promo default width in desktop to be 85 % and max upto 1600px Resolves: MWPW-140403 Test URLs: Before: https://main--milo--adobecom.hlx.page/docs/library/kitchen-sink/aside-promo?martech=off After: https://mwpw-140403--milo--aishwaryamathuria.hlx.page/docs/library/kitchen-sink/aside-promo?martech=off * MWPW-140836: fix Commerce for several geo's (#1708) * fix WCS commerce for umbrella regions * MWPW-139915: Delivery of Spectrum Web Components (#1663) (#1721) * MWPW-139915: Delivery of Spectrum Web Components (#1663) * MWPW-139915: Spectrum Web Components delivery for commerce * add README * muted eslint errors for src/dist folders * Update merch.js * Update merch.js * exclude swc from codecov * PR feedbacks incorporated. * MWPW-140267 Update MEP PZN tags (#1724) * MWPW-140267 Update PZN tags * update mobile definition * add windows and mac * base phone vs tablet on screen size * switch to OR * alert to debug on iphone * tyring to test version * remove comment now that I see update * trying to differentiate between safari and chrome * reverting changes for Chrome Safari differentiating * adding feedback to debug safari on ipad * fix false positive on logged out * remove debug line * changing msedge to edge * update device type tags to all be singular * update reference for mobile --------- Co-authored-by: vivgoodrich <[email protected]> * MWPW-140467 Integrate round-corners for brick block (#1664) * Update blocks.js * rounded-corner-brick block * rounded-corner-brick block * rounded-corner-brick block * minor change * review suggestion --------- Co-authored-by: Suhani Jain <[email protected]> Co-authored-by: Suhani Jain <[email protected]> * MWPW-140953: Updated twitter logo (#1732) ui: updated twitter logo * MWPW-140836: Switch Milo Commerce to own country/language mapping (#1728) * bring mapping for all wcs locales * Revert "MWPW-139379 Improve Tab Scrolling for Mobile" (#1733) * [MWPW-140624] Footer layout with few columns (#1730) * MWPW-140916, MWPW-141124: Adding result to quiz analytics; update merch card width (#1717) * MWPW-140499: fix multiple merch card width issue on result page (#1660) fix multiple merch card width issue on result page Co-authored-by: xiasun <[email protected]> * MWPW-140706: Quiz options should use Adobe Clean (#1682) * MWPW-140916: Adding result to analytics (#1715) * MWPW-140916: Adding result to analytics * MWPW-140916: Fixing lint errors * MWPW-141124: match widths used by standard merch cards (#1725) Co-authored-by: xiasun <[email protected]> * Incorporating comments from Rares * Updating handleResultFlow test --------- Co-authored-by: Jacky Sun <[email protected]> Co-authored-by: xiasun <[email protected]> Co-authored-by: xiasun <[email protected]> * MWPW-140268 Icon duplicates if nested in multiple sections (#1731) * MWPW-140268 Icon duplicates if nested in multiple sections * Update libs/features/icons/icons.js Co-authored-by: Okan Sahin <[email protected]> * Update unit test to check for duplicates --------- Co-authored-by: vivgoodrich <[email protected]> Co-authored-by: Okan Sahin <[email protected]> * MWPW-141139 Parameter PZN tags don't match if user uses uppercase characters (#1726) * MWPW-141139 Parameter PZN tags don't match if user uses upercase characters * conditional chaining and param name not case sensitive * Update libs/features/personalization/personalization.js Co-authored-by: Chris Peyer <[email protected]> --------- Co-authored-by: vivgoodrich <[email protected]> Co-authored-by: Chris Peyer <[email protected]> * MWPW-136866: merch-cards block (#1729) * MWPW-136866: merch-cards block (#1676) * MWPW-136866: merch-cards block * update code owners * fix failing tests * rename main to init * removed TODO comment. * MWPW-141140 MEP throws error if page filter uses single asterisks (#1740) Co-authored-by: vivgoodrich <[email protected]> * [MILOLIBS RUN : MWPW-141223] Provide support to run nala tests on a given milo libs (#1742) nala-milo-libs Co-authored-by: nateekar <[email protected]> --------- Co-authored-by: Ryan Clayton <[email protected]> Co-authored-by: Ryan Clayton <[email protected]> Co-authored-by: Blaine Gunn <[email protected]> Co-authored-by: Elan Bartholomew <[email protected]> Co-authored-by: Ryan Parrish <[email protected]> Co-authored-by: Vivian A Goodrich <[email protected]> Co-authored-by: vivgoodrich <[email protected]> Co-authored-by: Mariia Lukianets <[email protected]> Co-authored-by: Ruchika Sinha <[email protected]> Co-authored-by: Jacky Sun <[email protected]> Co-authored-by: xiasun <[email protected]> Co-authored-by: Erich Champion <[email protected]> Co-authored-by: Rares Munteanu <[email protected]> Co-authored-by: Okan Sahin <[email protected]> Co-authored-by: Nicolas Peltier <[email protected]> Co-authored-by: Megan Thomas <[email protected]> Co-authored-by: Sean Archibeque <[email protected]> Co-authored-by: Axel Cureno Basurto <[email protected]> Co-authored-by: Sean Choi <[email protected]> Co-authored-by: Brandon Marshall <[email protected]> Co-authored-by: Aishwarya Mathuria <[email protected]> Co-authored-by: ilyas Stéphane Türkben <[email protected]> Co-authored-by: Suhani Jain <[email protected]> Co-authored-by: Suhani Jain <[email protected]> Co-authored-by: Suhani Jain <[email protected]> Co-authored-by: xiasun <[email protected]> Co-authored-by: Chris Peyer <[email protected]> Co-authored-by: Santoshkumar Nateekar <[email protected]> Co-authored-by: nateekar <[email protected]>
vgoodric
pushed a commit
to vgoodric/bootcamp-milo
that referenced
this pull request
Feb 1, 2024
remove gap: 0 on large marquees
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.foregroundgap for large marquees. Now, however, the current design of all marquees requires it. This PR gives large marquees consistent spacing.Resolves: MWPW-140738
Test URLs: