Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release] Stage to Main #2270

Merged
merged 14 commits into from
May 9, 2024
Merged

[Release] Stage to Main #2270

merged 14 commits into from
May 9, 2024

Conversation

mokimo and others added 6 commits May 8, 2024 08:03
* [MWPW-147001] Stage initiative automation

* Add high prio PRs & fail on RCP cutoff

* Rename constants

* Add exclamation mark

* Add the alert emoji

* Add a high impact slack webhook

* Re-add overlap check

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
… the gnav file (#2252)

* Merging inline-block to milo branch for further updates (#2170)

* MWPW-135821 introduce custom action

- and inaugurating first custom action for replacing cards in collection

* MWPW-135821 use prefix in selector

* MWPW-135821 adding preview data

---------

Co-authored-by: Nicolas Peltier <[email protected]>
Co-authored-by: Nicolas Peltier <[email protected]>

* initial commit with TODO

* registerCustomAction updated

* fragment, highlight fragment and merch-card update

* chain fragment support added

* inBlock fragments with URL and path as keys

* css selectors starting to work

* Add forceInline to handleCommands

* stash

* unit tests mostly done

* fix mocking issue

* add martech-metadata to unit test mock and check for replace

* change name of registerCustomAction to registerInBlockActions

* indent issue

* remove mep useBlockCode Example

* merch-card-collection-fix

* update merch-card-collection unit test

* ignore lines that cannot be reached by unit tests

* rename CUSTOM_SELECTOR_PREFIX

* Update libs/features/personalization/personalization.js

Co-authored-by: Chris Peyer <[email protected]>

* Update libs/features/personalization/personalization.js

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update libs/features/personalization/personalization.js

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* call addHash once, not twice

* Update libs/features/personalization/personalization.js

Co-authored-by: Chris Peyer <[email protected]>

---------

Co-authored-by: Nicolas Peltier <[email protected]>
Co-authored-by: Nicolas Peltier <[email protected]>
Co-authored-by: markpadbe <[email protected]>
Co-authored-by: Chris Peyer <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Okan Sahin <[email protected]>
* MWPW-144549 CTA alignment for Text, Icon, and Media Blocks

* fix text block icon-inline
…#2216)

refactor(video-metadata): createVideoObject(record)
Co-authored-by: Snehal Sonawane <[email protected]>
Co-authored-by: Bandana Laishram <[email protected]>
Copy link
Contributor

aem-code-sync bot commented May 8, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link
Contributor

aem-code-sync bot commented May 8, 2024

Page Scores Audits Google
/?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@mokimo mokimo requested review from a team and removed request for a team May 8, 2024 06:46
…bove icons (#2240)

* Check for block content and use as header if exists, updated twitter icon ref

* Refactored to allow for authoring icon discression

* share.test for new custom title, refactored so .inline doesn't have title support

* remove test console

* linting

* eslint adjust better readability

* addressed issue found when block has no content row
Copy link

codecov bot commented May 8, 2024

Codecov Report

Attention: Patch coverage is 98.47716% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 95.69%. Comparing base (9c1339b) to head (95ab427).
Report is 1 commits behind head on main.

Files Patch % Lines
libs/blocks/share/share.js 92.85% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2270      +/-   ##
==========================================
+ Coverage   95.64%   95.69%   +0.04%     
==========================================
  Files         166      166              
  Lines       43871    44009     +138     
==========================================
+ Hits        41961    42115     +154     
+ Misses       1910     1894      -16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mokimo mokimo added the needs-verification PR requires E2E testing by a reviewer label May 8, 2024
@mokimo
Copy link
Contributor

mokimo commented May 8, 2024

Seems like this was merged with a file overlap of #2264 & #2252 - I'll re-check the workflow that shouldn't happen.

I'd say it's fine to keep this though rather than trying to eagerly revert one or another.

* add rule for action area immediately following a heading

* add quotes to selector to bring it into alignment with other styles
@meganthecoder
Copy link
Contributor

@ryanmparrish For #2240 , it looks like the default Share block used to say "Share this page" but now there's no copy by default. Is that expected behavior?

Main: https://main--bacom--adobecom.hlx.page/drafts/denli/blocks/share
Screenshot 2024-05-08 at 11 33 01 AM

Stage: https://main--bacom--adobecom.hlx.page/drafts/denli/blocks/share?milolibs=stage
Screenshot 2024-05-08 at 11 33 07 AM

@meganthecoder
Copy link
Contributor

@ryanmparrish For #2240 , it looks like the default Share block used to say "Share this page" but now there's no copy by default. Is that expected behavior?

The bacom authors aren't aware of any Share blocks live on the site, so this isn't a blocking issue for us. Everything else looks good.

Copy link
Contributor Author

github-actions bot commented May 9, 2024

This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR.

@aem-code-sync aem-code-sync bot temporarily deployed to library-container May 9, 2024 20:06 Inactive
@fullcolorcoder fullcolorcoder merged commit bd51767 into main May 9, 2024
36 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.