MWPW-147634 - Add support for a custom Form block endpoint #2291

elan-tbx · 2024-05-10T13:36:15Z

The forms service in Franklin is getting turned off, which means the Form block as it exists right now will become obsolete. This PR adds the ability to include a custom endpoint for the data, so this block can still be used (assuming the author has another forms service they can plug it in to)
This is accomplished by simply splitting the cell that includes the input URL, and adding the output URL to the second cell.

288181950-8be89e53-a91f-42c5-b862-77b7426c9fa6

Test URLs:

aem-code-sync · 2024-05-10T13:36:18Z

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

Re-run PSI checks
Re-sync branch

Commits

2241638 ✅ (latest)
3bc8267 ✅
0eac17f ✅
8ba9aca ✅
ec902b3 ✅
b7235b1 ✅
04a53a6 ✅
e1e2ddc ✅
a926237 ✅
47c10b4 ✅
fe2bab3 ✅
48ede00 ✅
c4a1f4a ✅
cde37b5 ✅
c755c30 ✅
2efcb33 ✅
80515d9 ✅
eea752e ✅
5b45f9c ✅

aem-code-sync · 2024-05-10T13:36:40Z

Page	Scores	Audits	Google
/drafts/ebartholomew/elan-form3?martech=off

mokimo · 2024-05-10T14:19:46Z

Why not use metadata to read the input & output url? I don't know if the block is already used anywhere, but that way you could roll out the new metadata field to a whole project

github-actions · 2024-05-11T01:11:20Z

This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR.

libs/blocks/form/form.js

overmyheadandbody · 2024-05-13T10:37:51Z

@mokimo - I guess there could be multiple forms per page, maybe?

…change (#2248) Potential fix for bulk publisher issues Co-authored-by: Blaine Gunn <[email protected]> Co-authored-by: Sheridan Sunier <[email protected]>

Updating how alt text is used and displayed in preflight Co-authored-by: Ryan Clayton <[email protected]>

Co-authored-by: Brad Johnson <[email protected]> Co-authored-by: Sheridan Sunier <[email protected]>

remove role attribute on dd elements Co-authored-by: Okan Sahin <[email protected]>

…2198) * MWPW-147158: adds support for footer divider at the collection level * Updatest unit-test files * Update windows copy hash * Update OSX copy hash * Updates OSX hash again * Removes console log * Adds console logs for debbuging * Removes console logs * Adds console logs for debbuging again * Removes console log * Updates OSX hash * Adds debuging message to test * Update os-hash check logic * trim() generated hash * Changes the comparison logic for the hash * Reverts last attempt * new attempt to fix test --------- Co-authored-by: Okan Sahin <[email protected]>

…sidekick (#2244) * Fix for origin always being upper cased * Update tools/send-to-caas/send-utils.js changing to const Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Okan Sahin <[email protected]>

* Stage process improvements * Remove team reviewers * Formatting * Simplify PR bodies --------- Co-authored-by: Robert Bogos <[email protected]>

Remove label & merge workflows Co-authored-by: Robert Bogos <[email protected]>

* Initial quiz-entry block with ml field * MWPW-144810: Quiz Entry - Add option cards and text to the block (#2095) * Quiz entry block (#2103) * MWPW-144810: Quiz Entry - Add option cards and text to the block * MWPW-144810: Add the text to strings.xlsx for title, subtitle, ML field default, card instruction bar and the button * MWPW-146243 - Quiz entry code optimization (#2121) * MWPW-146243 - Quiz entry code optimization * Restores code optimization that was lost in previous PRs Resolves: [MWPW-146243](https://jira.corp.adobe.com/browse/MWPW-146243) * Update utils.js * Update quiz-entry.js Set button to use string values * Update quiz-entry.js Fixed to use new strings object * MWPW-146034 - Quiz entry block accessibility (#2139) * resolved accessibility concerns when the ml input is used * general code refinements for more clarity, specifically for getting string values Resolves: [MWPW-146034](https://jira.corp.adobe.com/browse/MWPW-146034) * MWPW-146036 - Rig up quiz entry button (#2190) * Support for ml filtering * Debug support using ?debug=quiz-entry * Store quizState in local storage and redirect to the quiz Resolves: [MWPW-146036](https://jira.corp.adobe.com/browse/MWPW-146036) * Quiz entry block (#2204) * MWPW-144810: Quiz Entry - Add option cards and text to the block * MWPW-144810: Add the text to strings.xlsx for title, subtitle, ML field default, card instruction bar and the button * MWPW-147031:Add Analytics for Quiz Entry Block, MWPW-146080: Integrate Auto-Complete for Open Text Field on UAR Exposed Front Door * fix eslint * fix code according feedbacks * MWPW-144022: Quiz entry block (#2227) * carousel starts * got buttons working * MWPW-144022: Prototype carousel refinement, keybord controls updated * linting fixes * MWPW-147482 - ML Input Bulletproofing (#2242) * add support for fallback fi codes * add lana logging for ml field failures * fix so the redirect checks for maxQuestions Resolves: [MWPW-147482](https://jira.corp.adobe.com/browse/MWPW-147482) **Test URLs:** - Before: https://main--milo--adobecom.hlx.page/?martech=off - After: https://<branch>--milo--adobecom.hlx.page/?martech=off * MWPW-147683 - CSS Cleanup (#2267) * MWPW-147683 - CSS Cleanup * Final pass on the css * Edits to markup where necessary Resolves: [MWPW-147683](https://jira.corp.adobe.com/browse/MWPW-147683) * pr feedback for vars and eslint errors * more PR feedback on icon placement * pr feedback for button border * cleaned up the carousel widths so it's consistent it all times as it was previously 8px short. * pr feedback on the location of the input clear X. * PR feedback - reduced border on input, fixed a card disable bug, addressed card layout in tablet * carousel starts * got buttons working * MWPW-144022: Prototype carousel refinement, keybord controls updated * linting fixes * Tests * working tests update * Small font size fixes that design has asked for * linting * linting * Update quiz-entry.js with default vals * Bring back debug * debugging debug * Update test/blocks/quiz-entry/mocks/mock-data.js Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Update test/blocks/quiz-entry/mocks/mock-data.js Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Update test/blocks/quiz-entry/mocks/mock-data.js Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Update test/blocks/quiz-entry/mocks/mock-data.js Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Update test/blocks/quiz-entry/mocks/mock-data.js Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Update test/blocks/quiz-entry/mocks/mock-data.js Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Update test/blocks/quiz-entry/mocks/mock-data.js Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Update test/blocks/quiz-entry/mocks/mock-data.js Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Update test/blocks/quiz-entry/mocks/mock-data.js Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Update test/blocks/quiz-entry/quiz-entry.test.js Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Update test/blocks/quiz-entry/quiz-entry.test.js Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Update test/blocks/quiz-entry/mocks/mock-data.js Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Update test/blocks/quiz-entry/mocks/mock-data.js Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * added quiz-entry to utils.js (#2296) Co-authored-by: Denys Fedotov <[email protected]> * MWPW-148206: Update Spectra ML host from cchome-dev to cchome for PROD --------- Co-authored-by: Jacky Sun <[email protected]> Co-authored-by: Brad Johnson <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Denys Fedotov <[email protected]> Co-authored-by: Denys Fedotov <[email protected]> Co-authored-by: Jacky Sun <[email protected]>

codecov · 2024-05-14T17:12:23Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.63%. Comparing base (03efb0b) to head (2241638).
Report is 10 commits behind head on stage.

Additional details and impacted files

@@            Coverage Diff             @@
##            stage    #2291      +/-   ##
==========================================
+ Coverage   95.61%   95.63%   +0.02%     
==========================================
  Files         172      173       +1     
  Lines       45110    45168      +58     
==========================================
+ Hits        43130    43197      +67     
+ Misses       1980     1971       -9

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-actions · 2024-05-22T01:13:45Z

This PR is currently in the needs-verification state. Please assign a QA engineer to verify the changes.

libs/blocks/form/form.js

Co-authored-by: Rares Munteanu <[email protected]>

elan-tbx · 2024-06-03T15:02:57Z

Closing for now while a proper E2E pipeline is figured out, will re-open in the future.

add support for custom endpoint

5b45f9c

elan-tbx added new-feature New block or other feature needs-verification PR requires E2E testing by a reviewer labels May 10, 2024

elan-tbx requested review from narcis-radu, auniverseaway, ryanmparrish, rgclayton, Sartxi and overmyheadandbody May 10, 2024 13:36

overmyheadandbody reviewed May 13, 2024

View reviewed changes

libs/blocks/form/form.js Outdated Show resolved Hide resolved

libs/blocks/form/form.js Outdated Show resolved Hide resolved

elan-tbx and others added 11 commits May 14, 2024 10:56

update tests

eea752e

MWPW-147599: CaaS Bulk Publisher not working after MS authentication …

80515d9

…change (#2248) Potential fix for bulk publisher issues Co-authored-by: Blaine Gunn <[email protected]> Co-authored-by: Sheridan Sunier <[email protected]>

Preflight Accessibility tab update (#2254)

2efcb33

Updating how alt text is used and displayed in preflight Co-authored-by: Ryan Clayton <[email protected]>

MWPW-146407: add new card style to caas configurator (#2279)

c755c30

Co-authored-by: Brad Johnson <[email protected]> Co-authored-by: Sheridan Sunier <[email protected]>

MWPW-141780 - Clean up Accordion block attributes (#2276)

cde37b5

remove role attribute on dd elements Co-authored-by: Okan Sahin <[email protected]>

Stage automation, update the body after merging another PR in (#2289)

fe2bab3

* Stage process improvements * Remove team reviewers * Formatting * Simplify PR bodies --------- Co-authored-by: Robert Bogos <[email protected]>

Remove label requirements & merge workflows (#2288)

47c10b4

Remove label & merge workflows Co-authored-by: Robert Bogos <[email protected]>

update tests again

e1e2ddc

aem-code-sync bot temporarily deployed to ebartholomew/MWPW-147634-form-endpoints May 14, 2024 17:05 Inactive

consolidate args to config obj

04a53a6

aem-code-sync bot temporarily deployed to ebartholomew/MWPW-147634-form-endpoints May 14, 2024 17:15 Inactive

elan-tbx requested a review from overmyheadandbody May 14, 2024 17:16

Merge branch 'stage' into ebartholomew/MWPW-147634-form-endpoints

b7235b1

aem-code-sync bot temporarily deployed to ebartholomew/MWPW-147634-form-endpoints May 14, 2024 17:17 Inactive

elan-tbx marked this pull request as ready for review May 14, 2024 17:17

Sartxi approved these changes May 15, 2024

View reviewed changes

Merge branch 'stage' into ebartholomew/MWPW-147634-form-endpoints

ec902b3

aem-code-sync bot temporarily deployed to ebartholomew/MWPW-147634-form-endpoints May 17, 2024 15:40 Inactive

Merge branch 'stage' into ebartholomew/MWPW-147634-form-endpoints

8ba9aca

aem-code-sync bot temporarily deployed to ebartholomew/MWPW-147634-form-endpoints May 20, 2024 15:47 Inactive

chrischrischris approved these changes May 21, 2024

View reviewed changes

elan-tbx added 2 commits May 21, 2024 11:46

Merge branch 'stage' into ebartholomew/MWPW-147634-form-endpoints

0eac17f

Merge branch 'stage' into ebartholomew/MWPW-147634-form-endpoints

3bc8267

aem-code-sync bot temporarily deployed to ebartholomew/MWPW-147634-form-endpoints May 21, 2024 22:00 Inactive

elan-tbx requested a review from SilviuLCF May 21, 2024 22:00

overmyheadandbody approved these changes May 22, 2024

View reviewed changes

libs/blocks/form/form.js Outdated Show resolved Hide resolved

overmyheadandbody assigned kundanpa May 22, 2024

add empty default for createForm

2241638

Co-authored-by: Rares Munteanu <[email protected]>

aem-code-sync bot deployed to ebartholomew/MWPW-147634-form-endpoints May 28, 2024 23:07 View deployment

elan-tbx closed this Jun 3, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

MWPW-147634 - Add support for a custom Form block endpoint #2291

MWPW-147634 - Add support for a custom Form block endpoint #2291

elan-tbx commented May 10, 2024

aem-code-sync bot commented May 10, 2024 •

edited

Loading

aem-code-sync bot commented May 10, 2024 •

edited

Loading

mokimo commented May 10, 2024 •

edited

Loading

github-actions bot commented May 11, 2024

overmyheadandbody commented May 13, 2024

codecov bot commented May 14, 2024 •

edited

Loading

github-actions bot commented May 22, 2024

elan-tbx commented Jun 3, 2024

MWPW-147634 - Add support for a custom Form block endpoint #2291

MWPW-147634 - Add support for a custom Form block endpoint #2291

Conversation

elan-tbx commented May 10, 2024

aem-code-sync bot commented May 10, 2024 • edited Loading

aem-code-sync bot commented May 10, 2024 • edited Loading

mokimo commented May 10, 2024 • edited Loading

github-actions bot commented May 11, 2024

overmyheadandbody commented May 13, 2024

codecov bot commented May 14, 2024 • edited Loading

Codecov Report

github-actions bot commented May 22, 2024

elan-tbx commented Jun 3, 2024

aem-code-sync bot commented May 10, 2024 •

edited

Loading

aem-code-sync bot commented May 10, 2024 •

edited

Loading

mokimo commented May 10, 2024 •

edited

Loading

codecov bot commented May 14, 2024 •

edited

Loading