Container PR for initial TWP features (WIP) #2344
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* MWPW-136871: TwP Merch Card * unit tests
* add draft for a merch-twp block --------- Co-authored-by: Axel Cureno Basurto <[email protected]>
* MWPW-136871: TwP Merch Card * unit tests * twp card * price display in TwP * deps update
* MWPW-136871: TwP Merch Card * unit tests * twp card * price display in TwP * deps update
Merging proactively for a GWP demo.
yesil
added
high-impact
* MWPW-144254 [merch-card] per type heading map * optional chaining
Fixes multiple Mini Compare Chart card alignment and spacing issues. Resolves: MWPW-142003 Note: Alignment across cards will show broken in test URL because prices are not resolved due to CORS policy. To properly test alignment, please use this URL: https://main--cc--adobecom.hlx.page/drafts/axel/mini-compare-chart-edgecase?milolibs=MWPW-142003--milo--axelcureno Test URLs: Before: https://main--milo--axelcureno.hlx.page/drafts/axel/mini-compare-chart?martech=off After: https://mwpw-142003--milo--axelcureno.hlx.page/drafts/axel/mini-compare-chart?martech=off Co-authored-by: ilyas Stéphane Türkben <[email protected]>
* MWPW-135160: Mnemonics inside merch card * Update merch-card.js --------- Co-authored-by: Blaine Gunn <[email protected]>
|
This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR. |
|
|
This will need to be rebased from #2347 once merged. |
|
This PR has not been updated recently and will be closed in 7 days if no action is taken. Please ensure all checks are passing, https://github.com/orgs/adobecom/discussions/997 provides instructions. If the PR is ready to be merged, please mark it with the "Ready for Stage" label. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes some work-in-progress changes for the upcoming TWP features to stay aligned with the latest updates in the stage branch and the forthcoming changes in the Milo catalog page.
Resolves:
Test URLs: