quiz entry block - fix for content disappearing before redirect #2348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* bug fix for content flicker before redirect * bug fix for debug mode where you cannot continue more than once Resolves: [MWPW-149356](https://jira.corp.adobe.com/browse/MWPW-149356) **Test URLs:** - Before: https://main--milo--adobecom.hlx.page/?martech=off - After: https://<branch>--milo--adobecom.hlx.page/?martech=off
|
fullcolorcoder
approved these changes
May 21, 2024
Blainegunn
approved these changes
May 21, 2024
JackySun9
approved these changes
May 21, 2024
JackySun9
added
verified
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: MWPW-149356
Test URLs:
Testing notes: To test the flicker and the fix, turn bandwidth throttling down in dev tools. Make a selection and press continue. Before, the content would disappear just before the page redirects to the quiz page. After, the content persists until the redirect happens.
To test the debug mode fix, add the debug=quiz-entry query param and make a selection and press continue. Alter your selection and press continue again. Before, it would throw a script error. After the script error is no longer present and your new selection logging works as expected.