-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MWPW-149470[MILO][MEP] Remove sendTargetResponseAnalytics function #2371
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #2371 +/- ##
==========================================
- Coverage 95.65% 95.64% -0.01%
==========================================
Files 173 173
Lines 45165 45165
==========================================
- Hits 43204 43200 -4
- Misses 1961 1965 +4 ☔ View full report in Codecov by Sentry. |
This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR. |
This PR has not been updated recently and will be closed in 7 days if no action is taken. Please ensure all checks are passing, https://github.com/orgs/adobecom/discussions/997 provides instructions. If the PR is ready to be merged, please mark it with the "Ready for Stage" label. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@markpadbe There are conflicts with Stage, can you please look into that?
Remove function temporarily added to collect analytics data
to check the effect of the code change, filter the network tab for the word "collect". The current code sends an event with the timeout information. The new code does not.
Resolves: MWPW-149470
Test URLs: