Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MWPW-146681 - [LocUI] sidekick integration #2417

Merged
merged 6 commits into from
Jun 12, 2024

Conversation

Sartxi
Copy link
Contributor

@Sartxi Sartxi commented Jun 4, 2024

In LocUI you have to refresh the page after opening and signing into sidekick to load the project details. Interfacing with AEM sidekick custom events to ensure users have opened and signed in before loading project details should help alleviate this frustrating user experience.

Screenshot 2024-06-04 at 1 26 45 PM

Resolves: MWPW-146681

Test URLs:
https://sean-loc--milo--adobecom.hlx.page/tools/loc?ref=main&repo=milo&owner=adobecom&host=milo.adobe.com&project=Milo&referrer=https%3A%2F%2Fadobe.sharepoint.com%2F%3Ax%3A%2Fr%2Fsites%2Fadobecom%2F_layouts%2F15%2FDoc.aspx%3Fsourcedoc%3D%257B9d18baeb-24a4-4524-8c44-4c074b265c6b%257D%26action%3Deditnew

@Sartxi Sartxi added new-feature New block or other feature zero-impact labels Jun 4, 2024
@Sartxi Sartxi requested a review from auniverseaway June 4, 2024 19:30
@Sartxi Sartxi requested a review from a team as a code owner June 4, 2024 19:30
Copy link
Contributor

aem-code-sync bot commented Jun 4, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link

codecov bot commented Jun 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.67%. Comparing base (3a137ca) to head (20a51ac).
Report is 766 commits behind head on locui.

Additional details and impacted files
@@            Coverage Diff             @@
##            locui    #2417      +/-   ##
==========================================
- Coverage   96.20%   95.67%   -0.54%     
==========================================
  Files         135      165      +30     
  Lines       33267    43538   +10271     
==========================================
+ Hits        32006    41655    +9649     
- Misses       1261     1883     +622     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Sartxi Sartxi merged commit daa9da7 into locui Jun 12, 2024
10 of 12 checks passed
@Sartxi Sartxi deleted the sartxi/locui-integrate-sidekick branch June 12, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-feature New block or other feature zero-impact
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants