Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release] Stage to Main #2495

Merged
merged 3 commits into from
Jun 24, 2024
Merged

[Release] Stage to Main #2495

merged 3 commits into from
Jun 24, 2024

Conversation

@milo-pr-merge
Copy link
Contributor Author

milo-pr-merge bot commented Jun 20, 2024

Testing can start @adobecom/miq-sot @adobecom/bacom-sot @adobecom/homepage-sot @adobecom/creative-cloud-sot @adobecom/document-cloud-sot

@milo-pr-merge milo-pr-merge bot requested a review from a team as a code owner June 20, 2024 09:15
Copy link
Contributor

aem-code-sync bot commented Jun 20, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link
Contributor

aem-code-sync bot commented Jun 20, 2024

Page Scores Audits Google
/?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link

codecov bot commented Jun 20, 2024

Codecov Report

Attention: Patch coverage is 90.90909% with 5 lines in your changes missing coverage. Please review.

Project coverage is 95.77%. Comparing base (75fe20d) to head (5ad4b21).
Report is 12 commits behind head on main.

Files Patch % Lines
...bs/blocks/global-navigation/utilities/utilities.js 84.37% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2495      +/-   ##
==========================================
+ Coverage   95.73%   95.77%   +0.03%     
==========================================
  Files         175      175              
  Lines       45890    45913      +23     
==========================================
+ Hits        43934    43972      +38     
+ Misses       1956     1941      -15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…rors (#2402)

* Add missing LANA logs for import and fetch

* Added lana logs

* fix lint issues

* Fix review comments

* Fix eslint issues

* Fix Review comment

* Fix lint issue

* Fix review comments

* Update UT for the changes

* Fix lint
…ll variations) (#2459)

* descreased strikethrough price font size

* use milo style variable for font size

---------

Co-authored-by: Ilyas Stéphane Türkben <[email protected]>
@milo-pr-merge milo-pr-merge bot requested a review from a team as a code owner June 20, 2024 12:16
@JackySun9 JackySun9 added the run-nala Run Nala Test Automation against PR label Jun 20, 2024
@milo-pr-merge milo-pr-merge bot merged commit 47aaef0 into main Jun 24, 2024
72 of 73 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants