[Release] Stage to Main #2641
Merged
[Release] Stage to Main #2641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![milo-pr-merge[bot]](https://avatars.githubusercontent.com/u/95242840?s=60&v=4){kind=small}
…nav (#2538) * Remove condition for promobar hidden on mobile from gnav * Fix lint and UT * Adjust height for feds promobar * brnach banner not shown in case feds promobar is present * Add UT for promobar hide/show on mobile * Lint Fix * Removed condition for on and off feds promobar on mobile to avoid CLS issue * Remove UT changes not needed now * fixed mega menu height if promobar is present * Fix review comments * Fix megamenu scroll issue * reverted condition * remove flex wrap * add initial visibility hidden for gnav --------- Co-authored-by: nishantka <[email protected]>
…ch card] (#2613) * MWPW-147907: Allow for 24pt font size for price [Merch Card] * merch-card dependency consumption * Update merch-card.js * Update merch-card.js * Update merch-card.js
remove height auto to test CLS issue Co-authored-by: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com>
|
Testing can start @adobecom/miq-sot @adobecom/bacom-sot @adobecom/homepage-sot @adobecom/creative-cloud-sot @adobecom/document-cloud-sot |
milo-pr-merge
bot
requested review from
ryanmparrish,
Sartxi,
auniverseaway,
salonijain3,
bandana147,
sharmrj,
nishantka,
Deva309 and
sonawanesnehal3
as code owners
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2641 +/- ##
==========================================
- Coverage 95.70% 95.69% -0.02%
==========================================
Files 172 172
Lines 45362 45379 +17
==========================================
+ Hits 43413 43424 +11
- Misses 1949 1955 +6 ☔ View full report in Codecov by Sentry. |
…ection is added (#2628) * milo libs copied with local changes. Code updated to create only single callout-text slot * merch-card copied from mas repo * replaced merch-card changes * lean up * replace merch-card from main --------- Co-authored-by: Rohit Sahu <[email protected]>
* Add Opt-In Feature for CaaS Badge Display * Updates for unit tests --------- Co-authored-by: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com>
make graybox urls environment aware
JackySun9
approved these changes
Jul 29, 2024
Dli3
approved these changes
Jul 29, 2024
Roycethan
approved these changes
Jul 29, 2024
sigadamvenkata
approved these changes
Jul 30, 2024
sigadamvenkata
temporarily deployed
to
milo_pr_merge
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
common base root URLs
Homepage : https://www.stage.adobe.com/
BACOM: https://business.stage.adobe.com/fr/
CC: https://www.stage.adobe.com/creativecloud.html
Blog: https://blog.stage.adobe.com/
Acrobat: https://www.stage.adobe.com/acrobat/online/sign-pdf.html
Milo: