[Release] Stage to Main #2716
Merged
[Release] Stage to Main #2716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![milo-pr-merge[bot]](https://avatars.githubusercontent.com/u/95242840?s=60&v=4){kind=small}
* Adding configuration for header component * Adding test cases * Adding css changes * Updated for css * Setting the origin to federal * Removing promise array * Adding redirect uri in meta * Updating meta insert function * Lint fix * Making error message descriptive --------- Co-authored-by: Snehal Sonawane <[email protected]>
|
Testing can start @adobecom/miq-sot @adobecom/bacom-sot @adobecom/homepage-sot @adobecom/creative-cloud-sot @adobecom/document-cloud-sot |
milo-pr-merge
bot
requested review from
salonijain3,
bandana147,
sharmrj,
nishantka,
Deva309,
sonawanesnehal3,
fullcolorcoder,
ryanmparrish and
a team
as code owners
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| const branch = new URLSearchParams(window.location.search).get('navbranch'); | ||
| const miloLibs = branch ? `https://${branch}--milo--adobecom.hlx.page` : customLib || envMap[env]; | ||
|
|
||
| if (!header && !footer) { | ||
| console.error('Global navigation Error: header and footer configurations are missing.'); |
There was a problem hiding this comment.
Unexpected console statement.
There was a problem hiding this comment.
for this one, we should use lana, right?
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2716 +/- ##
=======================================
Coverage 95.74% 95.75%
=======================================
Files 173 173
Lines 45600 45656 +56
=======================================
+ Hits 43661 43717 +56
Misses 1939 1939 ☔ View full report in Codecov by Sentry. |
Dli3
approved these changes
Aug 8, 2024
tedAir
approved these changes
Aug 9, 2024
Roycethan
approved these changes
Aug 9, 2024
sigadamvenkata
approved these changes
Aug 12, 2024
sigadamvenkata
temporarily deployed
to
milo_pr_merge
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
common base root URLs
Homepage : https://www.stage.adobe.com/
BACOM: https://business.stage.adobe.com/fr/
CC: https://www.stage.adobe.com/creativecloud.html
Blog: https://blog.stage.adobe.com/
Acrobat: https://www.stage.adobe.com/acrobat/online/sign-pdf.html
Milo: