MWPW-156612 fragment merch-card variant layouts #2810

npeltier · 2024-08-30T21:48:52Z

move from merch-card.js code each layout code related to a given variant under variants/variant class
move from global.css.js css related to a given variant under variants/variant.css.js
move from merch-card.css.js wc css related to a given variant under variants/variant.variantStyle
uses variants/variants as an index to get related class from related variant, and wc style too,
uses variants/VariantLayout, superclass of all variants, to insert css if card is used, and hold common code

Resolves: https://jira.corp.adobe.com/browse/MWPW-156612

Test URLs:

tested kitchen sink with consolidated style in one tag done before first card is even parsed https://test-consolidate--milo--npeltier.hlx.live/docs/library/kitchen-sink/merch-card?martech=off&georouting=off but does not look like it greatly improves TBT

aem-code-sync · 2024-08-30T21:49:07Z

	Page	Scores	Audits	Google
M	/docs/library/kitchen-sink/merch-card?martech=off&georouting=off
D	/docs/library/kitchen-sink/merch-card?martech=off&georouting=off
M	/?martech=off
D	/?martech=off

npeltier · 2024-08-30T21:55:26Z

will probably need to wait for #2798 but reviews can start

- move from merch-card.js code each layout code related to a given variant under variants/<variant> class - move from global.css.js css related to a given variant under variants/<variant>.css.js - move from merch-card.css.js wc css related to a given variant under variants/<variant>.variantStyle - uses variants/variants as an index to get related class from related variant, and wc style too, - uses variants/VariantLayout, superclass of all variants, to insert css if card is used, and hold common code

github-actions · 2024-08-31T01:23:22Z

This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR.

npeltier · 2024-08-31T09:35:07Z

(i also need to check why TBT is increased)

codecov · 2024-08-31T09:35:07Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.22%. Comparing base (4a4a12e) to head (cf2bd34).
Report is 7 commits behind head on stage.

Additional details and impacted files

@@            Coverage Diff             @@
##            stage    #2810      +/-   ##
==========================================
+ Coverage   96.18%   96.22%   +0.04%     
==========================================
  Files         215      237      +22     
  Lines       53969    54231     +262     
==========================================
+ Hits        51909    52185     +276     
+ Misses       2060     2046      -14

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

to something independent of the layout (not initialized when used at first in collections)

narcis-radu · 2024-09-03T06:36:11Z

libs/deps/mas/merch-card.js

-            <footer><slot name="footer"></slot></footer>
-            ${this.defaultSlot}
-        </div>`}connectedCallback(){super.connectedCallback(),this.#e=this.getContainer(),this.setAttribute("tabindex",this.getAttribute("tabindex")??"0"),this.addEventListener("mouseleave",this.toggleActionMenu),this.addEventListener(k,this.handleQuantitySelection),this.addEventListener(_,this.merchCardReady,{once:!0}),this.updateComplete.then(()=>{this.merchCardReady()}),this.storageOptions?.addEventListener("change",this.handleStorageChange)}disconnectedCallback(){super.disconnectedCallback(),this.removeEventListener(k,this.handleQuantitySelection),this.storageOptions?.removeEventListener(C,this.handleStorageChange)}appendInvisibleSpacesToFooterLinks(){[...this.querySelectorAll('[slot="footer"] a')].forEach(e=>{L(e).forEach(r=>{let i=r.textContent.split(" ").map(u=>u.match(/.{1,7}/g)?.join("\u200B")).join(" ");r.textContent=i})})}updateMiniCompareElementMinHeight(e,t){let r=`--consonant-merch-card-mini-compare-${t}-height`,n=Math.max(0,parseInt(window.getComputedStyle(e).height)||0),a=parseInt(this.#e.style.getPropertyValue(r))||0;n>a&&this.#e.style.setProperty(r,`${n}px`)}async adjustTitleWidth(){if(!["segment","plans"].includes(this.variant))return;let e=this.getBoundingClientRect().width,t=this.badgeElement?.getBoundingClientRect().width||0;e===0||t===0||this.style.setProperty("--consonant-merch-card-heading-xs-max-width",`${Math.round(e-t-16)}px`)}async adjustMiniCompareBodySlots(){if(this.variant!==E||this.getBoundingClientRect().width===0)return;this.updateMiniCompareElementMinHeight(this.shadowRoot.querySelector(".top-section"),"top-section"),["heading-m","body-m","heading-m-price","price-commitment","offers","promo-text","callout-content","secure-transaction-label"].forEach(r=>this.updateMiniCompareElementMinHeight(this.shadowRoot.querySelector(`slot[name="${r}"]`),r)),this.updateMiniCompareElementMinHeight(this.shadowRoot.querySelector("footer"),"footer");let t=this.shadowRoot.querySelector(".mini-compare-chart-badge");t&&t.textContent!==""&&this.#e.style.setProperty("--consonant-merch-card-mini-compare-top-section-mobile-height","32px")}adjustMiniCompareFooterRows(){if(this.variant!==E||this.getBoundingClientRect().width===0)return;[...this.querySelector('[slot="footer-rows"]').children].forEach((t,r)=>{let n=Math.max(Z,parseInt(window.getComputedStyle(t).height)||0),a=parseInt(this.#e.style.getPropertyValue(j(r+1)))||0;n>a&&this.#e.style.setProperty(j(r+1),`${n}px`)})}removeEmptyRows(){if(this.variant!==E)return;this.querySelectorAll(".footer-row-cell").forEach(t=>{let r=t.querySelector(".footer-row-cell-description");r&&!r.textContent.trim()&&t.remove()})}get storageOptions(){return this.querySelector("sp-radio-group#storage")}get storageSpecificOfferSelect(){let e=this.storageOptions?.selected;if(e){let t=this.querySelector(`merch-offer-select[storage="${e}"]`);if(t)return t}return this.querySelector("merch-offer-select")}get offerSelect(){return this.storageOptions?this.storageSpecificOfferSelect:this.querySelector("merch-offer-select")}get quantitySelect(){return this.querySelector("merch-quantity-select")}merchCardReady(){this.offerSelect&&!this.offerSelect.planType||this.dispatchEvent(new CustomEvent(M,{bubbles:!0}))}handleStorageChange(){let e=this.closest("merch-card")?.offerSelect.cloneNode(!0);e&&this.dispatchEvent(new CustomEvent(C,{detail:{offerSelect:e},bubbles:!0}))}get dynamicPrice(){return this.querySelector('[slot="price"]')}selectMerchOffer(e){if(e===this.merchOffer)return;this.merchOffer=e;let t=this.dynamicPrice;if(e.price&&t){let r=e.price.cloneNode(!0);t.onceSettled?t.onceSettled().then(()=>{t.replaceWith(r)}):t.replaceWith(r)}}};customElements.define(g,p);
+`;document.head.appendChild(bt);var s="merch-card",i=class extends Nt{static properties={name:{type:String,attribute:"name",reflect:!0},variant:{type:String,reflect:!0},size:{type:String,attribute:"size",reflect:!0},badgeColor:{type:String,attribute:"badge-color"},borderColor:{type:String,attribute:"border-color"},badgeBackgroundColor:{type:String,attribute:"badge-background-color"},badgeText:{type:String,attribute:"badge-text"},actionMenu:{type:Boolean,attribute:"action-menu"},actionMenuContent:{type:String,attribute:"action-menu-content"},customHr:{type:Boolean,attribute:"custom-hr"},detailBg:{type:String,attribute:"detail-bg"},secureLabel:{type:String,attribute:"secure-label"},checkboxLabel:{type:String,attribute:"checkbox-label"},selected:{type:Boolean,attribute:"aria-selected",reflect:!0},storageOption:{type:String,attribute:"storage",reflect:!0},stockOfferOsis:{type:Object,attribute:"stock-offer-osis",converter:{fromAttribute:t=>{let[e,r,n]=t.split(",");return{PUF:e,ABM:r,M2M:n}}}},filters:{type:String,reflect:!0,converter:{fromAttribute:t=>Object.fromEntries(t.split(",").map(e=>{let[r,n,d]=e.split(":"),u=Number(n);return[r,{order:isNaN(u)?void 0:u,size:d}]})),toAttribute:t=>Object.entries(t).map(([e,{order:r,size:n}])=>[e,r,n].filter(d=>d!=null).join(":")).join(",")}},types:{type:String,attribute:"types",reflect:!0},merchOffer:{type:Object}};static styles=[ot,vt(),...nt()];customerSegment;marketSegment;variantLayout;constructor(){super(),this.filters={},this.types="",this.selected=!1}updated(t){(t.has("badgeBackgroundColor")||t.has("borderColor"))&&(this.style.border=this.computedBorderStyle),this.updateComplete.then(async()=>{let r=Array.from(this.querySelectorAll('span[is="inline-price"][data-wcs-osi]')).filter(n=>!n.closest('[slot="callout-content"]'));await Promise.all(r.map(n=>n.onceSettled())),this.variantLayout.postCardUpdateHook(this)})}render(){if(!(!this.isConnected||this.style.display==="none"))return this.variantLayout.renderLayout()}get computedBorderStyle(){return this.variant!=="twp"?`1px solid ${this.borderColor?this.borderColor:this.badgeBackgroundColor}`:""}get badgeElement(){return this.shadowRoot.getElementById("badge")}get headingmMSlot(){return this.shadowRoot.querySelector('slot[name="heading-m"]').assignedElements()[0]}get footerSlot(){return this.shadowRoot.querySelector('slot[name="footer"]')?.assignedElements()[0]}get price(){return this.headingmMSlot?.querySelector('span[is="inline-price"]')}get checkoutLinks(){return[...this.footerSlot?.querySelectorAll('a[is="checkout-link"]')??[]]}async toggleStockOffer({target:t}){if(!this.stockOfferOsis)return;let e=this.checkoutLinks;if(e.length!==0)for(let r of e){await r.onceSettled();let n=r.value?.[0]?.planType;if(!n)return;let d=this.stockOfferOsis[n];if(!d)return;let u=r.dataset.wcsOsi.split(",").filter(v=>v!==d);t.checked&&u.push(d),r.dataset.wcsOsi=u.join(",")}}handleQuantitySelection(t){let e=this.checkoutLinks;for(let r of e)r.dataset.quantity=t.detail.option}get titleElement(){return this.querySelector(".card-heading")}get title(){return this.titleElement?.textContent?.trim()}get description(){return this.querySelector('[slot="body-xs"]')?.textContent?.trim()}updateFilters(t){let e={...this.filters};Object.keys(e).forEach(r=>{if(t){e[r].order=Math.min(e[r].order||2,2);return}let n=e[r].order;n===1||isNaN(n)||(e[r].order=Number(n)+1)}),this.filters=e}includes(t){return this.textContent.match(new RegExp(t,"i"))!==null}get startingAt(){return this.classList.contains("starting-at")}get defaultSlot(){return this.querySelector(":scope > a:not([slot]),:scope > p:not([slot]),:scope > div:not([slot]),:scope > span:not([slot])")?Pt`<slot></slot>`:Dt}connectedCallback(){super.connectedCallback(),this.variantLayout=xt(this),this.variantLayout.connectedCallbackHook(),this.setAttribute("tabindex",this.getAttribute("tabindex")??"0"),this.addEventListener(N,this.handleQuantitySelection),this.addEventListener(W,this.merchCardReady,{once:!0}),this.updateComplete.then(()=>{this.merchCardReady()}),this.storageOptions?.addEventListener("change",this.handleStorageChange)}disconnectedCallback(){super.disconnectedCallback(),this.variantLayout.disconnectedCallbackHook(),this.removeEventListener(N,this.handleQuantitySelection),this.storageOptions?.removeEventListener(P,this.handleStorageChange)}appendInvisibleSpacesToFooterLinks(){[...this.querySelectorAll('[slot="footer"] a')].forEach(t=>{Z(t).forEach(r=>{let u=r.textContent.split(" ").map(v=>v.match(/.{1,7}/g)?.join("\u200B")).join(" ");r.textContent=u})})}get storageOptions(){return this.querySelector("sp-radio-group#storage")}get storageSpecificOfferSelect(){let t=this.storageOptions?.selected;if(t){let e=this.querySelector(`merch-offer-select[storage="${t}"]`);if(e)return e}return this.querySelector("merch-offer-select")}get offerSelect(){return this.storageOptions?this.storageSpecificOfferSelect:this.querySelector("merch-offer-select")}get quantitySelect(){return this.querySelector("merch-quantity-select")}merchCardReady(){this.offerSelect&&!this.offerSelect.planType||this.dispatchEvent(new CustomEvent(Y,{bubbles:!0}))}handleStorageChange(){let t=this.closest("merch-card")?.offerSelect.cloneNode(!0);t&&this.dispatchEvent(new CustomEvent(P,{detail:{offerSelect:t},bubbles:!0}))}get dynamicPrice(){return this.querySelector('[slot="price"]')}selectMerchOffer(t){if(t===this.merchOffer)return;this.merchOffer=t;let e=this.dynamicPrice;if(t.price&&e){let r=t.price.cloneNode(!0);e.onceSettled?e.onceSettled().then(()=>{e.replaceWith(r)}):e.replaceWith(r)}}};customElements.define(s,i);
 //# sourceMappingURL=merch-card.js.map


nit: let's remove the source maps please

i'll merge @yesil 's PR that does that, but yes

narcis-radu · 2024-09-03T07:03:44Z

libs/features/mas/web-components/src/variants/mini-compare-chart.js

+  adjustMiniCompareFooterRows () {
+    if (this.card.getBoundingClientRect().width === 0) return;
+    const footerRows = this.card.querySelector('[slot="footer-rows"]');
+    [...footerRows.children].forEach((el, index) => {


nit: might be safer to use ...footerRows?.children to avoid situations where the footer-rows element is not available.

narcis-radu · 2024-09-03T07:10:08Z

libs/features/mas/web-components/src/variants/twp.css.js

+  --consonant-merch-card-twp-mobile-height: 358px;
+}
+merch-card[variant="twp"] div[class$='twp-badge'] {
+  padding: 4px 10px 5px 10px;


is RTL covered?

not yet, no this variant is still under dev

libs/features/mas/web-components/src/variants/twp.css.js

narcis-radu · 2024-09-03T07:12:46Z

libs/features/mas/web-components/src/variants/twp.css.js

+  grid-template-columns: var(--consonant-merch-card-image-width);
+}
+
+@media screen and ${DESKTOP_UP} {


I am looking at the order and I think declarations should follow mobile to large desktop or vice versa, however here we have desktop, large desktop, mobile, tablet, which might get confusing at some point when different CSS is added

narcis-radu · 2024-09-03T07:17:21Z

libs/features/mas/web-components/src/variants/variant-layout.js

+
+  insertVariantStyle() {
+    if (!VariantLayout?.styleMap?.[this.card.variant]) {
+      VariantLayout.styleMap[this.card.variant] = true;


this has potential to break; let's say VariantLayout.styleMap is undefined, then your if clause will evaluate to true and it will execute VariantLayout.styleMap[this.card.variant] = true; which will throw an error.

narcis-radu · 2024-09-03T07:18:30Z

libs/features/mas/web-components/src/variants/variant-layout.js

+  }
+
+  postCardUpdateHook() {
+    //nothing to do by default


are these methods still needed then?

this is mother class VariantLayout, this method does not do anything by default but can be overriden (check MiniPlansCompareChart & Segment layout inheriting from it)

Axelcureno · 2024-09-09T16:52:58Z

libs/features/mas/web-components/src/merch-card.js

@@ -716,6 +297,28 @@ export class MerchCard extends LitElement {
        );
    }

+    toggleActionMenu(e) {


This method is only applicable to catalog card. I wonder if it should be moved to catalog.js?

had some issues there but you are right, i'll try again :)

Axelcureno · 2024-09-09T16:54:32Z

libs/features/mas/web-components/src/variants/catalog.css.js

+@media screen and ${DESKTOP_UP} {
+    :root {
+      --consonant-merch-card-catalog-width: 276px;
+    }


nit: add missing line

Axelcureno · 2024-09-09T16:56:00Z

libs/features/mas/web-components/src/variants/image.css.js

+@media screen and ${DESKTOP_UP} {
+  :root {
+    --consonant-merch-card-image-width: 378px;
+  }


nit: add missing line

libs/features/mas/web-components/src/variants/plans.js

Axelcureno · 2024-09-09T17:04:10Z

libs/features/mas/web-components/src/variants/product.css.js

+@media screen and ${DESKTOP_UP} {
+  :root {
+    --consonant-merch-card-product-width: 378px;
+  }


nit: add missing line

Axelcureno · 2024-09-09T17:04:52Z

libs/features/mas/web-components/src/variants/segment.css.js

+@media screen and ${TABLET_UP} {
+  :root {
+    --consonant-merch-card-segment-width: 276px;
+  }


nit: add missing line

Axelcureno · 2024-09-09T17:06:38Z

libs/features/mas/web-components/src/variants/special-offer.css.js

+@media screen and ${TABLET_UP} {
+  :root {
+    --consonant-merch-card-special-offers-width: 302px;
+  }


nit: add missing line

Axelcureno · 2024-09-09T17:07:00Z

libs/features/mas/web-components/src/variants/special-offer.js

+  static variantStyle = css`
+    :host([variant='special-offers']) {
+      min-height: 439px;
+    }


nit: add missing line

Axelcureno · 2024-09-09T17:07:37Z

libs/features/mas/web-components/src/variants/twp.css.js

+  --consonant-merch-card-twp-width: 268px;
+  --consonant-merch-card-twp-mobile-width: 300px;
+  --consonant-merch-card-twp-mobile-height: 358px;
+}


nit: add missing line

Axelcureno · 2024-09-09T17:08:14Z

libs/features/mas/web-components/src/variants/twp.css.js

+        grid-template-columns: repeat(2, var(--consonant-merch-card-twp-width));
+    }
+    .three-merch-cards.twp {
+    grid-template-columns: repeat(3, var(--consonant-merch-card-twp-width));


nit: indent line

Axelcureno

Some nits that could be ignored, but this one does need attention:
https://github.com/adobecom/milo/pull/2810/files#r1750613115

afmicka · 2024-09-11T12:40:30Z

@npeltier the style of merch-card with background opacity has changed. Was that intentional?
your branch:

actual:

afmicka · 2024-09-11T12:56:25Z

@npeltier Seeing also differences in width on mobile for special offers cards:
your branch:

actual:

afmicka · 2024-09-11T13:16:00Z

@npeltier the changes are also affecting consumer pages:

BACOM page (turn it into 2 column page).
https://main--bacom--adobecom.hlx.page/products/adobe-experience-cloud-products?milolibs=mwpw-156612--milo--npeltier

should be:

Special offers - images are not aligned int he cards
https://main--cc--adobecom.hlx.page/africa/products/special-offers?milolibs=mwpw-156612--milo--npeltier

Should be:

npeltier · 2024-09-11T17:41:11Z

@afmicka background image, special offers, and bacom page should be fixed now. The width issue on kitchen sink is due to style ordering in case of multiple type of cards inserted in the same section. i'm not sure what we want here & started to discuss this internally.

yesil

Looks like more styles can be moved from global.css.js to the merch-card.css.js and some suggestion on the naming.
Overall it looks good to me, will wait for the comments before approval.

yesil · 2024-09-12T08:58:30Z

libs/features/mas/web-components/src/global.css.js

all the rules like div[slot="footer"] should be movable to merch-card.css.js

sure, i thought we would wait for the move to "optimize" but i'll do that :)

finally, same as for web tests, i'll postpone it as it's not that easy neither :)

yesil · 2024-09-12T09:01:13Z

libs/features/mas/web-components/src/variants/variant-layout.js

+import { html } from 'lit';
+
+export class VariantLayout {
+  static styleMap = {};


nit: I tend to use module scoped variants instead of static members.
Especially if they are meant to be private

yesil · 2024-09-12T09:02:13Z

libs/features/mas/web-components/src/variants/variant-layout.js

+  card;
+
+  insertVariantStyle() {
+    if (!VariantLayout.styleMap[this.card.variant]) {


nit: with above suggestion, it could be written as if (!styleMap[this.card.variant]) {

since we append the style below, I would call the method appendVariantStyles

yesil · 2024-09-12T09:07:16Z

libs/features/mas/web-components/src/variants/variant-layout.js

+
+  constructor(card) {
+    this.card = card;
+    setTimeout(() => this.insertVariantStyle(), 1);


is setTimeout really needed?

i think i did save some TBT with this yes

libs/features/mas/web-components/src/variants/variant-layout.js

yesil · 2024-09-12T09:11:14Z

libs/features/mas/web-components/test/merch-card.catalog.test.html.js

+    await mockFetch(withWcs);
+    await mas();
+    if (skipTests !== null) {
+        appendMiloStyles();


if you feel, remove appendMiloStyles, and maybe reference the styles in question in the test page.

finally someone will do that later, as it's more work than i was expected :) and not directly related to my work

yesil · 2024-09-12T09:14:31Z

libs/features/mas/web-components/src/variants/catalog.js

+
+export class Catalog extends VariantLayout {
+  constructor(card) {
+    super(card);


do we need this constructor?

yes we do! the constructor adds the style if not there

but when you don't declare, it should call the one from VariantLayout no?

i wanted to shout NO, but i tried and yes it works :) sorry to be such a java guy :)

yesil · 2024-09-12T09:15:03Z

libs/features/mas/web-components/src/variants/ccd-action.js

+    super(card);
+  }
+
+  getGlobalCSS() {


suggestion: getGlobalStyles?

libs/features/mas/web-components/src/variants/catalog.js

afmicka · 2024-09-12T11:23:50Z

issues seem fixed. Will mark it verified.
@Roycethan could you please also have a look just in case? If all good on your end, please add Ready for stage.

npeltier · 2024-09-12T13:14:32Z

@afmicka postponed heavy styling changes to later PR (cc @yesil ) so no additional testing on your hand is needed :)
it's all in the hands of @Roycethan now :)

* MWPW-156612 fragment merch-card variant layouts - move from merch-card.js code each layout code related to a given variant under variants/<variant> class - move from global.css.js css related to a given variant under variants/<variant>.css.js - move from merch-card.css.js wc css related to a given variant under variants/<variant>.variantStyle - uses variants/variants as an index to get related class from related variant, and wc style too, - uses variants/VariantLayout, superclass of all variants, to insert css if card is used, and hold common code * MWPW-156612 changing title selector to something independent of the layout (not initialized when used at first in collections) * MWPW-156612 forking style insertion * MWPW-156612 styles fixes * MWPW-156612 review comments * MWPW-156612 fixing unit tests * MWPW-156612 address review comments * MWPW-156612 catalog & image test cov * MWPW-156612 100% coverage for variants * MWPW-156612 fixing (again) ut * MWPW-156612 fix one inline heading style * MWPW-156612 bg img height

npeltier added commerce merch card labels Aug 30, 2024

npeltier requested a review from a team as a code owner August 30, 2024 21:48

npeltier added needs-verification PR requires E2E testing by a reviewer do not merge PR should not be merged yet labels Aug 30, 2024

npeltier force-pushed the MWPW-156612 branch from ba58244 to 03778dd Compare August 30, 2024 22:18

MWPW-156612 changing title selector

7ead9eb

to something independent of the layout (not initialized when used at first in collections)

npeltier force-pushed the MWPW-156612 branch from a4cdcae to 7ead9eb Compare August 31, 2024 15:45

MWPW-156612 forking style insertion

a8ab869

npeltier added the run-nala Run Nala Test Automation against PR label Sep 1, 2024

MWPW-156612 styles fixes

b9580d5

npeltier force-pushed the MWPW-156612 branch from 8b0488e to b9580d5 Compare September 1, 2024 06:57

narcis-radu reviewed Sep 3, 2024

View reviewed changes

MWPW-156612 review comments

6df1623

3ch023 approved these changes Sep 6, 2024

View reviewed changes

npeltier added 2 commits September 7, 2024 07:25

Merge branch 'stage' of github.com:adobecom/milo into MWPW-156612

6c3cb8f

MWPW-156612 fixing unit tests

5ad2935

npeltier removed the do not merge PR should not be merged yet label Sep 9, 2024

Axelcureno reviewed Sep 9, 2024

View reviewed changes

libs/features/mas/web-components/src/variants/plans.js Outdated Show resolved Hide resolved

Axelcureno reviewed Sep 9, 2024

View reviewed changes

libs/features/mas/web-components/src/variants/plans.js Show resolved Hide resolved

Axelcureno reviewed Sep 9, 2024

View reviewed changes

Axelcureno requested changes Sep 9, 2024

View reviewed changes

npeltier added 2 commits September 10, 2024 09:54

MWPW-156612 address review comments

5d1edc6

MWPW-156612 catalog & image test cov

98b1adc

Axelcureno approved these changes Sep 10, 2024

View reviewed changes

npeltier added 3 commits September 11, 2024 11:40

MWPW-156612 100% coverage for variants

7fab0a9

Merge branch 'stage' of github.com:adobecom/milo into MWPW-156612

33ac692

MWPW-156612 fixing (again) ut

d328974

MWPW-156612 fix one inline heading style

0c635a1

npeltier force-pushed the MWPW-156612 branch from 8d29719 to 0c635a1 Compare September 11, 2024 17:14

MWPW-156612 bg img height

cf2bd34

yesil reviewed Sep 12, 2024

View reviewed changes

afmicka added verified PR has been E2E tested by a reviewer and removed needs-verification PR requires E2E testing by a reviewer labels Sep 12, 2024

yesil approved these changes Sep 12, 2024

View reviewed changes

Roycethan added the Ready for Stage label Sep 12, 2024

milo-pr-merge bot merged commit 6fa9558 into adobecom:stage Sep 12, 2024
22 checks passed

milo-pr-merge bot mentioned this pull request Sep 12, 2024

[Release] Stage to Main #2874

Merged

MWPW-156612 fragment merch-card variant layouts #2810

MWPW-156612 fragment merch-card variant layouts #2810

Conversation

npeltier commented Aug 30, 2024 • edited Loading

aem-code-sync bot commented Aug 30, 2024 • edited Loading

npeltier commented Aug 30, 2024

github-actions bot commented Aug 31, 2024

npeltier commented Aug 31, 2024

codecov bot commented Aug 31, 2024 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

npeltier Sep 3, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Axelcureno Sep 9, 2024 • edited Loading

Choose a reason for hiding this comment

Axelcureno left a comment

Choose a reason for hiding this comment

afmicka commented Sep 11, 2024

afmicka commented Sep 11, 2024 • edited Loading

afmicka commented Sep 11, 2024 • edited Loading

npeltier commented Sep 11, 2024

yesil left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

npeltier Sep 12, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

afmicka commented Sep 12, 2024

npeltier commented Sep 12, 2024

npeltier commented Aug 30, 2024 •

edited

Loading

aem-code-sync bot commented Aug 30, 2024 •

edited

Loading

codecov bot commented Aug 31, 2024 •

edited

Loading

npeltier Sep 3, 2024 •

edited

Loading

Axelcureno Sep 9, 2024 •

edited

Loading

afmicka commented Sep 11, 2024 •

edited

Loading

afmicka commented Sep 11, 2024 •

edited

Loading

npeltier Sep 12, 2024 •

edited

Loading