Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update quiz entry code for some localization bugs #2862

Closed
wants to merge 2 commits into from

Conversation

JackySun9
Copy link
Contributor

    1. add local paths for doc file and excels
    1. fix bug for JP - Page jumps, enlarges the cards and duplicates copy
    1. clean up LTRM in URLs

Resolves: MWPW-157450

Test URLs:

How to test?
Pages are in process, not ready to test

@JackySun9 JackySun9 added the do not merge PR should not be merged yet label Sep 10, 2024
Copy link
Contributor

aem-code-sync bot commented Sep 10, 2024

Page Scores Audits Google
📱 /drafts/quiz/quiz-entry/?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /drafts/quiz/quiz-entry/?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@JackySun9 JackySun9 marked this pull request as draft September 10, 2024 20:59
Copy link

codecov bot commented Sep 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.24%. Comparing base (9323f28) to head (ba52918).
Report is 6 commits behind head on stage.

Additional details and impacted files
@@            Coverage Diff             @@
##            stage    #2862      +/-   ##
==========================================
- Coverage   96.24%   96.24%   -0.01%     
==========================================
  Files         237      237              
  Lines       54219    54219              
==========================================
- Hits        52182    52181       -1     
- Misses       2037     2038       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JackySun9 JackySun9 added bug Something isn't working uar labels Sep 10, 2024
@JackySun9 JackySun9 added run-nala Run Nala Test Automation against PR run-nala-on-caas caas-configurator CaaS Configurator and removed bug Something isn't working do not merge PR should not be merged yet uar run-nala-on-caas run-nala Run Nala Test Automation against PR caas-configurator CaaS Configurator labels Sep 18, 2024
@JackySun9 JackySun9 closed this Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run-nala Run Nala Test Automation against PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants