-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MWPW-146354] - Crop issue fixed by adding scroll if geo popup height is more than window height. #2865
Conversation
crop issue fixed by adding scroll if height is less than window height
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #2865 +/- ##
==========================================
- Coverage 96.24% 96.24% -0.01%
==========================================
Files 236 236
Lines 54278 54272 -6
==========================================
- Hits 52241 52234 -7
- Misses 2037 2038 +1 ☔ View full report in Codecov by Sentry. |
@Deva309 validated the PR and observed that the iPhone has been fixed for landscape but in portrait mode its not working; however in both portrait and landscape modes, the drop-down menu is not displaying correctly in ipad. |
Reminder to set the |
This PR has not been updated recently and will be closed in 7 days if no action is taken. Please ensure all checks are passing, https://github.com/orgs/adobecom/discussions/997 provides instructions. If the PR is ready to be merged, please mark it with the "Ready for Stage" label. |
Fix for showing inner popup of geo modal popup always at the top of the button. |
Closing this PR. |
Crop issue fixed by adding scroll if popup height is more than window height.
Before:
After:
Resolves: MWPW-146354
Test URLs:
QA:
https://main--cc--adobecom.hlx.page/drafts/devashish/vh?milolibs=mwpw-146354--milo--deva309