Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MWPW-146354] - Crop issue fixed by adding scroll if geo popup height is more than window height. #2865

Closed
wants to merge 5 commits into from

Conversation

Deva309
Copy link
Contributor

@Deva309 Deva309 commented Sep 11, 2024

Crop issue fixed by adding scroll if popup height is more than window height.

Before:
Screenshot 2024-09-11 at 10 17 23 AM

After:

  1. Content not flowing outside and within scroll
Screenshot 2024-09-11 at 10 24 35 AM
  1. with scroll
Screenshot 2024-09-11 at 10 22 18 AM

Resolves: MWPW-146354

Test URLs:

QA:

https://main--cc--adobecom.hlx.page/drafts/devashish/vh?milolibs=mwpw-146354--milo--deva309

crop issue fixed by adding scroll if height is less than window height
@Deva309 Deva309 requested a review from a team as a code owner September 11, 2024 05:02
Copy link
Contributor

aem-code-sync bot commented Sep 11, 2024

Page Scores Audits Google
📱 /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link

codecov bot commented Sep 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.24%. Comparing base (1791eb8) to head (8f25d64).

Additional details and impacted files
@@            Coverage Diff             @@
##            stage    #2865      +/-   ##
==========================================
- Coverage   96.24%   96.24%   -0.01%     
==========================================
  Files         236      236              
  Lines       54278    54272       -6     
==========================================
- Hits        52241    52234       -7     
- Misses       2037     2038       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Deva309 Deva309 changed the title [MWPW-146354] - Crop issue fixed by adding scroll if popup height is more than window height. [MWPW-146354] - Crop issue fixed by adding scroll if geo popup height is more than window height. Sep 11, 2024
@prativas22
Copy link

prativas22 commented Sep 11, 2024

@Deva309 validated the PR and observed that the iPhone has been fixed for landscape but in portrait mode its not working; however in both portrait and landscape modes, the drop-down menu is not displaying correctly in ipad.
Ipad:
image
image

Iphone:
image

landscape:
image
image

Copy link
Contributor

Reminder to set the Ready for Stage label - to queue this to get merged to stage & production.

Copy link
Contributor

This PR has not been updated recently and will be closed in 7 days if no action is taken. Please ensure all checks are passing, https://github.com/orgs/adobecom/discussions/997 provides instructions. If the PR is ready to be merged, please mark it with the "Ready for Stage" label.

@github-actions github-actions bot added the Stale label Sep 20, 2024
@Deva309
Copy link
Contributor Author

Deva309 commented Sep 20, 2024

Fix for showing inner popup of geo modal popup always at the top of the button.
This fix we need to support all the devices to have common behaviour of geo popup modal without any content cropping.
Please refer below github discussion:
https://github.com/orgs/adobecom/discussions/2895

@Deva309
Copy link
Contributor Author

Deva309 commented Sep 23, 2024

Closing this PR.
We will again think on the better solution.

@Deva309 Deva309 closed this Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants