-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Release] Stage to Main #2868
[Release] Stage to Main #2868
Conversation
* moved merch-card class toggling to other methods * added unit test for merch card collection on phones & tablets * added unit test for closing the filters modal * corrected lit import for merch sidenav
* MWPW-157210 STE Promo card not appearing * MWPW-157210 STE Promo card not appearing * MWPW-157210 STE Promo card not appearing * Trigger Build --------- Co-authored-by: Bozo Jovicic <[email protected]>
* add ol, ul and li * add unit test
Testing can start @adobecom/miq-sot @adobecom/bacom-sot @adobecom/homepage-sot @adobecom/creative-cloud-sot @adobecom/document-cloud-sot |
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2868 +/- ##
==========================================
+ Coverage 96.09% 96.18% +0.08%
==========================================
Files 215 215
Lines 53954 53994 +40
==========================================
+ Hits 51849 51933 +84
+ Misses 2105 2061 -44 ☔ View full report in Codecov by Sentry. |
* environment aware urls * added domains map entry for testing * fixed unit tests * hotfix * moved the convert urls logic to a separate function * added early returns * hotfix * relative urls unit tests * removed fork domain --------- Co-authored-by: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com>
…ot seen in windows (#2866) * Made the pep close button focus a consistent color * update franklin cache with dummy change * revert previous change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@robert-bogos I see this error on bunch of pages when launching TWP i-frame (Click on Free-trial CTA's to launch the modal) (Only at first load empty cache - mac-Safari ), Plz review ot before merge once ...possibly related to #2834 -
Ex: https://www.stage.adobe.com/creativecloud.html#marquee-cta-twp
In above url the I-frame h-ref is https://www.adobe.com/mini-plans/creativecloud.html?mid=ft&web=1
Hi @Roycethan ! |
@yesil as you asked attaching HAR saved at error - attaching as txt file for git support cc @robert-bogos |
Thanks @robert-bogos will approve and we will have it looked separately |
common base root URLs
Homepage : https://www.stage.adobe.com/
BACOM: https://business.stage.adobe.com/fr/
CC: https://www.stage.adobe.com/creativecloud.html
Blog: https://blog.stage.adobe.com/
Acrobat: https://www.stage.adobe.com/acrobat/online/sign-pdf.html
Milo: