Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release] Stage to Main #2868

Merged
merged 7 commits into from
Sep 12, 2024
Merged

[Release] Stage to Main #2868

merged 7 commits into from
Sep 12, 2024

Conversation

mirafedas and others added 4 commits September 11, 2024 09:16
* moved merch-card class toggling to other methods

* added unit test for merch card collection on phones & tablets

* added unit test for closing the filters modal

* corrected lit import for merch sidenav
* MWPW-157210 STE Promo card not appearing

* MWPW-157210 STE Promo card not appearing

* MWPW-157210 STE Promo card not appearing

* Trigger Build

---------

Co-authored-by: Bozo Jovicic <[email protected]>
@milo-pr-merge
Copy link
Contributor Author

milo-pr-merge bot commented Sep 11, 2024

Testing can start @adobecom/miq-sot @adobecom/bacom-sot @adobecom/homepage-sot @adobecom/creative-cloud-sot @adobecom/document-cloud-sot

@milo-pr-merge milo-pr-merge bot requested review from a team as code owners September 11, 2024 09:16
Copy link
Contributor

aem-code-sync bot commented Sep 11, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link
Contributor

aem-code-sync bot commented Sep 11, 2024

Page Scores Audits Google
M /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
D /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

Copy link

codecov bot commented Sep 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.18%. Comparing base (3fd877c) to head (3679fd0).
Report is 53 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2868      +/-   ##
==========================================
+ Coverage   96.09%   96.18%   +0.08%     
==========================================
  Files         215      215              
  Lines       53954    53994      +40     
==========================================
+ Hits        51849    51933      +84     
+ Misses       2105     2061      -44     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

* environment aware urls

* added domains map entry for testing

* fixed unit tests

* hotfix

* moved the convert urls logic to a separate function

* added early returns

* hotfix

* relative urls unit tests

* removed fork domain

---------

Co-authored-by: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com>
…ot seen in windows (#2866)

* Made the pep close button focus a consistent color

* update franklin cache with dummy change

* revert previous change
@JackySun9 JackySun9 added run-nala Run Nala Test Automation against PR run-nala-on-caas labels Sep 11, 2024
Copy link

@Roycethan Roycethan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@robert-bogos I see this error on bunch of pages when launching TWP i-frame (Click on Free-trial CTA's to launch the modal) (Only at first load empty cache - mac-Safari ), Plz review ot before merge once ...possibly related to #2834 -
Ex: https://www.stage.adobe.com/creativecloud.html#marquee-cta-twp
In above url the I-frame h-ref is https://www.adobe.com/mini-plans/creativecloud.html?mid=ft&web=1
image

cc @Axelcureno @npeltier @mokimo @overmyheadandbody

@robert-bogos
Copy link
Contributor

robert-bogos commented Sep 12, 2024

@robert-bogos I see this error on bunch of pages when launching TWP i-frame (Click on Free-trial CTA's to launch the modal) (Only at first load empty cache - mac-Safari ), Plz review ot before merge once ...possibly related to #2834 -
Ex: https://www.stage.adobe.com/creativecloud.html#marquee-cta-twp
In above url the I-frame h-ref is https://www.adobe.com/mini-plans/creativecloud.html?mid=ft&web=1

Hi @Roycethan !
I had a look and is not related to my PR. My code is not even executed in that scenario.
The problem seems to be that the iframe with the www.adobe.com origin is trying to access resources from it's parent page (stage.adobe.com) and running into Same-Origin Policy restrictions.

@Roycethan
Copy link

@robert-bogos I see this error on bunch of pages when launching TWP i-frame (Click on Free-trial CTA's to launch the modal) (Only at first load empty cache - mac-Safari ), Plz review ot before merge once ...possibly related to #2834 -
Ex: https://www.stage.adobe.com/creativecloud.html#marquee-cta-twp
In above url the I-frame h-ref is https://www.adobe.com/mini-plans/creativecloud.html?mid=ft&web=1

Hi @Roycethan ! I had a look and is not related to my PR. My code is not even executed in that scenario. The problem seems to be that the iframe with the www.adobe.com origin is trying to access resources from it's parent page (stage.adobe.com) and running into Same-Origin Policy restrictions.

@yesil as you asked attaching HAR saved at error - attaching as txt file for git support cc @robert-bogos
www.stage.adobe.com.txt

@Roycethan
Copy link

@robert-bogos I see this error on bunch of pages when launching TWP i-frame (Click on Free-trial CTA's to launch the modal) (Only at first load empty cache - mac-Safari ), Plz review ot before merge once ...possibly related to #2834 -
Ex: https://www.stage.adobe.com/creativecloud.html#marquee-cta-twp
In above url the I-frame h-ref is https://www.adobe.com/mini-plans/creativecloud.html?mid=ft&web=1

Hi @Roycethan ! I had a look and is not related to my PR. My code is not even executed in that scenario. The problem seems to be that the iframe with the www.adobe.com origin is trying to access resources from it's parent page (stage.adobe.com) and running into Same-Origin Policy restrictions.

@yesil as you asked attaching HAR saved at error - attaching as txt file for git support cc @robert-bogos www.stage.adobe.com.txt

Thanks @robert-bogos will approve and we will have it looked separately

@tedAir tedAir self-requested a review September 12, 2024 16:59
@milo-pr-merge milo-pr-merge bot merged commit a35fcb3 into main Sep 12, 2024
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.