Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MWPW-154980 - Milo advanced page publishing part 2 #2885

Open
wants to merge 18 commits into
base: stage
Choose a base branch
from

Conversation

Sartxi
Copy link
Contributor

@Sartxi Sartxi commented Sep 16, 2024

This PR is a "part 2" because of a few issues found once the initial PR made it to stage. The disabled button in sidekick was using attribute disabled=false and it caused a problem with publishing in sidekick and we discovered that users can also publish from the preflight dialog.

As a web producer, I want to limit who can publish certain files so that files are not published prematurely before planned launches.

New Feature Includes:

  • Ability to fetch an optional custom configuration file from path .milo/publish-permissions-config to apply advanced publishing rules on a per page basis.
  • New functionality will disable the publish button in AEM sidekick if path matches an item (url pathname) in the configuration file and can also reference a group with optional allow/deny user list which then compares the list to the email of profile that is currently logged into sidekick.
  • Bulk Publish v2 tool will also check paths in the job list for item configuration and refuse to publish urls that have been configured unless of course the currently logged in user has permissions.
  • Preflight will also check for publishing permissions and ignore pages that the current user is not allowed to publish.

Resolves: MWPW-154980

Testing Details:

  1. Sidekick: Go to the test url page -> open sidekick -> verify publish button is disabled.
  2. Bulk Publish Tool: Go to BP Tool -> Publish test page URL -> see error thrown with message.
  3. Preflight: Open page preflight sidekick -> tools -> preflight. Select found URLs and see that the no publish message is showing under published, a tooltip shows on hover of publish button, and all URLs without permissions are ignored on publish.

Test URLs:

@Sartxi Sartxi added the new-feature New block or other feature label Sep 16, 2024
@Sartxi Sartxi requested a review from a team as a code owner September 16, 2024 16:40
Copy link
Contributor

aem-code-sync bot commented Sep 16, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link
Contributor

aem-code-sync bot commented Sep 16, 2024

Copy link

codecov bot commented Sep 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.26%. Comparing base (840e037) to head (57e00ab).
Report is 11 commits behind head on stage.

Additional details and impacted files
@@            Coverage Diff             @@
##            stage    #2885      +/-   ##
==========================================
+ Coverage   96.23%   96.26%   +0.03%     
==========================================
  Files         237      237              
  Lines       54242    54312      +70     
==========================================
+ Hits        52198    52282      +84     
+ Misses       2044     2030      -14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aem-code-sync aem-code-sync bot temporarily deployed to sartxi/MWPW-154980-publishing September 16, 2024 16:56 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to sartxi/MWPW-154980-publishing September 18, 2024 01:01 Inactive
Copy link
Contributor

Reminder to set the Ready for Stage label - to queue this to get merged to stage & production.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-feature New block or other feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants