MWPW-158475 [MEP] classes that end in a number are modified when they should not be #2886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## mepanymarqueesection #2886 +/- ##
=====================================================
Coverage 96.26% 96.26%
=====================================================
Files 238 238
Lines 54317 54317
=====================================================
Hits 52286 52286
Misses 2031 2031 ☔ View full report in Codecov by Sentry. |
ivanvatadobe
approved these changes
Sep 16, 2024
markpadbe
approved these changes
Sep 16, 2024
denlight
approved these changes
Sep 16, 2024
milo-pr-merge bot
pushed a commit
that referenced
this pull request
Sep 17, 2024
* MWPW-158462 [MEP] any-marquee-section simplified selector * unit test update * MWPW-158475 [MEP] classes that end in a number are modified when they should not be (#2886) * unit test update * MWPW-158475 [MEP] classes that end in a number are modified when they should not be * unit test repair * unit test repair * MWPW-157686 [MEP] Cannot spoof an experience that exists in manifest but not in Target (#2887) * working so far * lint update * update something merging stage did not
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detailed Description: If a manifest uses a variant that ends in a number (example:
.aside02) it is interpreted incorrectly.................................
URL: https://main--cc--adobecom.hlx.page/drafts/mepdev/fragments/2024/q4/mepclassendinginnumber/?mepHighlight=true
................................
Steps to Reproduce:
Expected Results: 2nd aside should be removed
................................
Actual Results: 2nd aside is not removed
Resolves: MWPW-158475
Test URLs: