MWPW-157686 [MEP] Cannot spoof an experience that exists in manifest but not in Target #2887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## mepanymarqueesection #2887 +/- ##
=====================================================
Coverage 96.24% 96.24%
=====================================================
Files 237 237
Lines 54243 54240 -3
=====================================================
- Hits 52204 52202 -2
+ Misses 2039 2038 -1 ☔ View full report in Codecov by Sentry. |
markpadbe
approved these changes
Sep 16, 2024
ivanvatadobe
approved these changes
Sep 16, 2024
denlight
approved these changes
Sep 16, 2024
|
Reminder to set the |
milo-pr-merge bot
pushed a commit
that referenced
this pull request
Sep 17, 2024
* MWPW-158462 [MEP] any-marquee-section simplified selector * unit test update * MWPW-158475 [MEP] classes that end in a number are modified when they should not be (#2886) * unit test update * MWPW-158475 [MEP] classes that end in a number are modified when they should not be * unit test repair * unit test repair * MWPW-157686 [MEP] Cannot spoof an experience that exists in manifest but not in Target (#2887) * working so far * lint update * update something merging stage did not
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: this is the 2nd attempt to fix this bug. Attempt 1 fixed the bug but broke selecting the correct experience from Target when there was no spoof. This fix also makes sure to select the correct placeholder column by not choosing until after the manifests are merged.
When you have a pzn manifest with some Target columns and some non Target columns, it is often placed in the pzn metadata AND in Target. If a column is added to the manifest but Target is not updated, then you see the new experience in the MEP button, but you cannot spoof it with the manifest.
QA instructions: go to the before and after links below and expand the MEP button. "mobile-device" is correctly selected only in the after link
Resolves: MWPW-157686
Test URLs:
Not spoofing an experience (should continue to choose target-my_pzn):
Before: https://main--cc--adobecom.hlx.page/drafts/mepdev/fragments/2024/q4/mepbugpzn/pznnotupdatedintarget?at_preview_token=5AB35DHSLjOM9UmmfvmJmg&at_preview_index=1_1&at_preview_listed_activities_only=true
After: https://main--cc--adobecom.hlx.page/drafts/mepdev/fragments/2024/q4/mepbugpzn/pznnotupdatedintarget?at_preview_token=5AB35DHSLjOM9UmmfvmJmg&at_preview_index=1_1&at_preview_listed_activities_only=true&milolibs=meptargetfix
Spoofing an experience (should choose mobile-device and add "Hello world" below marquee):
Before: https://main--cc--adobecom.hlx.page/drafts/mepdev/fragments/2024/q4/mepbugpzn/pznnotupdatedintarget?at_preview_token=5AB35DHSLjOM9UmmfvmJmg&at_preview_index=1_1&at_preview_listed_activities_only=true&mep=%2Fdrafts%2Fmepdev%2Ffragments%2F2024%2Fq4%2Fmepbugpzn%2Fpznnotupdatedintarget.json--mobile-device
After: https://main--cc--adobecom.hlx.page/drafts/mepdev/fragments/2024/q4/mepbugpzn/pznnotupdatedintarget?at_preview_token=5AB35DHSLjOM9UmmfvmJmg&at_preview_index=1_1&at_preview_listed_activities_only=true&milolibs=meptargetfix&mep=%2Fdrafts%2Fmepdev%2Ffragments%2F2024%2Fq4%2Fmepbugpzn%2Fpznnotupdatedintarget.json--mobile-device
Psi-check: https://meptargetfix--milo--adobecom.hlx.page/?martech=off