MWPW-152411 raw md doc for web components & events #2903
Conversation
- will need some jsdocs flesh in comments for both components & events, - can be linked from or to with card specific doc pages
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #2903 +/- ##
==========================================
- Coverage 96.24% 96.24% -0.01%
==========================================
Files 236 236
Lines 54253 54264 +11
==========================================
+ Hits 52216 52224 +8
- Misses 2037 2040 +3 ☔ View full report in Codecov by Sentry. |
| * HTML Checkout Link Anchor element, extends anchor | ||
| * | ||
| * @element a[data-wcs-osi] | ||
| * @fires merch:click |
There was a problem hiding this comment.
it doesn't fire merch:click though.
There was a problem hiding this comment.
right, this was a test, i'll remove it
There was a problem hiding this comment.
(click doc will come with click event pr)
| /** | ||
| * HTML Price Web Component, extends span | ||
| * | ||
| * @element span[data-wcs-osi] |
| /** @type {Commerce.Price.PlaceholderConstructor} */ | ||
| /** | ||
| * HTML Price Web Component, extends span. | ||
| * special member _onceSettled_ promise that either resolves or fail with web commerce information. |
There was a problem hiding this comment.
it always resolves actually. when it fails, it will add placeholder-failed class to the element.
| # merch-twp-d2p | ||
|
|
||
|
|
||
| # merch-whats-included |
There was a problem hiding this comment.
I would not include anything that is not ready yet like merch-subscription-panel, merch-twp-d2p, merch-whats-included Comment
|
closing for now :) |
Test URLs: