Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MWPW-158756] Enhance stage links conversion for cross-domain localization #2913

Merged

Conversation

robert-bogos
Copy link
Contributor

Description

This PR enhances the stage links conversion feature to handle cross-domain localization.

Related Issue

Resolves: MWPW-158756

Testing instructions

  1. open the after test URL

  2. using the developer tools, overwrite scrips.js to :

  • have 'business.adobe.com' in the prodDomains array;
  • have
  '--milo--robert-bogos.hlx.page': {
    'business.adobe.com': 'main--bacom--adobecom.hlx.page'
  }

in the stageDomainsMap config.

Screenshot 2024-09-19 at 15 38 28
  1. the business.adobe.com url should be converted and localized
Screenshot 2024-09-19 at 15 43 06

Test URLs

Milo:

@robert-bogos robert-bogos requested a review from a team September 19, 2024 12:48
@robert-bogos robert-bogos self-assigned this Sep 19, 2024
@robert-bogos robert-bogos requested a review from a team as a code owner September 19, 2024 12:48
Copy link
Contributor

aem-code-sync bot commented Sep 19, 2024

Copy link

codecov bot commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.24%. Comparing base (549c71f) to head (cc0e479).
Report is 1 commits behind head on stage.

Additional details and impacted files
@@           Coverage Diff           @@
##            stage    #2913   +/-   ##
=======================================
  Coverage   96.23%   96.24%           
=======================================
  Files         236      236           
  Lines       54253    54254    +1     
=======================================
+ Hits        52213    52217    +4     
+ Misses       2040     2037    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mokimo mokimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should write a unit test for this case as well

libs/utils/utils.js Outdated Show resolved Hide resolved
@SilviuLCF SilviuLCF self-requested a review September 19, 2024 13:31
Copy link

@SilviuLCF SilviuLCF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready for STAGE
Testing details https://jira.corp.adobe.com/browse/MWPW-158756

@milo-pr-merge
Copy link
Contributor

milo-pr-merge bot commented Sep 19, 2024

Skipped merging 2913: [MWPW-158756] Enhance stage links conversion for cross-domain localization due to failing checks

@robert-bogos robert-bogos merged commit 740348c into adobecom:stage Sep 19, 2024
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants