-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MWPW-158077 rollout new Timeline block #2926
base: stage
Are you sure you want to change the base?
Conversation
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #2926 +/- ##
==========================================
+ Coverage 96.24% 96.25% +0.01%
==========================================
Files 236 237 +1
Lines 54278 54432 +154
==========================================
+ Hits 52241 52395 +154
Misses 2037 2037 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
.dialog-modal .timeline { | ||
padding: 0 var(--spacing-xl) var(--spacing-xl) var(--spacing-xl); | ||
} | ||
} | ||
|
||
@media screen and (min-width: 1200px) { | ||
@media screen and (min-width:1120px) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
curious what the reason was to switch to 1120
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this was part of a request for 10 col max width and mirrors what I see in the codebase for .section.grid-width-10
Reminder to set the |
Skipped 2926: "MWPW-158077 rollout new Timeline block" due to file "libs/utils/utils.js" overlap. Merging will be attempted in the next batch |
1 similar comment
Skipped 2926: "MWPW-158077 rollout new Timeline block" due to file "libs/utils/utils.js" overlap. Merging will be attempted in the next batch |
Adds new block: timeline
Resolves: MWPW-158077
QA test link: https://main--cc--adobecom.hlx.page/drafts/markp/timeline?milolibs=timelinerollout
Test URLs: