MWPW-158473: CCD Suggested Card [Merch card] #2927
Conversation
Axelcureno
added
commerce
needs-verification
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
There was a problem hiding this comment.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
There was a problem hiding this comment.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
There was a problem hiding this comment.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
There was a problem hiding this comment.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
There was a problem hiding this comment.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
There was a problem hiding this comment.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
There was a problem hiding this comment.
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## stage #2927 +/- ##
==========================================
+ Coverage 96.23% 96.24% +0.01%
==========================================
Files 237 238 +1
Lines 54242 54442 +200
==========================================
+ Hits 52198 52400 +202
+ Misses 2044 2042 -2 ☔ View full report in Codecov by Sentry. |
|
This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR. |
|
|
||
| merch-card[variant="ccd-suggested"] [slot='detail-m'] { | ||
| color: var(--merch-color-grey-60); | ||
| } | ||
|
|
||
| merch-card[variant="ccd-suggested"] [slot='icons'] { | ||
| flex-flow: wrap; | ||
| place-self: flex-start; | ||
| } | ||
|
|
||
| merch-card[variant="ccd-suggested"] [slot='heading-xs'] { | ||
| font-size: var(--consonant-merch-card-heading-xxs-font-size); | ||
| line-height: var(--consonant-merch-card-heading-xxs-line-height); | ||
|
|
||
| } | ||
|
|
||
| merch-card[variant="ccd-suggested"] [slot='price'] { | ||
| display: flex; | ||
| align-items: center; | ||
| } | ||
|
|
||
| merch-card[variant="ccd-suggested"] [slot='cta'] { | ||
| display: flex; | ||
| align-items: center; | ||
| } |
There was a problem hiding this comment.
pls move shadow dom styling to variantStyles
| constructor(card) { | ||
| super(card); | ||
| } | ||
|
|
There was a problem hiding this comment.
please remove and use one pixel image from the other PR
Introduces Creative Cloud Desktop 'Suggested' Card to the list of web components as part of M@S v2 initiative.
Notes:
This card is not part of Milo block library and is part of a CCD integration.
To test this card, run npm run test from web-components folder and select debug, then select the option test/merch-card.ccd-suggested.test.html to see the 3 variations (top to bottom of screenshot): standard, wide strip background and small strip background.
Resolves: MWPW-158473
Test URLs:
Before: https://main--milo--adobecom.hlx.page/?martech=off
After: https://mwpw-158053--milo--adobecom.hlx.page/?martech=off