MWPW-155333 - [FloodgateUI] Fragment Validation Updates #2929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
Commits
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Comment on lines
36
to
37
| title=${fragmentStatusCheck.value === 'IN PROGRESS' ? inProgressTitleFragment : urls.value.length < 1 | ||
| ? 'Add urls to the excel sheet in order to access this operation.' : ''} |
There was a problem hiding this comment.
🚫 [eslint] <no-nested-ternary> reported by reviewdog 🐶
Do not nest ternary expressions.
| @@ -33,7 +32,7 @@ | |||
| ${html` | |||
| <button | |||
| class="fgui-urls-heading-action" | |||
| onClick=${findFragments} | |||
| onClick=${findAllFragments} | |||
| title=${fragmentStatusCheck.value === 'IN PROGRESS' ? inProgressTitleFragment : urls.value.length < 1 | |||
| ? 'Add urls to the excel sheet in order to access this operation.' : ''} | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional changes on validation of found fragments that will set new fragments and URLs in excel with validated URLs.
Resolves: MWPW-155333
Test URLs: (find fragments and see URL has been validated "NOT AEM URL")