Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Release] Stage to Main #2965

Merged
merged 6 commits into from
Sep 30, 2024
Merged

[Release] Stage to Main #2965

merged 6 commits into from
Sep 30, 2024

Conversation

milo-pr-merge[bot]
Copy link
Contributor

@milo-pr-merge milo-pr-merge bot commented Sep 26, 2024 •
edited by mokimo
Loading

common base root URLs

Homepage : https://www.stage.adobe.com/
BACOM: https://business.stage.adobe.com/fr/
CC: https://www.stage.adobe.com/creativecloud.html
Blog: https://blog.stage.adobe.com/
Acrobat: https://www.stage.adobe.com/acrobat/online/sign-pdf.html

Milo:

rahulgupta999 and others added 4 commits September 26, 2024 14:40
@rahulgupta999
[MWPW-158004] Fix callout & grey line alignment issues in product mer…
78d5895 
…ch cards (#2946)

* Fix for MWPW-158004

* remove comments

* Adjust slots

* button fix

* add new body-lower slot for product card

* update deps

* Add unit test

* Add local unit test case for mas

* Add eventlistener to resize

* removed debug statements and comments

* UT failure

* Review comment

* ccov

* review comments
@sharmrj
MWPW-155489 [PEP] Add device type as PEP criteria (#2931)
96edd14 
PEP now checks if the the useragent is one of a number of mobile devices.
@akanshaa-18
Jarvis stage URL for Acom stage env (#2948)
e6e12c8 
* Jarvis stage for acom stage env

* Added test cases for asset URL verification

* Added test cases for asset URL verification

* Revert "Added test cases for asset URL verification"

This reverts commit 324e62c.

:wq#

* Clean up code by removing lint errors

* Revert "Clean up code by removing lint errors"

This reverts commit ae4dadc.

* Clean up code by removing lint errors

---------

Co-authored-by: Akansha Arora <>
@overmyheadandbody
[MWPW-156723] Add option for brick stroke (#2954)
e364702
@milo-pr-merge
Copy link
Contributor Author

milo-pr-merge bot commented Sep 26, 2024

Testing can start @adobecom/miq-sot @adobecom/bacom-sot @adobecom/homepage-sot @adobecom/creative-cloud-sot @adobecom/document-cloud-sot

@aem-code-sync AEM Code Sync
Copy link
Contributor

aem-code-sync bot commented Sep 26, 2024 •
edited
Loading

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@aem-code-sync AEM Code Sync
Copy link
Contributor

aem-code-sync bot commented Sep 26, 2024 •
edited
Loading

Page Scores Audits Google
📱 /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

github-actions[bot]
github-actions bot reviewed Sep 26, 2024
View reviewed changes
libs/deps/mas/mas.js
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions[bot]
github-actions bot reviewed Sep 26, 2024
View reviewed changes
libs/deps/mas/merch-card.js
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions[bot]
github-actions bot reviewed Sep 26, 2024
View reviewed changes
libs/features/mas/web-components/src/variants/mini-compare-chart.js
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions[bot]
github-actions bot reviewed Sep 26, 2024
View reviewed changes
libs/features/mas/web-components/src/variants/product.js
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions[bot]
github-actions bot reviewed Sep 26, 2024
View reviewed changes
libs/features/mas/web-components/src/variants/variant-layout.js
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions[bot]
github-actions bot reviewed Sep 26, 2024
View reviewed changes
libs/features/mas/web-components/src/variants/variants.js
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions[bot]
github-actions bot reviewed Sep 26, 2024
View reviewed changes
libs/features/mas/web-components/test/merch-card-product.test.html.js
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] reported by reviewdog 🐶
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

@codecov Codecov
Copy link

codecov bot commented Sep 26, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.31%. Comparing base (501a373) to head (4bc2230).
Report is 61 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff            @@
##             main    #2965    +/-   ##
========================================
  Coverage   96.30%   96.31%            
========================================
  Files         242      242            
  Lines       54873    54987   +114     
========================================
+ Hits        52845    52959   +114     
  Misses       2028     2028

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Deva309
[MWPW-158932] - Add support for custom links through link group in pa…
05ebf1f 
…rallel to large menu. (#2942)

* Add support for custom links through link group in parallet to large menu

* Added UT for the changes

* lint fixes

* Bug fix mwpw-159018

* Bug fix mwpw-159018

* Bug fix mwpw-159018
github-actions[bot]
github-actions bot reviewed Sep 26, 2024
View reviewed changes
libs/navigation/navigation.js
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <no-console> reported by reviewdog 🐶
Unexpected console statement.

milo/libs/navigation/navigation.js

Line 48 in 05ebf1f

console.error('Global navigation Error: header and footer configurations are missing.');

@markpadbe
MWPW-158652 [MEP] Only output non fatal errors to internal users and …
4bc2230 
…skip rows missing an action value (#2941)

* Add previewLog

* Add another log

* Add warn

* Remove unecessary log

* Update tests

* Update warn log

* Add code coverage for empty action

* Remove commented code
@milo-pr-merge milo-pr-merge bot merged commit 23e81de into main Sep 30, 2024
75 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@sigadamvenkata sigadamvenkata sigadamvenkata approved these changes

@Roycethan Roycethan Roycethan approved these changes

@JackySun9 JackySun9 JackySun9 approved these changes

@Dli3 Dli3 Dli3 approved these changes

@salonijain3 salonijain3 Awaiting requested review from salonijain3 salonijain3 is a code owner

@bandana147 bandana147 Awaiting requested review from bandana147 bandana147 is a code owner

@sharmrj sharmrj Awaiting requested review from sharmrj sharmrj is a code owner

@nishantka nishantka Awaiting requested review from nishantka nishantka is a code owner

@Deva309 Deva309 Awaiting requested review from Deva309 Deva309 is a code owner

@sonawanesnehal3 sonawanesnehal3 Awaiting requested review from sonawanesnehal3 sonawanesnehal3 is a code owner

Assignees
No one assigned
Labels
BAcom SOT 👌 CC SOT 👌 Homepage SOT 👌 MIQ SOT👌 run-nala-on-caas
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.