Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MWPW-160360 - Decorate standalone text with body default styles #3060

Merged
merged 24 commits into from
Nov 7, 2024

Conversation

Sartxi
Copy link
Contributor

@Sartxi Sartxi commented Oct 17, 2024

When standalone content is not decorated according to its format or a text style override, the decorate text function will add default body styling like it does with other empty elements.

This will apply default styles to text in consonant blocks that use the shared text decorate functionality.

Resolves: MWPW-160360

Test URLs:

@Sartxi Sartxi added bug Something isn't working needs-verification PR requires E2E testing by a reviewer labels Oct 17, 2024
Copy link
Contributor

aem-code-sync bot commented Oct 17, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link
Contributor

aem-code-sync bot commented Oct 17, 2024

Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.35%. Comparing base (1e16205) to head (e08bd9f).
Report is 18 commits behind head on stage.

Additional details and impacted files
@@            Coverage Diff             @@
##            stage    #3060      +/-   ##
==========================================
- Coverage   96.35%   96.35%   -0.01%     
==========================================
  Files         245      245              
  Lines       56365    56424      +59     
==========================================
+ Hits        54311    54367      +56     
- Misses       2054     2057       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aem-code-sync aem-code-sync bot temporarily deployed to sartxi/MWPW-160360-text October 17, 2024 22:31 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to sartxi/MWPW-160360-text October 18, 2024 16:17 Inactive
@Sartxi Sartxi marked this pull request as ready for review October 18, 2024 16:50
Copy link
Contributor

This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR.

Copy link
Contributor

This PR has not been updated recently and will be closed in 7 days if no action is taken. Please ensure all checks are passing, https://github.com/orgs/adobecom/discussions/997 provides instructions. If the PR is ready to be merged, please mark it with the "Ready for Stage" label.

@github-actions github-actions bot added Stale and removed Stale labels Oct 27, 2024
libs/utils/utils.js Outdated Show resolved Hide resolved
@aem-code-sync aem-code-sync bot temporarily deployed to sartxi/MWPW-160360-text October 28, 2024 15:46 Inactive
@Sartxi Sartxi requested a review from mokimo October 28, 2024 15:47
@aem-code-sync aem-code-sync bot temporarily deployed to sartxi/MWPW-160360-text October 28, 2024 16:02 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to sartxi/MWPW-160360-text October 28, 2024 17:09 Inactive
libs/utils/decorate.js Outdated Show resolved Hide resolved
@milo-pr-merge
Copy link
Contributor

milo-pr-merge bot commented Nov 1, 2024

Skipped merging 3060: MWPW-160360 - Decorate standalone text with body default styles due to failing checks

3 similar comments
@milo-pr-merge
Copy link
Contributor

milo-pr-merge bot commented Nov 2, 2024

Skipped merging 3060: MWPW-160360 - Decorate standalone text with body default styles due to failing checks

@milo-pr-merge
Copy link
Contributor

milo-pr-merge bot commented Nov 3, 2024

Skipped merging 3060: MWPW-160360 - Decorate standalone text with body default styles due to failing checks

@milo-pr-merge
Copy link
Contributor

milo-pr-merge bot commented Nov 4, 2024

Skipped merging 3060: MWPW-160360 - Decorate standalone text with body default styles due to failing checks

@aem-code-sync aem-code-sync bot temporarily deployed to sartxi/MWPW-160360-text November 4, 2024 18:23 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to sartxi/MWPW-160360-text November 4, 2024 18:47 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to sartxi/MWPW-160360-text November 4, 2024 18:59 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to sartxi/MWPW-160360-text November 5, 2024 00:31 Inactive
Copy link
Contributor

@robert-bogos robert-bogos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would still try to find the reason why the Nala tests are failing 🤔

@milo-pr-merge
Copy link
Contributor

milo-pr-merge bot commented Nov 6, 2024

Skipped merging 3060: MWPW-160360 - Decorate standalone text with body default styles due to failing checks

@milo-pr-merge milo-pr-merge bot merged commit 36e869f into stage Nov 7, 2024
14 checks passed
@milo-pr-merge milo-pr-merge bot deleted the sartxi/MWPW-160360-text branch November 7, 2024 18:44
@milo-pr-merge milo-pr-merge bot mentioned this pull request Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Ready for Stage verified PR has been E2E tested by a reviewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants