MWPW-157506: Localized Placeholder Texts on English Pages #3177
+63
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sivasadobe
requested review from
npeltier,
salonijain3,
aishwaryamathuria,
drashti1712,
mokimo,
Ruchika4,
suhjainadobe and
AdobeLinhart
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #3177 +/- ##
=======================================
Coverage 96.38% 96.38%
=======================================
Files 245 245
Lines 56651 56689 +38
=======================================
+ Hits 54601 54641 +40
+ Misses 2050 2048 -2 ☔ View full report in Codecov by Sentry. |
hparra
approved these changes
Nov 14, 2024
There was a problem hiding this comment.
This "after" page 404s for me: https://mwpw-157506--milo--adobecom.hlx.page/drafts/siva/157506/placeholder-example
CC before/after checks out:
axe unnecessary regex in test.
|
|
||
| it('Replaces geo-specific placeholders when disable-geo-placeholders meta content is "off" or meta tag not defined', async () => { | ||
| config.locale.contentRoot = '/test/features/placeholders/bg'; | ||
| const regex = /{{(.*?)}}|%7B%7B(.*?)%7D%7D/g; |
There was a problem hiding this comment.
fixme: regex like this in a test caught my eye 
luckily it's unnecessary because it's already default parameter in replaceText (107)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
disable-geo-placeholdersmeta tag."off", the application receives geo-specific placeholders. If the tag is set to"on", it defaults to generic placeholders.Resolves: MWPW-157506
GH: https://github.com/orgs/adobecom/discussions/2791
Test URLs:
Milo
CC