Skip to content

Commit

Permalink
chore: Bump node version used on GitHub
Browse files Browse the repository at this point in the history
- While [adding trivial change the the code](#365) I bumped into CI being red from various reasons [last one](https://github.com/rwjblue/ember-cli-content-security-policy/actions/runs/8820844298/job/24215355798?pr=365) ended with a hard error on:
```
 [3/5] Fetching packages...
error [email protected]: The engine "node" is incompatible with this module. Expected version "16.* || 18.* || >= 20". Got "12.22.12"
error Found incompatible module.
```
- I tried to reproduce locally, but `[email protected]` is surprisingly not trivial to install on modern OSX without breaking my other projects.
- I tried to consult the [node support](https://github.com/ember-cli/ember-cli/blob/master/docs/node-support.md) matrix for EmberJS and since `16.x` is supported through `3.28.0 - 5.3.0`, it seems like a safe bet.
  • Loading branch information
MichalBryxi committed Apr 25, 2024
1 parent b6c3e09 commit 656b38c
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ on:
pull_request:

env:
NODE_VERSION: '12.x'
NODE_VERSION: '16.x'

jobs:
lint:
Expand Down

0 comments on commit 656b38c

Please sign in to comment.