fix: Example allows manifest from self #365
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
MichalBryxi
commented
Apr 16, 2024
MichalBryxi
commented
- Given example is quite handy starting copy&paste.
- Unfortunatelly for Chrome with modern Ember apps it gives:
- This patch makes the README as a nicer starting point.
|
I'm wondering if we should update the default configuration as well: https://github.com/rwjblue/ember-cli-content-security-policy/blob/b6c3e093203acdba8b954442e49c0e91a6d25478/lib/utils.js#L73-L87 and https://github.com/rwjblue/ember-cli-content-security-policy/blob/b6c3e093203acdba8b954442e49c0e91a6d25478/README.md?plain=1#L94-L116 |
|
Good point @jelhan. Added. |
|
Not sure why the CI gods are angry ... |
It seems to fail due to Prettier formatting: |
MichalBryxi
force-pushed
the
patch-1
branch
2 times, most recently
from
154f437 to
1fa3569
Compare
- Given example is quite handy starting copy&paste. - Unfortunatelly for Chrome with modern Ember apps it gives: ``` assessment:1 Refused to load manifest from 'http://localhost:4200/manifest.webmanifest' because it violates the following Content Security Policy directive: "default-src 'none'". Note that 'manifest-src' was not explicitly set, so 'default-src' is used as a fallback. ``` - This patch makes the README as a nicer starting point.
|
Even change in Readme would mean running CI, which is borked now. Just going to close this for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.