-
-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a block for adoptium news on the main page #2886
Merged
xavierfacq
merged 10 commits into
adoptium:main
from
xavierfacq:2862-add-a-block-for-adoptium-news-on-the-main-page
May 30, 2024
Merged
Add a block for adoptium news on the main page #2886
xavierfacq
merged 10 commits into
adoptium:main
from
xavierfacq:2862-add-a-block-for-adoptium-news-on-the-main-page
May 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for eclipsefdn-adoptium ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2886 +/- ##
=======================================
Coverage 99.43% 99.43%
=======================================
Files 89 90 +1
Lines 6881 6937 +56
Branches 605 608 +3
=======================================
+ Hits 6842 6898 +56
Misses 39 39 ☔ View full report in Codecov by Sentry. |
Content is related to #2877 |
… github.com:xavierfacq/adoptium.net into 2862-add-a-block-for-adoptium-news-on-the-main-page
karianna
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
This is a PR related to issues #2862 (feature) and #2877 (content)
Currently the content of the news is in written in the tsx file, like for banner. We can think about something else in the future.
Checklist
npm test
passes