Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a block for adoptium news on the main page #2886

Conversation

xavierfacq
Copy link
Member

@xavierfacq xavierfacq commented May 29, 2024

Description of change

This is a PR related to issues #2862 (feature) and #2877 (content)
Currently the content of the news is in written in the tsx file, like for banner. We can think about something else in the future.

Checklist

  • npm test passes

Copy link

netlify bot commented May 29, 2024

Deploy Preview for eclipsefdn-adoptium ready!

Name Link
🔨 Latest commit 0ae8193
🔍 Latest deploy log https://app.netlify.com/sites/eclipsefdn-adoptium/deploys/665821e43eeda70008b565ab
😎 Deploy Preview https://deploy-preview-2886--eclipsefdn-adoptium.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented May 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.43%. Comparing base (5acdd5b) to head (0ae8193).
Report is 11 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2886   +/-   ##
=======================================
  Coverage   99.43%   99.43%           
=======================================
  Files          89       90    +1     
  Lines        6881     6937   +56     
  Branches      605      608    +3     
=======================================
+ Hits         6842     6898   +56     
  Misses         39       39           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xavierfacq
Copy link
Member Author

Content is related to #2877

@xavierfacq xavierfacq marked this pull request as ready for review May 30, 2024 06:38
@xavierfacq xavierfacq marked this pull request as draft May 30, 2024 06:40
… github.com:xavierfacq/adoptium.net into 2862-add-a-block-for-adoptium-news-on-the-main-page
@xavierfacq xavierfacq requested a review from gdams May 30, 2024 06:59
@xavierfacq xavierfacq marked this pull request as ready for review May 30, 2024 06:59
@xavierfacq xavierfacq merged commit f01e08a into adoptium:main May 30, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants