Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add July banner #2963

Merged
merged 1 commit into from
Jul 17, 2024
Merged

Add July banner #2963

merged 1 commit into from
Jul 17, 2024

Conversation

smlambert
Copy link
Contributor

Description of change

Checklist

  • npm test passes
  • documentation is changed or added (if applicable)
  • permission has been obtained to add new logo (if applicable)
  • contribution guidelines followed here

Signed-off-by: Shelley Lambert <[email protected]>
Copy link

netlify bot commented Jul 15, 2024

Deploy Preview for eclipsefdn-adoptium ready!

Name Link
🔨 Latest commit c1c4274
🔍 Latest deploy log https://app.netlify.com/sites/eclipsefdn-adoptium/deploys/669555bf95fba500087cf3bd
😎 Deploy Preview https://deploy-preview-2963--eclipsefdn-adoptium.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Jul 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.14%. Comparing base (ff2d416) to head (c1c4274).
Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2963   +/-   ##
=======================================
  Coverage   99.14%   99.14%           
=======================================
  Files          90       90           
  Lines        4931     4938    +7     
  Branches      611      611           
=======================================
+ Hits         4889     4896    +7     
  Misses         42       42           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xavierfacq
Copy link
Member

We have now a component AdoptiumNews that can be used to describe a News without using the Banner.
You can take a look at the file if you want to configure it.

@sxa sxa marked this pull request as ready for review July 17, 2024 08:55
@sxa
Copy link
Member

sxa commented Jul 17, 2024

We have now a component AdoptiumNews that can be used to describe a News without using the Banner. You can take a look at the file if you want to configure it.

Thanks - we can look at that for the next cycle (If you can add a comment mentioning this to adoptium/temurin#50 we won't forget about it ;-) )

@sxa sxa closed this Jul 17, 2024
@sxa sxa reopened this Jul 17, 2024
@smlambert smlambert merged commit e9c86ab into adoptium:main Jul 17, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants