Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[issue-3106] Display last release not when no version is provided #3188

Conversation

xavierfacq
Copy link
Member

@xavierfacq xavierfacq commented Nov 2, 2024

Goal of this PR is to display elements of the published LTS version when no version is provided in the URL.

test here: https://deploy-preview-3188--eclipsefdn-adoptium.netlify.app/fr/temurin/release-notes/

Checklist

  • npm test passes

@xavierfacq xavierfacq marked this pull request as draft November 2, 2024 17:51
Copy link

netlify bot commented Nov 2, 2024

Deploy Preview for eclipsefdn-adoptium ready!

Name Link
🔨 Latest commit 3c9148c
🔍 Latest deploy log https://app.netlify.com/sites/eclipsefdn-adoptium/deploys/6727d7697238cd00080b2ba8
😎 Deploy Preview https://deploy-preview-3188--eclipsefdn-adoptium.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Nov 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.45%. Comparing base (e0110cd) to head (3c9148c).
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3188   +/-   ##
=======================================
  Coverage   99.45%   99.45%           
=======================================
  Files          90       90           
  Lines        4755     4763    +8     
  Branches      624      626    +2     
=======================================
+ Hits         4729     4737    +8     
  Misses         26       26           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xavierfacq xavierfacq marked this pull request as ready for review November 3, 2024 11:19
@xavierfacq xavierfacq merged commit c6179e3 into adoptium:main Nov 6, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants