Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set testenv.properties to dry run tags #5202

Merged
merged 1 commit into from
Apr 6, 2024

Conversation

sxa
Copy link
Member

@sxa sxa commented Apr 6, 2024

dry run release triggers do not work properly unless the triggered tags exist in testenv.properties. This caused a knock on issue which prevents subsequent triggers from working properly.

I have used jdk-22.0.0-dryrun-ga instead of 22.0.1 because there are no viisble tags we can use so I've used an earlier version number to avoid confusion and attached it to a recent commit in the repository.

More details in the #build slack thread.

@sxa sxa requested a review from smlambert April 6, 2024 11:41
@sxa sxa self-assigned this Apr 6, 2024
@smlambert
Copy link
Contributor

We will proceed with this temporary change for April dryruns, but created adoptium/ci-jenkins-pipelines#994 as we should be able to handle the dryrun case in such a way that does not need us to make these late-in-game changes to this file.

@smlambert smlambert merged commit 6a55b6c into adoptium:v1.0.1-release Apr 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants