Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Trial using context.bat instead of context.sh on Windows in docker #1103

Closed
wants to merge 17 commits into from

Conversation

sxa
Copy link
Member

@sxa sxa commented Sep 3, 2024

This is very much a 'work-in-progress' / feasibility study with the intention of diagnosing the problem described in adoptium/infrastructure#3714. The PR is not ready for review (since it's mostly debug information and experiments) but I'm creating it in the spirit of openness to go alongside the issue :-)

I have attempted to put comments against all of the context.sh operations which are performed inside the containers during a docker build to identify which ones are causing problems.

I have converted some of them to context.bat based on some of the trial runs (Noting that this cannot be a final solution as-is as it won't work on non-Windows systems unless an if windows block is used to switch between them).

The four-digit numbers in the battable lines are the line number in the openjdk_build_pipeline.groovy and the windbld numbers are the job runs of windbld which showed the problem, so are instances where we have definitely hit an issue with those.

@sxa sxa self-assigned this Sep 3, 2024
Copy link

github-actions bot commented Sep 3, 2024

Thank you for creating a pull request!

Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work).

Code Quality and Contributing Guidelines

If you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before.

Tests

Github actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation.

In order to run the advanced pipeline tests (executing a set of mock pipelines), it requires an admin to post run tests on this PR.
If you are not an admin, please ask for one's attention in #infrastructure on Slack or ping one here.
To run full set of tests, use "run tests"; a subset of tests on specific jdk version, use "run tests quick 11,21"

Signed-off-by: Stewart X Addison <[email protected]>
@karianna karianna marked this pull request as draft September 3, 2024 11:36
@sxa sxa force-pushed the docker_windows_batch branch 20 times, most recently from cce3768 to 3ef6092 Compare September 4, 2024 12:52
@sxa sxa force-pushed the docker_windows_batch branch 16 times, most recently from 7773e9a to 99a9cdf Compare September 9, 2024 11:22
Signed-off-by: Stewart X Addison <[email protected]>
@sxa sxa force-pushed the docker_windows_batch branch 6 times, most recently from 3ec7169 to 61b2efd Compare September 9, 2024 13:57
@sxa
Copy link
Member Author

sxa commented Oct 3, 2024

Will be integrated into #1117

@sxa sxa closed this Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants