Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jdk23+ update version GA tag check should be using updates repo (#1127) #1128

Merged
merged 1 commit into from
Oct 16, 2024
Merged

jdk23+ update version GA tag check should be using updates repo (#1127) #1128

merged 1 commit into from
Oct 16, 2024

Conversation

andrew-m-leonard
Copy link
Contributor

Cherry pick jdk23u GA tag fix commit into master: 277131e

@andrew-m-leonard
jdk23+ update version GA tag check should be using updates repo (adop…
042ad21 
…tium#1127)

* jdk-23.0.1 release jdkBranch GA tag check using wrong repo

Signed-off-by: Andrew Leonard <[email protected]>

* jdk-23.0.1 release jdkBranch GA tag check using wrong repo

Signed-off-by: Andrew Leonard <[email protected]>

---------

Signed-off-by: Andrew Leonard <[email protected]>
@andrew-m-leonard andrew-m-leonard self-assigned this Oct 16, 2024
@github-actions GitHub Actions
Copy link

Thank you for creating a pull request!

Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work).

Code Quality and Contributing Guidelines

If you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before.

Tests

Github actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation.

In order to run the advanced pipeline tests (executing a set of mock pipelines), it requires an admin to post run tests on this PR.
If you are not an admin, please ask for one's attention in #infrastructure on Slack or ping one here.
To run full set of tests, use "run tests"; a subset of tests on specific jdk version, use "run tests quick 11,21"

@andrew-m-leonard andrew-m-leonard requested review from steelhead31, sxa and adamfarley and removed request for sxa October 16, 2024 14:52
adamfarley
adamfarley approved these changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@adamfarley adamfarley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

steelhead31
steelhead31 approved these changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@steelhead31 steelhead31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@andrew-m-leonard andrew-m-leonard merged commit e32a17d into adoptium:master Oct 16, 2024
9 checks passed
sxa pushed a commit to sxa/ci-jenkins-pipelines that referenced this pull request Oct 31, 2024
@andrew-m-leonard @sxa
jdk23+ update version GA tag check should be using updates repo (adop…
26ce97f 
…tium#1127) (adoptium#1128)

* jdk-23.0.1 release jdkBranch GA tag check using wrong repo



* jdk-23.0.1 release jdkBranch GA tag check using wrong repo



---------

Signed-off-by: Andrew Leonard <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steelhead31 steelhead31 steelhead31 approved these changes

@adamfarley adamfarley adamfarley approved these changes

Assignees

@andrew-m-leonard andrew-m-leonard

Labels
jenkins-pipeline
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrew-m-leonard @adamfarley @steelhead31