Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding platforms to reproducibility healthcheck #1133

Merged
merged 12 commits into from
Nov 4, 2024

Conversation

adamfarley
Copy link
Contributor

We now have automated reproducibility testing on 3 more platforms, so we're checking their results as part of the daily healthcheck.

We now have automated reproducibility testing on 3 more platforms,
so we're checking their results as part of the daily healthcheck.

Signed-off-by: Adam Farley <[email protected]>
@adamfarley adamfarley self-assigned this Nov 1, 2024
@github-actions github-actions bot added code-tools Issues that are miscellaneous enhancements or bugs with our utilities that assist our build scripts testing labels Nov 1, 2024
Copy link

github-actions bot commented Nov 1, 2024

Thank you for creating a pull request!

Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work).

Code Quality and Contributing Guidelines

If you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before.

Tests

Github actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation.

In order to run the advanced pipeline tests (executing a set of mock pipelines), it requires an admin to post run tests on this PR.
If you are not an admin, please ask for one's attention in #infrastructure on Slack or ping one here.
To run full set of tests, use "run tests"; a subset of tests on specific jdk version, use "run tests quick 11,21"

Signed-off-by: Adam Farley <[email protected]>
Signed-off-by: Adam Farley <[email protected]>
Signed-off-by: Adam Farley <[email protected]>
Signed-off-by: Adam Farley <[email protected]>
Signed-off-by: Adam Farley <[email protected]>
@adamfarley adamfarley requested a review from sxa November 4, 2024 12:34
@adamfarley adamfarley enabled auto-merge (squash) November 4, 2024 12:35
@adamfarley
Copy link
Contributor Author

Tested and proven to work: https://adoptium.slack.com/archives/C09NW3L2J/p1730633449355769

Signed-off-by: Adam Farley <[email protected]>
@adamfarley
Copy link
Contributor Author

adamfarley commented Nov 4, 2024

Testing the linter fixes.

https://ci.adoptium.net/job/nightlyBuildAndTestStats_temurin/1722/console

Update: Ok, Jenkins doesn't like me using the BigDecimal round function due to the use of MathContext.

Found an alternative. Running here: https://ci.adoptium.net/job/nightlyBuildAndTestStats_temurin/1723/

Jenkins also does not like toBigInteger(). Will try another way.

https://ci.adoptium.net/job/nightlyBuildAndTestStats_temurin/1724/

stripTrailingZeros() this time. Switching method.

https://ci.adoptium.net/job/nightlyBuildAndTestStats_temurin/1725/

@adamfarley adamfarley enabled auto-merge (squash) November 4, 2024 17:09
@adamfarley
Copy link
Contributor Author

Ok, we're good to merge now. Fixed the Linter and Jenkins conflicts.

Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adamfarley adamfarley merged commit 36b02de into adoptium:master Nov 4, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-tools Issues that are miscellaneous enhancements or bugs with our utilities that assist our build scripts testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants