Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limit docker label to linux special.system #1135

Merged
merged 2 commits into from
Nov 6, 2024
Merged

Limit docker label to linux special.system #1135

merged 2 commits into from
Nov 6, 2024
+12 −9

Conversation

sophia-guo
Copy link
Contributor

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 5, 2024

Thank you for creating a pull request!

Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work).

Code Quality and Contributing Guidelines

If you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before.

Tests

Github actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation.

In order to run the advanced pipeline tests (executing a set of mock pipelines), it requires an admin to post run tests on this PR.
If you are not an admin, please ask for one's attention in #infrastructure on Slack or ping one here.
To run full set of tests, use "run tests"; a subset of tests on specific jdk version, use "run tests quick 11,21"

@sophia-guo sophia-guo mentioned this pull request Nov 5, 2024
Merged
smlambert
smlambert approved these changes Nov 6, 2024
View reviewed changes
Copy link
Contributor

@smlambert smlambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding a comment for future consideration only, does not block merging this PR.

pipelines/build/common/openjdk_build_pipeline.groovy Outdated
@@ -433,7 +435,7 @@ class Build {
DYNAMIC_COMPILE = true
}
def additionalTestLabel = buildConfig.ADDITIONAL_TEST_LABEL
if (testType == 'dev.openjdk' || testType == 'special.system') {
if (testType == 'dev.openjdk' || (testType == 'special.system' && jobName.contains('linux'))) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering if this adversely affects others using our pipelines (this is specific to Temurin (Eclipse Adoptium 'vendor' specific). Since no one has complained about this already, I will assume no, but future enhancement would be to frame it to only affect if vendor == Eclipse Adoptium).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated with buildConfig.VARIANT == 'temurin' with comment.

@sophia-guo sophia-guo merged commit f868061 into adoptium:master Nov 6, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smlambert smlambert smlambert approved these changes

@karianna karianna karianna approved these changes

Assignees
No one assigned
Labels
docker jenkins-pipeline linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sophia-guo @karianna @smlambert