Skip internal signing phase unless on windows/mac #1137
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation of the internal signing phase which was adjusted in #1117 (issue) caused that phase to be executed on more platforms than is necessary.
There are two fixes in here:
trim()
the output fromls
when settingbuild_path
so that it doesn't have a newline character on it (This was already done for windows but not on mac, but is required there too).Notes / alternative options:
ENABLE_SIGNER
for both signing situations instead of doing this on a platform basis (probably a good idea in the future)